Differential D17214 Diff 46420 plugins/sms/conversationsdbusinterface.cpp

Changeset View

Standalone View

View Options

plugins/sms/conversationsdbusinterface.cpp

Context not available.
122 const auto messagesList = m_conversations[conversationID]; 122​ const auto messagesList = m_conversations[conversationID];
123 if (messagesList.isEmpty()) { 123​ if (messagesList.isEmpty()) {
124 // Since there are no messages in the conversation, we can't do anything sensible 124​ // Since there are no messages in the conversation, we can't do anything sensible
125 qCWarning(KDECONNECT_CONVERSATIONS) << "Got a conversationID for a conversation with no messages!"; 125​ // qCDebug(KDECONNECT_CONVERSATIONS) << "Got a conversationID for a conversation with no messages!";
sredmanAuthorUnsubmitted
Not Done

No need to keep commented-out code

sredman: No need to keep commented-out code
126​ qCDebug(KDECONNECT_CONVERSATIONS) << "Trying to send a new message to new conversation with address " << conversationID << endl;
127​ createNewConversation(conversationID, message);
sredmanAuthorUnsubmitted
Not Done

You pass the conversationID here, which you have hard-coded (in the QML application) to 0. That means that the phone tries to send a message to the phone number "0" which is probably not what was intended. Did you mean message.address()?

sredman: You pass the conversationID here, which you have hard-coded (in the QML application) to 0. That…
126 return; 128​ return;
127 } 129​ }
128 // Caution: 130​ // Caution:
Context not available.
133 m_smsInterface.sendSms(address, message); 135​ m_smsInterface.sendSms(address, message);
134} 136​}
135 137​
138​void ConversationsDbusInterface::createNewConversation(const QString& address, const QString& message) {
139​ m_smsInterface.sendSms(address, message);
140​}
141​
136void ConversationsDbusInterface::requestAllConversationThreads() 142​void ConversationsDbusInterface::requestAllConversationThreads()
137{ 143​{
138 // Prepare the list of conversations by requesting the first in every thread 144​ // Prepare the list of conversations by requesting the first in every thread
Context not available.