Differential D17168 Diff 46260 duchain/builders/usebuilder.cpp

Changeset View

Standalone View

View Options

duchain/builders/usebuilder.cpp

Context not available.
87 const DeclarationPointer d = ev.lastDeclaration(); 87​ const DeclarationPointer d = ev.lastDeclaration();
88 if (d) { 88​ if (d) {
89 UseBuilderBase::newUse(m_editor->findRange(n), d); 89​ UseBuilderBase::newUse(m_editor->findRange(n), d);
90 ev.setContext(d->internalContext()); 90​ auto context = d->internalContext();
91​ // Setting invalid context doesn’t make sense and just causes fail in helpers.cpp’s context assert
92​ // TODO: maybe visitClassName() & co. needs this too?
93​ if(context) {
94​ ev.setContext(context);
95​ }
apolUnsubmitted
Not Done

assert after if doesn't make any sense.

apol: assert after if doesn't make any sense.
SmarAuthorUnsubmitted
Not Done

Yes, sorry for sloppy work.

Smar: Yes, sorry for sloppy work.
apolUnsubmitted
Not Done

This doesn't look like a to do item. The context should already be created anyway.

apol: This doesn't look like a to do item. The context should already be created anyway.
SmarAuthorUnsubmitted
Not Done

Okay, good to know. I wasn’t sure so I added a todo to remind myself that I should check it later. Related, should I also remove the latter todo?

Smar: Okay, good to know. I wasn’t sure so I added a todo to remind myself that I should check it…
91 } else { 96​ } else {
92 break; 97​ break;
93 } 98​ }
Context not available.