Differential D4929 Diff 46044 src/aboutbugreportingdialog.cpp

Changeset View

Standalone View

View Options

src/aboutbugreportingdialog.cpp

Show All 30 Lines
31#include <QPushButton> 31​#include <QPushButton>
32#include "drkonqi_globals.h" 32​#include "drkonqi_globals.h"
33 33​
34AboutBugReportingDialog::AboutBugReportingDialog(QWidget * parent): 34​AboutBugReportingDialog::AboutBugReportingDialog(QWidget * parent):
35 QDialog(parent) 35​ QDialog(parent)
36{ 36​{
37 setAttribute(Qt::WA_DeleteOnClose, true); 37​ setAttribute(Qt::WA_DeleteOnClose, true);
38 38​
39 setWindowIcon(QIcon::fromTheme(QStringLiteral("help-hint"))); 39​ setWindowIcon(QIcon::fromTheme(QStringLiteral("help-hint"), windowIcon()));
davidedmundsonUnsubmitted
Not Done
icon = QIcon::fromTheme
if (icon.isValid()) {
   setWindowIcon(...)
}

is more standard..

Though from the docs:

Note: On macOS, the window title bar icon is meant for windows representing documents, and will only show up if a file path is also set.

We don't set this, is this an issue?

davidedmundson: ``` icon = QIcon::fromTheme if (icon.isValid()) { setWindowIcon(...) } ``` is more standard.
rjvbbAuthorUnsubmitted
Not Done

Hmmm, this may have changed after I developed the brunt of this patch (in KDE4 days). To answer your question, no, it's not a problem.
I'll have to look at this again, to see if this and similar changes still make sense.

rjvbb: Hmmm, this may have changed after I developed the brunt of this patch (in KDE4 days). To answer…
40 setWindowTitle(i18nc("@title title of the dialog", "About Bug Reporting - Help")); 40​ setWindowTitle(i18nc("@title title of the dialog", "About Bug Reporting - Help"));
41 41​
42 QVBoxLayout* layout = new QVBoxLayout(this); 42​ QVBoxLayout* layout = new QVBoxLayout(this);
43 m_textBrowser = new QTextBrowser(this); 43​ m_textBrowser = new QTextBrowser(this);
44 m_textBrowser->setMinimumSize(QSize(600, 300)); 44​ m_textBrowser->setMinimumSize(QSize(600, 300));
45 connect(m_textBrowser, &QTextBrowser::anchorClicked, this, &AboutBugReportingDialog::handleInternalLinks); 45​ connect(m_textBrowser, &QTextBrowser::anchorClicked, this, &AboutBugReportingDialog::handleInternalLinks);
46 46​
47 QString text = 47​ QString text =
▲ Show 20 Lines • Show All 185 Lines • Show Last 20 Lines