Differential D16894 Diff 45786 modules/ECMAddCompilerFlag.cmake

Changeset View

Standalone View

View Options

modules/ECMAddCompilerFlag.cmake

  • This file was added.
1​#=============================================================================
2​# Copyright 2018 René J.V. Bertin <rjvbertin@gmail.com>
3​#
4​# Redistribution and use in source and binary forms, with or without
5​# modification, are permitted provided that the following conditions
6​# are met:
7​#
8​# 1. Redistributions of source code must retain the copyright
9​# notice, this list of conditions and the following disclaimer.
10​# 2. Redistributions in binary form must reproduce the copyright
11​# notice, this list of conditions and the following disclaimer in the
12​# documentation and/or other materials provided with the distribution.
13​# 3. The name of the author may not be used to endorse or promote products
14​# derived from this software without specific prior written permission.
15​#
16​# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
17​# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
18​# OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
19​# IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
20​# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
21​# NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
22​# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
23​# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
24​# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
25​# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26​
kropUnsubmitted
Done

Shall be moved after the module documentation

krop: Shall be moved after the module documentation
rjvbbAuthorUnsubmitted
Not Done

I'm guessing you meant "Please move [...]" and not that this would somehow happen automagically(?)

rjvbb: I'm guessing you meant "Please move [...]" and not that this would somehow happen automagically…
kropUnsubmitted
Not Done

Indeed.

krop: Indeed.
27​include(CMakeParseArguments)
28​include(CheckCXXCompilerFlag)
29​include(CheckCCompilerFlag)
30​
kropUnsubmitted
Done

Shall be moved after the license block

krop: Shall be moved after the license block
31​# ECM_ADD_CXX_COMPILER_FLAGS_IF_SUPPORTED(FLAGS <flag|flags>
32​# [SUPPORTED_IF <conditional expression>]
33​# )
34​# add <flag> or <flags> to CMAKE_CXX_FLAGS is the compiler supports them.
35​# Support is determined by the SUPPORTED_IF expression if provided or by
36​# querying the compiler directly otherwise. The compiler is also queried
37​# when using a Clang C++ compiler on APPLE.
38​# examples:
39​# Check
40​# ecm_add_cxx_compiler_flags_if_supported(FLAGS -a -b -c SUPPORTED_IF CMAKE_C_COMPILER_ID STREQUAL "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang")
41​# ecm_add_cxx_compiler_flags_if_supported(FLAGS -d -e -f)
42​#
43​# C-language equivalent:
44​# ECM_ADD_C_COMPILER_FLAGS_IF_SUPPORTED(FLAGS <flag|flags>
45​# [SUPPORTED_IF <conditional expression>]
46​# )
47​
48​
49​function (ECM_ADD_CXX_COMPILER_FLAGS_IF_SUPPORTED)
50​ set(_OPTIONS_ARGS)
51​ set(_ONE_VALUE_ARGS)
52​ set(_MULTI_VALUE_ARGS FLAGS SUPPORTED_IF)
53​
54​ cmake_parse_arguments(EASCXXFLAGS "${_OPTIONS_ARGS}" "${_ONE_VALUE_ARGS}" "${_MULTI_VALUE_ARGS}" ${ARGN} )
55​ if(NOT EASCXXFLAGS_FLAGS)
56​ message( FATAL_ERROR "ecm_add_cxx_compiler_flags_if_supported: 'FLAGS' is a required argument." )
57​ endif()
58​ # if the user provided supported_if conditions, evaluate them now:
59​ if (NOT EASCXXFLAGS_SUPPORTED_IF OR (${EASCXXFLAGS_SUPPORTED_IF}))
kropUnsubmitted
Done

Sphinx cannot parse this doc.

Also don't forget to create ECMAddCompilerFlag.rst in docs/modules/

krop: Sphinx cannot parse this doc. Also don't forget to create ECMAddCompilerFlag.rst in…
kropUnsubmitted
Done

Missing "Since 5.xx"

krop: Missing "Since 5.xx"
60​ # without conditions, or with Clang on APPLE we'll need to ask the compiler directly.
61​ # (Clang on APPLE needs verification because of Apple's llvm versions which cannot be
62​ # (matched easily to stock llvm versions.
kropUnsubmitted
Done

Unneeded extra space

krop: Unneeded extra space
63​ if(NOT EASCXXFLAGS_SUPPORTED_IF OR (APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang"))
64​ # one flag at a time:
65​ foreach(flag IN ITEMS ${EASCXXFLAGS_FLAGS})
66​ # use a standardised and informative cached test variable
67​ set(HASFLAG "${CMAKE_CXX_COMPILER_ID}++_ACCEPTS${flag}")
kropUnsubmitted
Done

Unneeded extra space

krop: Unneeded extra space
68​ check_cxx_compiler_flag(${flag} ${HASFLAG})
69​ if ({${HASFLAG}})
kropUnsubmitted
Done

Unneeded extra spaces

krop: Unneeded extra spaces
70​ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${flag}" PARENT_SCOPE)
71​ endif()
72​ endforeach()
73​ else()
74​ # all flags can be appended at once
75​ string(REPLACE ";" " " FLAGS "${EASCXXFLAGS_FLAGS}")
76​ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${FLAGS}" PARENT_SCOPE)
77​ endif()
78​ endif()
79​endfunction()
80​
81​function (ECM_ADD_C_COMPILER_FLAGS_IF_SUPPORTED)
82​ set(_OPTIONS_ARGS)
83​ set(_ONE_VALUE_ARGS)
84​ set(_MULTI_VALUE_ARGS FLAGS SUPPORTED_IF)
85​
86​ cmake_parse_arguments(EASCFLAGS "${_OPTIONS_ARGS}" "${_ONE_VALUE_ARGS}" "${_MULTI_VALUE_ARGS}" ${ARGN} )
87​ if(NOT EASCFLAGS_FLAGS)
88​ message( FATAL_ERROR "ecm_add_c_compiler_flags_if_supported: 'FLAGS' is a required argument." )
89​ endif()
90​ if (NOT EASCFLAGS_SUPPORTED_IF OR (${EASCFLAGS_SUPPORTED_IF}))
91​ if(NOT EASCFLAGS_SUPPORTED_IF OR (APPLE AND CMAKE_C_COMPILER_ID MATCHES "Clang"))
92​ # one flag at a time:
93​ foreach(flag IN ITEMS ${EASCFLAGS_FLAGS})
94​ set(HASFLAG "${CMAKE_C_COMPILER_ID}_ACCEPTS${flag}")
95​ check_c_compiler_flag(${flag} ${HASFLAG})
kropUnsubmitted
Not Done

EASCXXFLAGS_SUPPORTED_IF

krop: EASCXXFLAGS_SUPPORTED_IF
96​ if ({${HASFLAG}})
97​ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${flag}" PARENT_SCOPE)
kropUnsubmitted
Done

Unneeded extra space

krop: Unneeded extra space
98​ endif()
99​ endforeach()
kropUnsubmitted
Not Done

EASCXXFLAGS_SUPPORTED_IF

krop: EASCXXFLAGS_SUPPORTED_IF
100​ else()
101​ string(REPLACE ";" " " FLAGS "${EASCFLAGS_FLAGS}")
102​ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${FLAGS}" PARENT_SCOPE)
kropUnsubmitted
Done

Unneeded extra space

krop: Unneeded extra space
103​ endif()
104​ endif()
kropUnsubmitted
Not Done

Unneeded extra space

krop: Unneeded extra space
105​endfunction()
106​
kropUnsubmitted
Not Done

EASCFLAGS_SUPPORTED_IF

krop: EASCFLAGS_SUPPORTED_IF
kropUnsubmitted
Not Done

EASCFLAGS_SUPPORTED_IF

krop: EASCFLAGS_SUPPORTED_IF
kropUnsubmitted
Not Done

if(HASFLAG)

you're testing the result, not the string

krop: if(HASFLAG) you're testing the result, not the string
kropUnsubmitted
Not Done

Forget that. The syntax is confusing, please remove this HASFLAG

krop: Forget that. The syntax is confusing, please remove this HASFLAG