Differential D16689 Diff 45553 krusader/Konfigurator/krresulttable.cpp

Changeset View

Standalone View

View Options

krusader/Konfigurator/krresulttable.cpp

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Line(s)
192{ 192​{
193 Archiver* arch = dynamic_cast<Archiver*>(search); 193​ Archiver* arch = dynamic_cast<Archiver*>(search);
194 194​
195 // Name column 195​ // Name column
196 _label = new KUrlLabel(arch->getWebsite(), arch->getSearchName(), this); 196​ _label = new KUrlLabel(arch->getWebsite(), arch->getSearchName(), this);
197 _label->setContentsMargins(5, 5, 5, 5); 197​ _label->setContentsMargins(5, 5, 5, 5);
198 _label->setAlignment(Qt::AlignTop); 198​ _label->setAlignment(Qt::AlignTop);
199 grid->addWidget(_label, _numRows, 0); 199​ grid->addWidget(_label, _numRows, 0);
200 connect(_label, SIGNAL(leftClickedUrl(QString)), 200​ connect(dynamic_cast<KUrlLabel*>(_label), QOverload<const QString &>::of(&KUrlLabel::leftClickedUrl), this, &KrArchiverResultTable::website);
abikaUnsubmitted
Not Done

here, too: better change the type of _label to KUrlLabel

abika: here, too: better change the type of `_label` to `KUrlLabel`
mchabrecekAuthorUnsubmitted
Not Done

_label as QLabel is used for creating more compoments, many of them are Qlabels, so it won't work without bigger refactoring.

So I won't change it

mchabrecek: _label as QLabel is used for creating more compoments, many of them are Qlabels, so it won't…
201 SLOT(website(QString))); ​
202 201​
203 // Found column 202​ // Found column
204 _label = new QLabel(arch->getPath(), this); 203​ _label = new QLabel(arch->getPath(), this);
205 _label->setContentsMargins(5, 5, 5, 5); 204​ _label->setContentsMargins(5, 5, 5, 5);
206 grid->addWidget(_label, _numRows, 1); 205​ grid->addWidget(_label, _numRows, 1);
207 206​
208 // Packing column 207​ // Packing column
209 _label = new QLabel(this); 208​ _label = new QLabel(this);
▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines