Changeset View
Changeset View
Standalone View
Standalone View
src/core/engine.h
Show All 22 Lines | |||||
23 | 23 | | |||
24 | #include <QObject> | 24 | #include <QObject> | ||
25 | #include <QString> | 25 | #include <QString> | ||
26 | #include <QMap> | 26 | #include <QMap> | ||
27 | #include <QSharedPointer> | 27 | #include <QSharedPointer> | ||
28 | 28 | | |||
29 | #include "provider.h" | 29 | #include "provider.h" | ||
30 | #include "entryinternal.h" | 30 | #include "entryinternal.h" | ||
31 | #include "errorcode.h" | ||||
31 | 32 | | |||
32 | #include "knewstuffcore_export.h" | 33 | #include "knewstuffcore_export.h" | ||
33 | 34 | | |||
34 | class QTimer; | 35 | class QTimer; | ||
35 | class KJob; | 36 | class KJob; | ||
36 | class EnginePrivate; | 37 | class EnginePrivate; | ||
37 | 38 | | |||
38 | namespace Attica | 39 | namespace Attica | ||
▲ Show 20 Lines • Show All 373 Lines • ▼ Show 20 Line(s) | 397 | Q_SIGNALS: | |||
412 | void signalPreviewFailed(); | 413 | void signalPreviewFailed(); | ||
413 | 414 | | |||
414 | void signalEntryUploadFinished(); | 415 | void signalEntryUploadFinished(); | ||
415 | void signalEntryUploadFailed(); | 416 | void signalEntryUploadFailed(); | ||
416 | 417 | | |||
417 | void signalDownloadDialogDone(KNSCore::EntryInternal::List); | 418 | void signalDownloadDialogDone(KNSCore::EntryInternal::List); | ||
418 | void jobStarted(KJob *, const QString &); | 419 | void jobStarted(KJob *, const QString &); | ||
419 | 420 | | |||
420 | void signalError(const QString &); | 421 | QT_DEPRECATED void signalError(const QString &); | ||
421 | void signalBusy(const QString &); | 422 | void signalBusy(const QString &); | ||
422 | void signalIdle(const QString &); | 423 | void signalIdle(const QString &); | ||
424 | /** | ||||
425 | * Fires in the case of any critical or serious errors, such as network or API problems. | ||||
426 | * @param errorCode Represents the specific type of error which has occurred | ||||
427 | * @param message A human-readable message which can be shown to the end user | ||||
428 | * @param metadata Any additional data which might be hepful to further work out the details of the error (see KNSCore::EntryInternal::ErrorCode for the metadata details) | ||||
429 | * @see KNSCore::EntryInternal::ErrorCode | ||||
430 | */ | ||||
apol: I would include the error message here and deprecate `signalError`. Otherwise it's going to be… | |||||
Quite a good point, yes - i've done a bit of jiggling around, new patch incoming leinir: Quite a good point, yes - i've done a bit of jiggling around, new patch incoming | |||||
431 | void signalErrorCode(const KNSCore::ErrorCode &errorCode, const QString &message, const QVariant &metadata); | ||||
423 | 432 | | |||
424 | void signalCategoriesMetadataLoded(const QList<Provider::CategoryMetadata> &categories); | 433 | void signalCategoriesMetadataLoded(const QList<Provider::CategoryMetadata> &categories); | ||
425 | 434 | | |||
426 | private Q_SLOTS: | 435 | private Q_SLOTS: | ||
427 | // the .knsrc file was loaded | 436 | // the .knsrc file was loaded | ||
428 | void slotProviderFileLoaded(const QDomDocument &doc); | 437 | void slotProviderFileLoaded(const QDomDocument &doc); | ||
429 | // instead of getting providers from knsrc, use what was configured in ocs systemsettings | 438 | // instead of getting providers from knsrc, use what was configured in ocs systemsettings | ||
430 | void atticaProviderLoaded(const Attica::Provider &provider); | 439 | void atticaProviderLoaded(const Attica::Provider &provider); | ||
▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines |
I would include the error message here and deprecate signalError. Otherwise it's going to be a mess matching both signals.