Differential D16767 Diff 45280 src/panels/places/placespanel.h

Changeset View

Standalone View

View Options

src/panels/places/placespanel.h

Show All 36 Lines
37class PlacesPanel : public Panel 37​class PlacesPanel : public Panel
38{ 38​{
39 Q_OBJECT 39​ Q_OBJECT
40 40​
41public: 41​public:
42 explicit PlacesPanel(QWidget* parent); 42​ explicit PlacesPanel(QWidget* parent);
43 ~PlacesPanel() override; 43​ ~PlacesPanel() override;
44 void proceedWithTearDown(); 44​ void proceedWithTearDown();
45 45​
elvisangelaccioUnsubmitted
Done

Please create the action/checkbox in DolphinMainWindow and just add a public slot here in the panel.

elvisangelaccio: Please create the action/checkbox in `DolphinMainWindow` and just add a public slot here in the…
46signals: 46​signals:
47 void placeActivated(const QUrl& url); 47​ void placeActivated(const QUrl& url);
48 void placeMiddleClicked(const QUrl& url); 48​ void placeMiddleClicked(const QUrl& url);
49 void errorMessage(const QString& error); 49​ void errorMessage(const QString& error);
50 void storageTearDownRequested(const QString& mountPath); 50​ void storageTearDownRequested(const QString& mountPath);
51 void storageTearDownExternallyRequested(const QString& mountPath); 51​ void storageTearDownExternallyRequested(const QString& mountPath);
52​ void showHiddenEntriesChanged(bool shown);
53​ void hiddenListChanged(bool empty);
elvisangelaccioUnsubmitted
Done

This signal is a bit confusing. I'd prefer using:

void hiddenCountChanged(int hiddenCount);

since it's how you are actually using it.

elvisangelaccio: This signal is a bit confusing. I'd prefer using: void hiddenCountChanged(int hiddenCount)…
52 54​
53protected: 55​protected:
54 bool urlChanged() override; 56​ bool urlChanged() override;
55 void showEvent(QShowEvent* event) override; 57​ void showEvent(QShowEvent* event) override;
56 58​
57public slots: 59​public slots:
58 void readSettings() override; 60​ void readSettings() override;
61​ void showHiddenEntries(bool shown);
elvisangelaccioUnsubmitted
Done

The slotXXX prefix is usually used for private slots. We can just call it showHiddenEntries().

elvisangelaccio: The `slotXXX` prefix is usually used for private slots. We can just call it `showHiddenEntries…
59 62​
60private slots: 63​private slots:
61 void slotItemActivated(int index); 64​ void slotItemActivated(int index);
62 void slotItemMiddleClicked(int index); 65​ void slotItemMiddleClicked(int index);
63 void slotItemContextMenuRequested(int index, const QPointF& pos); 66​ void slotItemContextMenuRequested(int index, const QPointF& pos);
64 void slotViewContextMenuRequested(const QPointF& pos); 67​ void slotViewContextMenuRequested(const QPointF& pos);
65 void slotItemDropEvent(int index, QGraphicsSceneDragDropEvent* event); 68​ void slotItemDropEvent(int index, QGraphicsSceneDragDropEvent* event);
66 void slotItemDropEventStorageSetupDone(int index, bool success); 69​ void slotItemDropEventStorageSetupDone(int index, bool success);
Show All 32 Lines