Differential D15695 Diff 44910 effects/snaphelper/snaphelper.h

Changeset View

Standalone View

View Options

effects/snaphelper/snaphelper.h

1/******************************************************************** 1​/********************************************************************
2 KWin - the KDE window manager 2​ KWin - the KDE window manager
3 This file is part of the KDE project. 3​ This file is part of the KDE project.
4 4​
5Copyright (C) 2009 Lucas Murray <lmurray@undefinedfire.com> 5​Copyright (C) 2009 Lucas Murray <lmurray@undefinedfire.com>
6​Copyright (C) 2018 Vlad Zagorodniy <vladzzag@gmail.com>
6 7​
7This program is free software; you can redistribute it and/or modify 8​This program is free software; you can redistribute it and/or modify
8it under the terms of the GNU General Public License as published by 9​it under the terms of the GNU General Public License as published by
9the Free Software Foundation; either version 2 of the License, or 10​the Free Software Foundation; either version 2 of the License, or
10(at your option) any later version. 11​(at your option) any later version.
11 12​
12This program is distributed in the hope that it will be useful, 13​This program is distributed in the hope that it will be useful,
13but WITHOUT ANY WARRANTY; without even the implied warranty of 14​but WITHOUT ANY WARRANTY; without even the implied warranty of
14MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 15​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15GNU General Public License for more details. 16​GNU General Public License for more details.
16 17​
17You should have received a copy of the GNU General Public License 18​You should have received a copy of the GNU General Public License
18along with this program. If not, see <http://www.gnu.org/licenses/>. 19​along with this program. If not, see <http://www.gnu.org/licenses/>.
19*********************************************************************/ 20​*********************************************************************/
20 21​
21#ifndef KWIN_SNAPHELPER_H 22​#ifndef KWIN_SNAPHELPER_H
22#define KWIN_SNAPHELPER_H 23​#define KWIN_SNAPHELPER_H
23 24​
24#include <kwineffects.h> 25​#include <kwineffects.h>
25#include <QTimeLine> ​
26 26​
27namespace KWin 27​namespace KWin
28{ 28​{
29 29​
30class SnapHelperEffect 30​class SnapHelperEffect : public Effect
31 : public Effect ​
32{ 31​{
33 Q_OBJECT 32​ Q_OBJECT
33​
34public: 34​public:
35 SnapHelperEffect(); 35​ SnapHelperEffect();
36 ~SnapHelperEffect(); 36​ ~SnapHelperEffect() override;
37 37​
38 virtual void reconfigure(ReconfigureFlags); 38​ void reconfigure(ReconfigureFlags flags) override;
39 39​
40 virtual void prePaintScreen(ScreenPrePaintData &data, int time); 40​ void prePaintScreen(ScreenPrePaintData &data, int time) override;
41 void paintScreen(int mask, QRegion region, ScreenPaintData &data) override; 41​ void paintScreen(int mask, QRegion region, ScreenPaintData &data) override;
42 virtual bool isActive() const; 42​ void postPaintScreen() override;
43​
44​ bool isActive() const override;
43 45​
44public Q_SLOTS: 46​private Q_SLOTS:
45 void slotWindowClosed(KWin::EffectWindow *w); 47​ void slotWindowClosed(EffectWindow *w);
46 void slotWindowStartUserMovedResized(KWin::EffectWindow *w); 48​ void slotWindowStartUserMovedResized(EffectWindow *w);
47 void slotWindowFinishUserMovedResized(KWin::EffectWindow *w); 49​ void slotWindowFinishUserMovedResized(EffectWindow *w);
48 void slotWindowResized(KWin::EffectWindow *w, const QRect &r); 50​ void slotWindowGeometryShapeChanged(EffectWindow *w, const QRect &old);
49 51​
50private: 52​private:
51 bool m_active; 53​ QRect m_geometry;
romanggUnsubmitted
Not Done

Second private. Remove.

romangg: Second private. Remove.
52 EffectWindow* m_window; 54​ EffectWindow *m_window = nullptr;
53 QTimeLine m_timeline; 55​
54 //GC m_gc; 56​ struct Animation {
57​ bool active = false;
58​ TimeLine timeLine;
59​ };
60​
61​ Animation m_animation;
romanggUnsubmitted
Not Done

Why is it a member variable? Since it does not get changed, better as a static in the cpp file. Same for m_lineColor below.

romangg: Why is it a member variable? Since it does not get changed, better as a static in the cpp file.
55}; 62​};
56 63​
57} // namespace 64​} // namespace KWin
58 65​
59#endif 66​#endif