Differential D8709 Diff 44813 kdevplatform/vcs/widgets/vcsannotationitemdelegate.cpp

Changeset View

Standalone View

View Options

kdevplatform/vcs/widgets/vcsannotationitemdelegate.cpp

  • This file was added.
1​/* This file is part of KDevelop
2​ *
3​ * Copyright 2017-2018 Friedrich W. H. Kossebau <kossebau@kde.org>
4​ *
5​ * This program is free software; you can redistribute it and/or
6​ * modify it under the terms of the GNU General Public License
7​ * as published by the Free Software Foundation; either version 2
8​ * of the License, or (at your option) any later version.
9​ *
10​ * This program is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13​ * GNU General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU General Public License
16​ * along with this program; if not, write to the Free Software
17​ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
18​ * 02110-1301, USA.
19​ */
20​
21​#include "vcsannotationitemdelegate.h"
22​
23​#include <models/vcsannotationmodel.h>
24​#include <vcsannotation.h>
25​#include <debug.h>
26​
27​#include <KTextEditor/AnnotationInterface>
28​#include <KTextEditor/View>
29​#include <KTextEditor/ConfigInterface>
30​#include <KTextEditor/Attribute>
31​#include <KLocalizedString>
32​
33​#include <QHelpEvent>
34​#include <QPainter>
35​#include <QAction>
36​#include <QMenu>
37​#include <QToolTip>
38​#include <QFontMetricsF>
39​#include <QDate>
40​#include <QStyle>
41​#include <QApplication>
42​
43​#include <cmath>
44​
45​using namespace KDevelop;
46​
47​VcsAnnotationItemDelegate::VcsAnnotationItemDelegate(KTextEditor::View* view, KTextEditor::AnnotationModel* model,
48​ QObject* parent)
49​ : KTextEditor::AbstractAnnotationItemDelegate(parent)
50​ , m_model(model)
51​{
52​ // dump background brushes on schema change
53​ Q_ASSERT(qobject_cast<KTextEditor::ConfigInterface*>(view));
54​ connect(view, SIGNAL(configChanged()), this, SLOT(resetBackgrounds()));
55​
56​ view->installEventFilter(this);
57​}
58​
59​VcsAnnotationItemDelegate::~VcsAnnotationItemDelegate() = default;
60​
61​static QString ageOfDate(const QDate& date)
62​{
63​ const auto now = QDate::currentDate();
64​ int ageInYears = now.year() - date.year();
65​ if (now < date.addYears(ageInYears)) {
66​ --ageInYears;
67​ }
68​ if (ageInYears > 0) {
69​ return i18ncp("age", "%1 year", "%1 years", ageInYears);
70​ }
71​ int ageInMonths = now.month() - date.month();
72​ if (ageInMonths < 0) {
73​ ageInMonths += 12;
74​ }
75​ if (ageInMonths > 0) {
76​ return i18ncp("age", "%1 month", "%1 months", ageInMonths);
77​ }
78​ const int ageInDays = date.daysTo(now);
79​ if (ageInDays > 0) {
80​ return i18ncp("age", "%1 day", "%1 days", ageInDays);
81​ }
82​ return i18n("Today");
83​}
84​
85​void VcsAnnotationItemDelegate::doMessageLineLayout(const KTextEditor::StyleOptionAnnotationItem& option,
86​ QRect* messageRect, QRect* ageRect) const
87​{
88​ Q_ASSERT(messageRect && messageRect->isValid());
89​ Q_ASSERT(ageRect);
90​
91​ const QWidget* const widget = option.view;
92​ QStyle* const style = widget ? widget->style() : QApplication::style();
93​ const bool hasAge = ageRect->isValid();
94​ // "+ 1" as used in QItemDelegate
95​ const int textMargin = style->pixelMetric(QStyle::PM_FocusFrameHMargin, nullptr, widget) + 1;
96​ const int ageMargin = hasAge ? textMargin : 0;
97​
98​ const int x = option.rect.left();
99​ const int y = option.rect.top();
100​ const int w = option.rect.width();
101​ const int h = option.rect.height();
102​
103​ // add margins for fixed elements
104​ QSize ageSize(0, 0); // ageRect could be invalid, so use separate object for calculation
105​ if (hasAge) {
106​ ageSize = ageRect->size();
107​ ageSize.rwidth() += 2 * ageMargin;
108​ }
109​
110​ // distribute space among layout items
111​ QRect message;
112​ QRect age;
113​ if (option.direction == Qt::LeftToRight) {
114​ message.setRect(x, y, w - ageSize.width(), h);
115​ age.setRect(message.right() + 1, y, ageSize.width(), h);
116​ } else {
117​ age.setRect(x, y, ageSize.width(), h);
118​ message.setRect(age.right() + 1, y, w - ageSize.width(), h);
119​ }
120​ // remove margins here, so renderMessageAndAge does not have to
121​ message.adjust(textMargin, 0, -textMargin, 0);
122​ age.adjust(ageMargin, 0, -ageMargin, 0);
123​
124​ // return result
125​ *ageRect = age;
126​ *messageRect = QStyle::alignedRect(option.direction, Qt::AlignLeading,
127​ messageRect->size().boundedTo(message.size()), message);
128​}
129​
130​void VcsAnnotationItemDelegate::doAuthorLineLayout(const KTextEditor::StyleOptionAnnotationItem& option,
131​ QRect* authorRect) const
132​{
133​ Q_ASSERT(authorRect);
134​
135​ // if invalid, nothing to be done, keep as is
136​ if (!authorRect->isValid()) {
137​ return;
138​ }
139​
140​ const QWidget* const widget = option.view;
141​ QStyle* const style = widget ? widget->style() : QApplication::style();
142​ // "+ 1" as used in QItemDelegate
143​ const int authorMargin = style->pixelMetric(QStyle::PM_FocusFrameHMargin, nullptr, widget) + 1;
144​
145​ QRect author = option.rect;
146​ // remove margins here, so renderAuthor does not have to
147​ author.adjust(authorMargin, 0, -authorMargin, 0);
148​
149​ // return result
150​ *authorRect = QStyle::alignedRect(option.direction, Qt::AlignLeading,
151​ authorRect->size().boundedTo(author.size()), author);
152​}
153​
154​void VcsAnnotationItemDelegate::renderBackground(QPainter* painter,
155​ const KTextEditor::StyleOptionAnnotationItem& option,
156​ const VcsAnnotationLine& annotationLine) const
157​{
158​ Q_UNUSED(option);
159​
160​ const auto revision = annotationLine.revision();
161​ auto brushIt = m_backgrounds.find(revision);
162​ if (brushIt == m_backgrounds.end()) {
163​ KTextEditor::Attribute::Ptr normalStyle = option.view->defaultStyleAttribute(KTextEditor::dsNormal);
164​ const auto background = (normalStyle->hasProperty(QTextFormat::BackgroundBrush)) ? normalStyle->background().color() : QColor(Qt::white);
165​ const int background_y = background.red()*0.299 + 0.587*background.green()
166​ + 0.114*background.blue();
167​ // get random, but reproducable 8-bit values from last two bytes of the revision hash
168​ const uint revisionHash = qHash(revision);
169​ const int u = static_cast<int>((0xFF & revisionHash));
170​ const int v = static_cast<int>((0xFF00 & revisionHash) >> 8);
171​ const int r = qRound(qMin(255.0, qMax(0.0, background_y + 1.402*(v-128))));
172​ const int g = qRound(qMin(255.0, qMax(0.0, background_y - 0.344*(u-128) - 0.714*(v-128))));
173​ const int b = qRound(qMin(255.0, qMax(0.0, background_y + 1.772*(u-128))));
174​ brushIt = m_backgrounds.insert(revision, QBrush(QColor(r, g, b)));
175​ }
176​
177​ painter->fillRect(option.rect, brushIt.value());
178​}
179​
180​void VcsAnnotationItemDelegate::renderMessageAndAge(QPainter* painter,
181​ const KTextEditor::StyleOptionAnnotationItem& option,
182​ const QRect& messageRect, const QString& messageText,
183​ const QRect& ageRect, const QString& ageText) const
184​{
185​ Q_UNUSED(option);
186​
187​ painter->save();
188​
189​ KTextEditor::Attribute::Ptr normalStyle = option.view->defaultStyleAttribute(KTextEditor::dsNormal);
190​ painter->setPen(normalStyle->foreground().color());
191​ painter->drawText(messageRect, Qt::AlignLeading | Qt::AlignVCenter,
192​ painter->fontMetrics().elidedText(messageText, Qt::ElideRight, messageRect.width()));
193​
194​ // TODO: defaultStyleAttribute only returns relyably for dsNormal, so what to do for a comment-like color?
195​ KTextEditor::Attribute::Ptr commentStyle = option.view->defaultStyleAttribute(KTextEditor::dsNormal);
196​ painter->setPen(commentStyle->foreground().color());
197​ painter->drawText(ageRect, Qt::AlignTrailing | Qt::AlignVCenter, ageText);
198​
199​ painter->restore();
200​}
201​
202​void VcsAnnotationItemDelegate::renderAuthor(QPainter* painter,
203​ const KTextEditor::StyleOptionAnnotationItem& option,
204​ const QRect& authorRect, const QString& authorText) const
205​{
206​ Q_UNUSED(option);
207​
208​ painter->save();
209​
210​ // TODO: defaultStyleAttribute only returns relyably for dsNormal, so what to do for a comment-like color?
211​ KTextEditor::Attribute::Ptr commentStyle = option.view->defaultStyleAttribute(KTextEditor::dsNormal);
212​ painter->setPen(commentStyle->foreground().color());
213​ painter->drawText(authorRect, Qt::AlignLeading | Qt::AlignVCenter,
214​ painter->fontMetrics().elidedText(authorText, Qt::ElideRight, authorRect.width()));
215​
216​ painter->restore();
217​}
218​
219​void VcsAnnotationItemDelegate::renderHighlight(QPainter* painter,
220​ const KTextEditor::StyleOptionAnnotationItem& option) const
221​{
222​ // Draw a border around all adjacent entries that have the same text as the currently hovered one
223​ if ((option.state & QStyle::State_MouseOver) &&
224​ (option.annotationItemGroupingPosition & KTextEditor::StyleOptionAnnotationItem::InGroup)) {
225​ KTextEditor::Attribute::Ptr style = option.view->defaultStyleAttribute(KTextEditor::dsNormal);
226​ painter->setPen(style->foreground().color());
227​ // Use floating point coordinates to support scaled rendering
228​ QRectF rect(option.rect);
229​ rect.adjust(0.5, 0.5, -0.5, -0.5);
230​ // draw left and right highlight borders
231​ painter->drawLine(rect.topLeft(), rect.bottomLeft());
232​ painter->drawLine(rect.topRight(), rect.bottomRight());
233​
234​ if ((option.annotationItemGroupingPosition & KTextEditor::StyleOptionAnnotationItem::GroupBegin) &&
235​ (option.wrappedLine == 0)) {
236​ painter->drawLine(rect.topLeft(), rect.topRight());
237​ }
238​
239​ if ((option.annotationItemGroupingPosition & KTextEditor::StyleOptionAnnotationItem::GroupEnd) &&
240​ (option.wrappedLine == (option.wrappedLineCount-1))) {
241​ painter->drawLine(rect.bottomLeft(), rect.bottomRight());
242​ }
243​ }
244​}
245​
246​void VcsAnnotationItemDelegate::paint(QPainter* painter, const KTextEditor::StyleOptionAnnotationItem& option,
247​ KTextEditor::AnnotationModel* model, int line) const
248​{
249​ Q_ASSERT(painter);
250​ // we cannot use custom roles and data() API (cmp. VcsAnnotationModel dox), so accessing custom API instead
251​ VcsAnnotationModel* vcsModel = qobject_cast<VcsAnnotationModel*>(model);
252​ Q_ASSERT(vcsModel);
253​ if (!painter || !vcsModel) {
254​ return;
255​ }
256​ // test of line just for sake of completeness skipped here
257​
258​ // Fetch data from the model
259​ const VcsAnnotationLine annotationLine = vcsModel->annotationLine(line);
260​
261​ if (annotationLine.revision().revisionType() == VcsRevision::Invalid) {
262​ return;
263​ }
264​
265​ // prepare
266​ painter->save();
267​
268​ renderBackground(painter, option, annotationLine);
269​
270​ // We use the normal UI font here, which usually is a proportimal one,
271​ // so more text fits into the available space.
272​ // Though we do this at the cost of not adapting to any scaled content font size,
273​ // as there is no zooming state info available, so we cannot adapt.
274​ // Tooltip font also is not scaled, and annotations could be considered to fall into
275​ // that category, so might be fine.
276​ painter->setFont(option.view->font());
277​
278​ if (option.visibleWrappedLineInGroup == 0) {
279​ QRect ageRect;
280​ QString ageText;
281​ const auto date = annotationLine.date();
282​ if (date.isValid()) {
283​ ageText = ageOfDate(date.date());
284​ ageRect = QRect(QPoint(0, 0),
285​ QSize(option.fontMetrics.width(ageText), option.rect.height()));
286​ }
287​ const auto messageText = annotationLine.commitMessage();
288​ auto messageRect = QRect(QPoint(0, 0),
289​ QSize(option.fontMetrics.width(messageText), option.rect.height()));
290​
291​ doMessageLineLayout(option, &messageRect, &ageRect);
292​
293​ renderMessageAndAge(painter, option, messageRect, messageText, ageRect, ageText);
294​ } else if (option.visibleWrappedLineInGroup == 1) {
295​ const auto author = annotationLine.author();
296​ if (!author.isEmpty()) {
297​ const auto authorText = i18nc("By: commit author", "By: %1", author);
298​ auto authorRect = QRect(QPoint(0, 0),
299​ QSize(option.fontMetrics.width(authorText), option.rect.height()));
300​
301​ doAuthorLineLayout(option, &authorRect);
302​
303​ renderAuthor(painter, option, authorRect, authorText);
304​ }
305​ }
306​
307​ renderHighlight(painter, option);
308​
309​ // done
310​ painter->restore();
311​}
312​
313​bool VcsAnnotationItemDelegate::helpEvent(QHelpEvent* event, KTextEditor::View* view,
314​ const KTextEditor::StyleOptionAnnotationItem& option,
315​ KTextEditor::AnnotationModel* model, int line)
316​{
317​ Q_UNUSED(option);
318​ if (!model || event->type() != QEvent::ToolTip) {
319​ return false;
320​ }
321​
322​ const QString annotationGroupId = model->data(line, (Qt::ItemDataRole)KTextEditor::AnnotationModel::GroupIdentifierRole).toString();
323​
324​ const QVariant data = model->data(line, Qt::ToolTipRole);
325​ if (!data.isValid()) {
326​ return false;
327​ }
328​
329​ const QString toolTipText = data.toString();
330​ if (toolTipText.isEmpty()) {
331​ return false;
332​ }
333​
334​ QToolTip::showText(event->globalPos(), toolTipText, view, option.rect);
335​
336​ return true;
337​}
338​
339​void VcsAnnotationItemDelegate::hideTooltip(KTextEditor::View *view)
340​{
341​ Q_UNUSED(view);
342​ QToolTip::hideText();
343​}
344​
345​QSize VcsAnnotationItemDelegate::sizeHint(const KTextEditor::StyleOptionAnnotationItem& option,
346​ KTextEditor::AnnotationModel* model, int line) const
347​{
348​ Q_UNUSED(line);
349​ Q_ASSERT(model);
350​ if (!model) {
351​ return QSize(0, 0);
352​ }
353​
354​ // Ideally the user could configure the width of the annotations, best interactively.
355​ // Until this is possible, the sizehint is: roughly 40 chars, but maximal 25 % of the view
356​ // See eventFilter for making sure we adapt the max 25 % to a changed width.
357​
358​ const QFontMetricsF& fm(option.fontMetrics);
359​ // if only averageCharWidth would yield sane values,
360​ // multiply by 40 in average seemed okayish at least with english, showing enough of message
361​ m_lastCharBasedWidthHint = ceil(40 * fm.averageCharWidth());
362​ m_lastViewBasedWidthHint = widthHintFromViewWidth(option.view->width());
363​ return QSize(qMin(m_lastCharBasedWidthHint, m_lastViewBasedWidthHint), fm.height());
364​}
365​
366​bool VcsAnnotationItemDelegate::eventFilter(QObject* object, QEvent* event)
367​{
368​ if (event->type() == QEvent::Resize) {
369​ auto resizeEvent = static_cast<QResizeEvent*>(event);
370​ const int viewBasedWidthHint = widthHintFromViewWidth(resizeEvent->size().width());
371​ if ((viewBasedWidthHint < m_lastCharBasedWidthHint) &&
372​ (viewBasedWidthHint != m_lastViewBasedWidthHint)) {
373​ // emit for first line only, assuming uniformAnnotationItemSizes is set to true
374​ emit sizeHintChanged(m_model, 0);
375​ }
376​ }
377​
378​ return KTextEditor::AbstractAnnotationItemDelegate::eventFilter(object, event);
379​}
380​
381​void VcsAnnotationItemDelegate::resetBackgrounds()
382​{
383​ m_backgrounds.clear();
384​}
385​
386​int VcsAnnotationItemDelegate::widthHintFromViewWidth(int viewWidth) const
387​{
388​ return viewWidth * m_maxWidthViewPercent / 100;
389​}
croickUnsubmitted
Not Done

On a small screen, that's taking a little too much space in my opinion. I preferred 20%.

What would be necessary to make it resizable?

croick: On a small screen, that's taking a little too much space in my opinion. I preferred 20%. What…
kossebauAuthorUnsubmitted
Not Done

Myself I would actually prefer 30 % :) Guess that should be a value users want to customize in the general kdevelop settings. Will extend the patch to propose to add that.

For making it interactively resizeable, that will need some extension of KateView in KTextEditor. Have not yet thought further about this and how it should be as user experience and how it could be implemented

kossebau: Myself I would actually prefer 30 % :) Guess that should be a value users want to customize in…