Differential D16484 Diff 44770 plugins/scratchpad/CMakeLists.txt

Changeset View

Standalone View

1		add_definitions(-DTRANSLATION_DOMAIN=\"kdevscratchpad\")
2		set(scratchpad_SRCS
3		scratchpad.cpp
	brauchUnsubmitted Not Done In general I would personally omit this variable step in modern CMake code, there is no reason for it. Just list the sources directly in the command adding the target. If you need them elsewhere, they are easily retrieved with get_target_property(). brauch: In general I would personally omit this variable step in modern CMake code, there is no reason…
	amhnduAuthorUnsubmitted Not Done I've removed the `scratchpad_UI` variable but `scratchpad_SRCS` is used in a few commands, could that also be removed ? amhndu: I've removed the `scratchpad_UI` variable but `scratchpad_SRCS` is used in a few commands…
4		scratchpadview.cpp
5		scratchpadjob.cpp
6		)
7
8		ki18n_wrap_ui(scratchpad_SRCS scratchpadview.ui)
9
10		declare_qt_logging_category(scratchpad_SRCS
11		TYPE PLUGIN
12		IDENTIFIER PLUGIN_SCRATCHPAD
13		CATEGORY_BASENAME "scratchpad"
14		)
15
16		kdevplatform_add_plugin(kdevscratchpad
17		JSON scratchpad.json
18		SOURCES ${scratchpad_SRCS}
19		)
20
21		target_link_libraries(kdevscratchpad
22		KDev::Interfaces
23		KDev::Util
24		KDev::OutputView
25		)