Changeset View
Changeset View
Standalone View
Standalone View
deleted.cpp
Show First 20 Lines • Show All 88 Lines • ▼ Show 20 Line(s) | 87 | { | |||
---|---|---|---|---|---|
89 | delete this; | 89 | delete this; | ||
90 | } | 90 | } | ||
91 | 91 | | |||
92 | void Deleted::copyToDeleted(Toplevel* c) | 92 | void Deleted::copyToDeleted(Toplevel* c) | ||
93 | { | 93 | { | ||
94 | assert(dynamic_cast< Deleted* >(c) == NULL); | 94 | assert(dynamic_cast< Deleted* >(c) == NULL); | ||
95 | Toplevel::copyToDeleted(c); | 95 | Toplevel::copyToDeleted(c); | ||
96 | desk = c->desktop(); | 96 | desk = c->desktop(); | ||
97 | m_desktops = c->desktops(); | ||||
97 | activityList = c->activities(); | 98 | activityList = c->activities(); | ||
98 | contentsRect = QRect(c->clientPos(), c->clientSize()); | 99 | contentsRect = QRect(c->clientPos(), c->clientSize()); | ||
99 | m_contentPos = c->clientContentPos(); | 100 | m_contentPos = c->clientContentPos(); | ||
100 | transparent_rect = c->transparentRect(); | 101 | transparent_rect = c->transparentRect(); | ||
101 | m_layer = c->layer(); | 102 | m_layer = c->layer(); | ||
102 | m_frame = c->frameId(); | 103 | m_frame = c->frameId(); | ||
103 | m_opacity = c->opacity(); | 104 | m_opacity = c->opacity(); | ||
104 | m_type = c->windowType(true); | 105 | m_type = c->windowType(true); | ||
▲ Show 20 Lines • Show All 67 Lines • ▼ Show 20 Line(s) | 172 | { | |||
172 | return desk; | 173 | return desk; | ||
173 | } | 174 | } | ||
174 | 175 | | |||
175 | QStringList Deleted::activities() const | 176 | QStringList Deleted::activities() const | ||
176 | { | 177 | { | ||
177 | return activityList; | 178 | return activityList; | ||
178 | } | 179 | } | ||
179 | 180 | | |||
181 | QList<VirtualDesktop *> Deleted::desktops() const | ||||
182 | { | ||||
183 | return m_desktops; | ||||
zzagUnsubmitted Not Done zzag: ```lang=cpp
return {};
``` | |||||
Why aren't we copying and returning the full list? If a window is on desktop 1 and 2 and we close the window we still want it to animate away on whichever desktop the user is on. See void Deleted::copyToDeleted(Toplevel* c) davidedmundson: Why aren't we copying and returning the full list?
If a window is on desktop 1 and 2 and we… | |||||
184 | } | ||||
185 | | ||||
180 | QPoint Deleted::clientPos() const | 186 | QPoint Deleted::clientPos() const | ||
181 | { | 187 | { | ||
182 | return contentsRect.topLeft(); | 188 | return contentsRect.topLeft(); | ||
183 | } | 189 | } | ||
184 | 190 | | |||
185 | QSize Deleted::clientSize() const | 191 | QSize Deleted::clientSize() const | ||
186 | { | 192 | { | ||
187 | return contentsRect.size(); | 193 | return contentsRect.size(); | ||
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines |