Differential D15355 Diff 44482 mainWindow/kpMainWindow_File.cpp

Changeset View

Standalone View

View Options

mainWindow/kpMainWindow_File.cpp

Context not available.
30#include "kpMainWindow.h" 30​#include "kpMainWindow.h"
31#include "kpMainWindowPrivate.h" 31​#include "kpMainWindowPrivate.h"
32 32​
33#include <qaction.h> 33​#include <QAction>
34#include <qdatastream.h> 34​#include <QApplication>
35​#include <QCheckBox>
36​#include <QDataStream>
35#include <QDesktopWidget> 37​#include <QDesktopWidget>
36#include <QDialog> 38​#include <QDialog>
37#include <QDialogButtonBox> 39​#include <QDialogButtonBox>
38#include <QFileDialog> 40​#include <QFileDialog>
39#include <qpainter.h> ​
40#include <qpixmap.h> ​
41#include <qsize.h> ​
42#include <QPrinter> ​
43#include <QPrintDialog> ​
44#include <QScreen> ​
45#include <QApplication> ​
46#include <QTimer> ​
47#include <QLabel> ​
48#include <QCheckBox> ​
49#include <QVBoxLayout> ​
50#include <QImageReader> 41​#include <QImageReader>
51#include <QImageWriter> 42​#include <QImageWriter>
43​#include <QLabel>
52#include <QMimeDatabase> 44​#include <QMimeDatabase>
45​#include <QPainter>
46​#include <QPixmap>
47​#include <QPrintDialog>
53#include <QPrintPreviewDialog> 48​#include <QPrintPreviewDialog>
49​#include <QPrinter>
50​#include <QScreen>
51​#include <QSize>
52​#include <QTimer>
53​#include <QVBoxLayout>
54 54​
55#include <kactioncollection.h> 55​#include <kactioncollection.h>
56#include <KSharedConfig> 56​#include <KSharedConfig>
57#include <kconfiggroup.h> 57​#include <kconfiggroup.h>
58​#include <KFileWidget>
58#include <KPluralHandlingSpinBox> 59​#include <KPluralHandlingSpinBox>
59#include <kfiledialog.h> // kdelibs4support 60​#include <KRecentDirs>
60#include <kiconloader.h> 61​#include <kiconloader.h>
61#include <kio/netaccess.h> // kdelibs4support 62​#include <kio/netaccess.h> // kdelibs4support
62#include <kmessagebox.h> 63​#include <kmessagebox.h>
Context not available.
73#include "document/kpDocument.h" 74​#include "document/kpDocument.h"
74#include "commands/imagelib/kpDocumentMetaInfoCommand.h" 75​#include "commands/imagelib/kpDocumentMetaInfoCommand.h"
75#include "dialogs/imagelib/kpDocumentMetaInfoDialog.h" 76​#include "dialogs/imagelib/kpDocumentMetaInfoDialog.h"
76#include "widgets/kpDocumentSaveOptionsWidget.h" 77​#include "dialogs/kpDocumentSaveOptionsDialog.h"
77#include "pixmapfx/kpPixmapFX.h" 78​#include "pixmapfx/kpPixmapFX.h"
78#include "widgets/kpPrintDialogPage.h" 79​#include "widgets/kpPrintDialogPage.h"
79#include "views/kpView.h" 80​#include "views/kpView.h"
Context not available.
735//--------------------------------------------------------------------- 736​//---------------------------------------------------------------------
736 737​
737// private slot 738​// private slot
738bool kpMainWindow::save (bool localOnly) 739​bool kpMainWindow::save ()
739{ 740​{
740 if (d->document->url ().isEmpty () || 741​ if (d->document->url ().isEmpty () ||
741 !QImageWriter::supportedMimeTypes() 742​ !QImageWriter::supportedMimeTypes()
Context not available.
744 // from file so it has been set initially to an invalid value. 745​ // from file so it has been set initially to an invalid value.
745 (d->document->saveOptions ()->mimeTypeHasConfigurableQuality () && 746​ (d->document->saveOptions ()->mimeTypeHasConfigurableQuality () &&
746 d->document->saveOptions ()->qualityIsInvalid ()) || 747​ d->document->saveOptions ()->qualityIsInvalid ()) ||
747 (localOnly && !d->document->url ().isLocalFile ())) 748​ !d->document->url ().isLocalFile ())
748 { 749​ {
749 return saveAs (localOnly); 750​ return saveAs ();
750 } 751​ }
751 else 752​ else
752 { 753​ {
Context not available.
780 const kpDocumentSaveOptions &startSaveOptions, 781​ const kpDocumentSaveOptions &startSaveOptions,
781 const kpDocumentMetaInfo &docMetaInfo, 782​ const kpDocumentMetaInfo &docMetaInfo,
782 const QString &forcedSaveOptionsGroup, 783​ const QString &forcedSaveOptionsGroup,
783 bool localOnly, ​
784 kpDocumentSaveOptions *chosenSaveOptions, 784​ kpDocumentSaveOptions *chosenSaveOptions,
785 bool isSavingForFirstTime, 785​ bool isSavingForFirstTime,
786 bool *allowOverwritePrompt, 786​ bool *allowOverwritePrompt,
Context not available.
881 fdSaveOptions.printDebug ("\tcorrected saveOptions passed to fileDialog"); 881​ fdSaveOptions.printDebug ("\tcorrected saveOptions passed to fileDialog");
882#endif 882​#endif
883 883​
884 kpDocumentSaveOptionsWidget *saveOptionsWidget = 884​ kpDocumentSaveOptionsDialog *saveOptionsDialog =
885 new kpDocumentSaveOptionsWidget (imageToBeSaved, 885​ new kpDocumentSaveOptionsDialog (imageToBeSaved,
886 fdSaveOptions, 886​ fdSaveOptions,
887 docMetaInfo, 887​ docMetaInfo,
888 this); 888​ this);
889​ QString recentDirClass;
aacidUnsubmitted
Done

Why not use the native dialog?

aacid: Why not use the native dialog?
yurchorAuthorUnsubmitted
Not Done

From Qt 5.11 documentation:

By default, a platform-native file dialog will be used if the platform has one. In that case, the widgets which would otherwise be used to construct the dialog will not be instantiated, so related accessors such as layout() and itemDelegate() will return null. You can set the DontUseNativeDialog option to ensure that the widget-based implementation will be used instead of the native dialog.

yurchor: From Qt 5.11 documentation: > By default, a platform-native file dialog will be used if the…
890​ QUrl defaultURL = QUrl (startURL);
891​ if ( defaultURL.url().isEmpty() )
892​ {
893​ defaultURL = KFileWidget::getStartUrl(QUrl(QStringLiteral("kfiledialog:///savedImages")), recentDirClass);
894​ }
889 895​
890 KFileDialog fd (QUrl (startURL), QString(), this, 896​ QFileDialog fd ( this, Qt::WindowFlags() );
891 saveOptionsWidget); 897​ fd.setWindowTitle( caption );
892 saveOptionsWidget->setVisualParent (&fd); 898​ fd.setAcceptMode( QFileDialog::AcceptSave );
893 fd.setWindowTitle (caption); 899​ fd.setMimeTypeFilters ( mimeTypes );
894 fd.setOperationMode (KFileDialog::Saving); 900​ if ( startURL.isEmpty() )
895 fd.setMimeFilter (mimeTypes, fdSaveOptions.mimeType ()); 901​ {
896 if (localOnly) 902​ fd.setDirectoryUrl( defaultURL );
897 fd.setMode (KFile::File | KFile::LocalOnly); 903​ fd.selectFile( i18n("unnamed") + QLatin1String(".png") );
898 904​ fd.selectMimeTypeFilter("image/png");
899 connect (&fd, SIGNAL (filterChanged(QString)), 905​ }
900 saveOptionsWidget, SLOT (setMimeType(QString))); 906​ else
907​ {
908​ fd.selectUrl( defaultURL );
909​ fd.selectMimeTypeFilter("image/" + QFileInfo(startURL).suffix().toLower());
910​ }
911​
912​ connect (&fd, &QFileDialog::filterSelected,
913​ saveOptionsDialog, &kpDocumentSaveOptionsDialog::setMimeType);
901 914​
902 if ( fd.exec() == QDialog::Accepted ) 915​ if ( fd.exec() == QDialog::Accepted && saveOptionsDialog->exec() == QDialog::Accepted )
903 { 916​ {
904 kpDocumentSaveOptions newSaveOptions = saveOptionsWidget->documentSaveOptions (); 917​ kpDocumentSaveOptions newSaveOptions = saveOptionsDialog->documentSaveOptions ();
905 #if DEBUG_KP_MAIN_WINDOW 918​ #if DEBUG_KP_MAIN_WINDOW
906 newSaveOptions.printDebug ("\tnewSaveOptions"); 919​ newSaveOptions.printDebug ("\tnewSaveOptions");
907 #endif 920​ #endif
Context not available.
919 932​
920 933​
921 bool shouldAllowOverwritePrompt = 934​ bool shouldAllowOverwritePrompt =
922 (fd.selectedUrl () != QUrl (startURL) || 935​ (fd.selectedUrls ().first ().toLocalFile() != QUrl (startURL).toLocalFile() ||
923 newSaveOptions.mimeType () != startSaveOptions.mimeType ()); 936​ newSaveOptions.mimeType () != startSaveOptions.mimeType ());
924 if (allowOverwritePrompt) 937​ if (allowOverwritePrompt)
925 { 938​ {
Context not available.
944 qCDebug(kpLogMainWindow) << "\tallowLossyPrompt=" << *allowLossyPrompt; 957​ qCDebug(kpLogMainWindow) << "\tallowLossyPrompt=" << *allowLossyPrompt;
945 #endif 958​ #endif
946 } 959​ }
960​ if (!recentDirClass.isEmpty() && defaultURL.toLocalFile()!=fd.selectedUrls ().first ().toLocalFile ())
961​ {
962​ KRecentDirs::add(recentDirClass, QFileInfo(fd.selectedUrls ().first ().toLocalFile ()).absolutePath ());
963​ }
947 964​
948 965​
949 #if DEBUG_KP_MAIN_WINDOW 966​ #if DEBUG_KP_MAIN_WINDOW
950 qCDebug(kpLogMainWindow) << "\tselectedUrl=" << fd.selectedUrl (); 967​ qCDebug(kpLogMainWindow) << "\tselectedUrl=" << fd.selectedUrls ().at(0);
951 #endif 968​ #endif
952 return fd.selectedUrl (); 969​ return fd.selectedUrls ().at(0);
953 } 970​ }
954 else 971​ else
955 return QUrl (); 972​ return QUrl ();
Context not available.
959//--------------------------------------------------------------------- 976​//---------------------------------------------------------------------
960 977​
961// private slot 978​// private slot
962bool kpMainWindow::saveAs (bool localOnly) 979​bool kpMainWindow::saveAs ()
963{ 980​{
964 kpDocumentSaveOptions chosenSaveOptions; 981​ kpDocumentSaveOptions chosenSaveOptions;
965 bool allowOverwritePrompt, allowLossyPrompt; 982​ bool allowOverwritePrompt, allowLossyPrompt;
Context not available.
969 *d->document->saveOptions (), 986​ *d->document->saveOptions (),
970 *d->document->metaInfo (), 987​ *d->document->metaInfo (),
971 kpSettingsGroupFileSaveAs, 988​ kpSettingsGroupFileSaveAs,
972 localOnly, ​
973 &chosenSaveOptions, 989​ &chosenSaveOptions,
974 !d->document->savedAtLeastOnceBefore (), 990​ !d->document->savedAtLeastOnceBefore (),
975 &allowOverwritePrompt, 991​ &allowOverwritePrompt,
Context not available.
1018 d->lastExportSaveOptions, 1034​ d->lastExportSaveOptions,
1019 *d->document->metaInfo (), 1035​ *d->document->metaInfo (),
1020 kpSettingsGroupFileExport, 1036​ kpSettingsGroupFileExport,
1021 false/*allow remote files*/, ​
1022 &chosenSaveOptions, 1037​ &chosenSaveOptions,
1023 d->exportFirstTime, 1038​ d->exportFirstTime,
1024 &allowOverwritePrompt, 1039​ &allowOverwritePrompt,
Context not available.