Differential D15979 Diff 44339 plugins/sms/smsplugin.cpp

Changeset View

Standalone View

plugins/sms/smsplugin.cpp

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Line(s)
72	{	72		{
73	NetworkPacket np(PACKET_TYPE_SMS_REQUEST_CONVERSATIONS);	73		NetworkPacket np(PACKET_TYPE_SMS_REQUEST_CONVERSATIONS);
74		74
75	sendPacket(np);	75		sendPacket(np);
76	}	76		}
77		77
78	void SmsPlugin::requestConversation (const QString& conversationID) const	78		void SmsPlugin::requestConversation (const QString& conversationID) const
79	{	79		{
		80		qint32 threadID = conversationID.toInt();
			apolUnsubmitted Not Done Why this change? apol: Why this change?
			sredmanAuthorUnsubmitted Not Done Because some places we had ints (specifically, this is how Android stores the value) and some places we had strings. It was a bit of a pain for me to remember which went where, so I declared everything should be int. Declaring everything should be string would be just as valid However, that change was actually made in D16475 sredman: Because some places we had ints (specifically, this is how Android stores the value) and some…
80	NetworkPacket np(PACKET_TYPE_SMS_REQUEST_CONVERSATION);	81		NetworkPacket np(PACKET_TYPE_SMS_REQUEST_CONVERSATION);
81	np.set("threadID", conversationID.toInt());	82		np.set("threadID", threadID);
82		83
83	sendPacket(np);	84		sendPacket(np);
		85
		86		return;
			apolUnsubmitted Done Definitely not. apol: Definitely not.
84	}	87		}
85		88
86	void SmsPlugin::forwardToTelepathy(const ConversationMessage& message)	89		void SmsPlugin::forwardToTelepathy(const ConversationMessage& message)
87	{	90		{
88	// If we don't have a valid Telepathy interface, bail out	91		// If we don't have a valid Telepathy interface, bail out
89	if (!(m_telepathyInterface.isValid())) return;	92		if (!(m_telepathyInterface.isValid())) return;
90		93
91	qCDebug(KDECONNECT_PLUGIN_SMS) << "Passing a text message to the telepathy interface";	94		qCDebug(KDECONNECT_PLUGIN_SMS) << "Passing a text message to the telepathy interface";
Show All 28 Lines