Differential D14631 Diff 44217 src/widgets/rename/batchrenametypes_p.h

Changeset View

Standalone View

src/widgets/rename/batchrenametypes_p.h

This file was added.

1		/***************************************************************************
2		* Copyright (C) 2018 by Emirald Mateli <aldo.mateli@gmail.com> *
3		* *
4		* This program is free software; you can redistribute it and/or modify *
5		* it under the terms of the GNU General Public License as published by *
6		* the Free Software Foundation; either version 2 of the License, or *
7		* (at your option) any later version. *
8		* *
9		* This program is distributed in the hope that it will be useful, *
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of *
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12		* GNU General Public License for more details. *
13		* *
14		* You should have received a copy of the GNU General Public License *
15		* along with this program; if not, write to the *
16		* Free Software Foundation, Inc., *
17		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
18		***************************************************************************/
19
20		#ifndef KIO_RENAMETYPES
21		#define KIO_RENAMETYPES
	dfaureUnsubmitted Done doesn't match the name of the header, please adjust dfaure: doesn't match the name of the header, please adjust
22
23		#include "kiowidgets_export.h"
24		#include <QString>
25		#include <QVariant>
26
27		namespace KIO
28		{
29
30		typedef QString RenamerFunction(const QHash<QString, QVariant> &);
31
32		class KIOWIDGETS_EXPORT BatchRenameTypes
33		{
	dfaureUnsubmitted Done why exported? for unit tests? if so, add a comment. If not, remove. But anyhow this isn't a class, everything is static. To avoid generating a constructor and a destructor, make it a namespace (like you did for BatchRenameVar) and (if needed) export the individual functions. dfaure: why exported? for unit tests? if so, add a comment. If not, remove. But anyhow this isn't a…
34		private:
35		static QStringList capturedGroups;
36		public:
	dfaureUnsubmitted Done move to .cpp file, it's not needed here at all dfaure: move to .cpp file, it's not needed here at all
37		static QStringList firstCapturedGroups();
38		static void clearCapturedGroups();
39
40		static QString macroRenamer(const QHash<QString, QVariant> &params);
41		static QString findReplaceRenamer(const QHash<QString, QVariant> &params);
42		static QString captureRegexGroups(const QHash<QString, QVariant> &params);
43		};
44		}
45
46		#endif