Differential D14631 Diff 44189 src/widgets/rename/batchrenamedialog.h

Changeset View

Standalone View

src/widgets/rename/batchrenamedialog.h

This file was added.

1		/***************************************************************************
2		* Copyright (C) 2018 by Emirald Mateli <aldo.mateli@gmail.com> *
3		* *
4		* This program is free software; you can redistribute it and/or modify *
5		* it under the terms of the GNU General Public License as published by *
6		* the Free Software Foundation; either version 2 of the License, or *
7		* (at your option) any later version. *
8		* *
9		* This program is distributed in the hope that it will be useful, *
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of *
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12		* GNU General Public License for more details. *
13		* *
14		* You should have received a copy of the GNU General Public License *
15		* along with this program; if not, write to the *
16		* Free Software Foundation, Inc., *
17		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
18		***************************************************************************/
19
20		#ifndef BatchRenameDialog_H
21		#define BatchRenameDialog_H
22
23		#include "kiowidgets_export.h"
24		#include "batchrenamedialogmodel_p.h"
25		#include "batchrenametypes_p.h"
26
27		#include <QCheckBox>
28		#include <QDialog>
	dfaureUnsubmitted Done Forward declaration would be enough (`class QCheckBox`). Same for anything used by pointer (or ref) in this header. dfaure: Forward declaration would be enough (`class QCheckBox`). Same for anything used by pointer (or…
29		#include <QSpinBox>
30		#include <QTableWidget>
31		#include <QStatusBar>
32		#include <QTimer>
33
34		#include <KFileItem>
35		#include <KMessageWidget>
36		#include <QAction>
37		#include <QLabel>
38
39		namespace KIO
40		{
41
42		class KIOWIDGETS_EXPORT BatchRenameDialog : public QDialog
43		{
	dfaureUnsubmitted Done If you export it in an installed header, you need to document it. dfaure: If you export it in an installed header, you need to document it.
44		Q_OBJECT
45
	dfaureUnsubmitted Done indent this line by 4 spaces please dfaure: indent this line by 4 spaces please
46		public:
47		BatchRenameDialog ( QWidget *parent, const KFileItemList &items );
48
49		Q_SIGNALS:
50		void renamingFinished ( const QList<QUrl> &urls );
51
52		private:
53		void onEditValueChanged ( const QString &value );
54		void btnOkClicked();
55		void updateStatus ( const QString &message, KMessageWidget::MessageType messageType = KMessageWidget::Information );
56		void performPreviewRename ( RenamerFunction *callback );
57		void performItemsRename();
58		void renameItem ( const KFileItem &item, const QString &newName );
59		void updatePreview();
60		void createInsertTokenMenu();
61		void updateCapturedGroupsLabel();
62
63		QAction *createInsertTokenAction ( const QString &text, const QString &token );
64		QLineEdit *createLineEdit();
65
66		QList<QPair<KFileItem, QString>> m_itemsToBeRenamed;
67		QList<QUrl> m_renamedItems;
	dfaureUnsubmitted Done If you make this class public, you need to move all members to a Private class, and keep only a "d" pointer here. See all other public classes... dfaure: If you make this class public, you need to move all members to a Private class, and keep only a…
68
69		KMessageWidget *m_messageWidget;
70		QTimer *m_timer;
	mlaurentUnsubmitted Not Done it's a good idea to initialize to nullptr each pointer here. So we can see problem easily. mlaurent: it's a good idea to initialize to nullptr each pointer here. So we can see problem easily.
	emateliAuthorUnsubmitted Not Done You mean to initialize them to nullptr on the header file or using a constructor initialization list? Also see what problem? emateli: You mean to initialize them to nullptr on the header file or using a constructor initialization…
	mlaurentUnsubmitted Not Done in header file. mlaurent: in header file.
71		QPushButton *m_btnOk;
72		BatchRenameDialogModel *model;
73		QTableView *m_previewTable;
74		QTabWidget *m_tabs;
75
76		QMenu *m_insertTokenMenu;
77		QLineEdit *m_macroReplaceEdit;
78		QSpinBox *m_IdStartFrom;
79		QSpinBox *m_IdPaddingLength;
80
81		QLineEdit *m_findEdit;
82		QLineEdit *m_replaceEdit;
83		QCheckBox *m_useRegex;
84		QCheckBox *m_caseInsensitive;
85
86		QLineEdit *m_patternFind;
87		QLineEdit *m_newNameFromMatches;
88		QLabel *m_capturedGroupsText;
89		};
90		}
91
92		#endif