Differential D16325 Diff 43981 shell_client.h

Changeset View

Standalone View

View Options

shell_client.h

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Line(s)54public:
142 void installServerSideDecoration(KWayland::Server::ServerSideDecorationInterface *decoration); 142​ void installServerSideDecoration(KWayland::Server::ServerSideDecorationInterface *decoration);
143 void installAppMenu(KWayland::Server::AppMenuInterface *appmenu); 143​ void installAppMenu(KWayland::Server::AppMenuInterface *appmenu);
144 void installPalette(KWayland::Server::ServerSideDecorationPaletteInterface *palette); 144​ void installPalette(KWayland::Server::ServerSideDecorationPaletteInterface *palette);
145 145​
146 bool isInitialPositionSet() const override; 146​ bool isInitialPositionSet() const override;
147 147​
148 bool isTransient() const override; 148​ bool isTransient() const override;
149 bool hasTransientPlacementHint() const override; 149​ bool hasTransientPlacementHint() const override;
150 QPoint transientPlacementHint() const override; 150​ QRect transientPlacement(const QRect &bounds) const override;
151 151​
152 QMatrix4x4 inputTransformation() const override; 152​ QMatrix4x4 inputTransformation() const override;
153 153​
154 bool setupCompositing() override; 154​ bool setupCompositing() override;
155 void finishCompositing(ReleaseReason releaseReason = ReleaseReason::Release) override; 155​ void finishCompositing(ReleaseReason releaseReason = ReleaseReason::Release) override;
156 156​
157 void showOnScreenEdge() override; 157​ void showOnScreenEdge() override;
158 158​
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Line(s)190private:
205 void setTransient(); 205​ void setTransient();
206 bool shouldExposeToWindowManagement(); 206​ bool shouldExposeToWindowManagement();
207 void updateClientOutputs(); 207​ void updateClientOutputs();
208 KWayland::Server::XdgShellSurfaceInterface::States xdgSurfaceStates() const; 208​ KWayland::Server::XdgShellSurfaceInterface::States xdgSurfaceStates() const;
209 void updateShowOnScreenEdge(); 209​ void updateShowOnScreenEdge();
210 void updateMaximizeMode(MaximizeMode maximizeMode); 210​ void updateMaximizeMode(MaximizeMode maximizeMode);
211 // called on surface commit and processes all m_pendingConfigureRequests up to m_lastAckedConfigureReqest 211​ // called on surface commit and processes all m_pendingConfigureRequests up to m_lastAckedConfigureReqest
212 void updatePendingGeometry(); 212​ void updatePendingGeometry();
213​ QPoint popupOffset(const QRect &anchorRect, const Qt::Edges anchorEdge, const Qt::Edges gravity) const;
zzagUnsubmitted
Not Done

We probably don't need const for anchor edges and gravity.

zzag: We probably don't need const for anchor edges and gravity.
davidedmundsonAuthorUnsubmitted
Not Done

Sure I don't need them from the view of whoever is calling this method, I'm making a copy and functionally equivalent but I want to document them as being local within the body of the method.

davidedmundson: Sure I don't need them from the view of whoever is calling this method, I'm making a copy and…
213 static void deleteClient(ShellClient *c); 214​ static void deleteClient(ShellClient *c);
214 215​
215 KWayland::Server::ShellSurfaceInterface *m_shellSurface; 216​ KWayland::Server::ShellSurfaceInterface *m_shellSurface;
216 KWayland::Server::XdgShellSurfaceInterface *m_xdgShellSurface; 217​ KWayland::Server::XdgShellSurfaceInterface *m_xdgShellSurface;
217 KWayland::Server::XdgShellPopupInterface *m_xdgShellPopup; 218​ KWayland::Server::XdgShellPopupInterface *m_xdgShellPopup;
218 219​
219 // size of the last buffer 220​ // size of the last buffer
220 QSize m_clientSize; 221​ QSize m_clientSize;
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines