Differential D15316 Diff 43979 widgets/imagelib/effects/kpEffectWidgetBase.h

Changeset View

Standalone View

View Options

widgets/imagelib/effects/kpEffectWidgetBase.h

Context not available.
30#define kpEffectWidgetBase_H 30​#define kpEffectWidgetBase_H
31 31​
32 32​
33#include <qwidget.h> 33​#include <QWidget>
34 34​
35#include "imagelib/kpImage.h" 35​#include "imagelib/kpImage.h"
36 36​
37​#include <QDoubleSpinBox>
38​
39​#include <QSlider>
37 40​
38class kpCommandEnvironment; 41​class kpCommandEnvironment;
39class kpEffectCommandBase; 42​class kpEffectCommandBase;
40 43​
44​class KpMultDoubleSpinBox : public QDoubleSpinBox
aacidUnsubmitted
Done

Do you need these two classes to do double<->int conversion in the signals, right?

A bit sad :/

Anyway, don't call them QSomething, that's reserved for Qt, call them KpSomething

aacid: Do you need these two classes to do double<->int conversion in the signals, right? A bit sad…
45​{
46​ Q_OBJECT
47​
48​public:
49​ KpMultDoubleSpinBox(QWidget *parent = 0) : QDoubleSpinBox(parent)
50​ {
51​ connect(this, QOverload<double>::of(&QDoubleSpinBox::valueChanged),
52​ this, &KpMultDoubleSpinBox::notifySBValueChanged);
53​ }
54​
55​signals:
56​ void doubleSBValueChanged(int value);
57​
58​public slots:
59​ void notifySBValueChanged(double value)
60​ {
61​ int scale = 100;
62​ // linear mapping [min, max] -> [-scale, scale]
63​ double multValue = qRound((2 * value - maximum() - minimum()) / (maximum() - minimum()) * scale);
64​ emit doubleSBValueChanged(multValue);
65​ }
66​};
67​
68​class KpDoubleSlider : public QSlider
69​{
70​ Q_OBJECT
71​
72​public:
73​ KpDoubleSlider(QWidget *parent = 0, double minimumValue = 0, double maximumValue = 1) : QSlider(Qt::Horizontal, parent)
mkollerUnsubmitted
Done

There is no advantage in using const & for a double: const double &minimumValue
simply use double minimumValue

mkoller: There is no advantage in using const & for a double: const double &minimumValue simply use…
74​ {
75​ m_minValue = minimumValue;
76​ m_maxValue = maximumValue;
77​ connect(this, &QSlider::valueChanged,
78​ this, &KpDoubleSlider::notifyValueChanged);
79​ }
80​
81​signals:
82​ void doubleValueChanged(double value);
83​
84​public slots:
85​ void notifyValueChanged(int value)
86​ {
87​ int scale = 100;
88​ // linear mapping [-scale, scale] -> [m_minValue, m_maxValue]
89​ double doubleValue = (value / 2.0 / scale) * (m_maxValue - m_minValue) + (m_maxValue + m_minValue) / 2.0;
90​ emit doubleValueChanged(doubleValue);
91​ }
92​private:
93​ double m_minValue;
94​ double m_maxValue;
95​};
41 96​
42class kpEffectWidgetBase : public QWidget 97​class kpEffectWidgetBase : public QWidget
43{ 98​{
Context not available.