Differential D15804 Diff 43783 kate/katequickopenmodel.h

Changeset View

Standalone View

View Options

kate/katequickopenmodel.h

  • This file was added.
1​/*
2​ This library is free software; you can redistribute it and/or
shubhamUnsubmitted
Done

Please add a copyright header.

shubham: Please add a copyright header.
3​ modify it under the terms of the GNU Library General Public
4​ License as published by the Free Software Foundation; either
5​ version 2 of the License, or (at your option) any later version.
6​
7​ This library is distributed in the hope that it will be useful,
8​ but WITHOUT ANY WARRANTY; without even the implied warranty of
9​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
10​ Library General Public License for more details.
11​
12​ You should have received a copy of the GNU Library General Public License
13​ along with this library; see the file COPYING.LIB. If not, write to
14​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
15​ Boston, MA 02110-1301, USA.
gregormiUnsubmitted
Done

I wonder if there is a good way to make it more clear that these enum symbols are used as implicitly casted column index numbers later.

gregormi: I wonder if there is a good way to make it more clear that these enum symbols are used as…
dhaumannUnsubmitted
Done

Could be done with enum class. Then you'd have to write Column::FileName etc (along with static_cast<int>(...)).

dhaumann: Could be done with enum class. Then you'd have to write Column::FileName etc (along with…
gregormiUnsubmitted
Done

Hmm, that would be 11 instances of std::get<...> which then will look not so nice. The current version seems like a good compromise.

gregormi: Hmm, that would be 11 instances of std::get<...> which then will look not so nice. The current…
16​ ---
17​ Copyright (C) 2018 Tomaz Canabrava <tcanabrava@kde.org>
18​*/
19​
20​#ifndef KATEQUICKOPENMODEL_H
21​#define KATEQUICKOPENMODEL_H
22​
23​#include <QAbstractTableModel>
24​#include <QVector>
25​#include <tuple>
26​#include <QVariant>
27​
28​#include "katemainwindow.h"
29​
30​struct ModelEntry {
31​ QString fileName;
32​ QString filePath;
33​ bool bold;
34​};
35​
36​class KateQuickOpenModel : public QAbstractTableModel {
37​ Q_OBJECT
38​public:
39​ enum Columns : int { FileName, FilePath, Bold };
gregormiUnsubmitted
Not Done

Cool. Now this could be an "enum class". And Bold is not needed anymore.

gregormi: Cool. Now this could be an "enum class". And Bold is not needed anymore.
40​ explicit KateQuickOpenModel(KateMainWindow *mainWindow, QObject *parent=nullptr);
41​ int rowCount(const QModelIndex& parent) const override;
42​ int columnCount(const QModelIndex& parent) const override;
43​ QVariant data(const QModelIndex& idx, int role) const override;
44​ void refresh();
45​
46​private:
47​ QVector<ModelEntry> m_modelEntries;
48​
49​ /* TODO: don't rely in a pointer to the main window.
50​ * this is bad enginering, but current code is too tigth
51​ * on this and it's hard to untangle without breaking existing
52​ * code.
53​ */
54​ KateMainWindow *m_mainWindow;
55​};
56​
57​#endif