Home
Phabricator
Search
Log In
Differential
D16054
Diff 43602
addons/tabswitcher/tabswitcherfilesmodel.h
Changeset View
Indeed using a QStandardItem when NOT using a QStandardItemModel is more confusing than it helps, since some data is fetched directly from the item's member variables, and some data via the data() accessor. I strongly suggest to not do this: Since we derive from QAbstractTableModel now, I'd argue that using QStandardItem is wrong in terms of "that's not how it was designed".
Mixing ->data() and direct member access is rather confusing.