Changeset View
Changeset View
Standalone View
Standalone View
plugins/grepview/CMakeLists.txt
| 1 | add_definitions(-DTRANSLATION_DOMAIN=\"kdevgrepview\") | 1 | add_definitions(-DTRANSLATION_DOMAIN=\"kdevgrepview\") | ||
|---|---|---|---|---|---|
| 2 | 2 | | |||
| 3 | ########### next target ############### | 3 | ########### next target ############### | ||
| 4 | 4 | | |||
| 5 | ecm_qt_declare_logging_category(kdevgrepview_LOG_PART_SRCS | 5 | declare_qt_logging_category(kdevgrepview_LOG_PART_SRCS | ||
| 6 | HEADER debug.h | 6 | TYPE PLUGIN | ||
apol: I find it odd that we're creating a macro to reduce the redundant parts but in practice not end… | |||||
One cannot see all the reduction directly from the diff for the plugins, as here we are jumping directly to generated installed categories file. Not sure what you mean by "having the target as the argument"? And "use the target name as the basename"? The main purpose of the macros "declare*_qt_logging_category" is still to generate the debug source files. Collecting the data so that we can autogenerate the installed categories file for those who want to use kdebugsettings is a 2nd-order purpose. kossebau: One cannot see all the reduction directly from the diff for the plugins, as here we are jumping… | |||||
| 7 | IDENTIFIER PLUGIN_GREPVIEW | 7 | IDENTIFIER PLUGIN_GREPVIEW | ||
| 8 | CATEGORY_NAME "kdevelop.plugins.grepview" | 8 | CATEGORY_BASENAME "grepview" | ||
| 9 | ) | 9 | ) | ||
| 10 | 10 | | |||
| 11 | set(kdevgrepview_PART_SRCS | 11 | set(kdevgrepview_PART_SRCS | ||
| 12 | grepviewplugin.cpp | 12 | grepviewplugin.cpp | ||
| 13 | grepviewpluginmetadata.cpp | 13 | grepviewpluginmetadata.cpp | ||
| 14 | grepdialog.cpp | 14 | grepdialog.cpp | ||
| 15 | grepoutputmodel.cpp | 15 | grepoutputmodel.cpp | ||
| 16 | grepoutputdelegate.cpp | 16 | grepoutputdelegate.cpp | ||
| Show All 34 Lines | |||||
I find it odd that we're creating a macro to reduce the redundant parts but in practice not end up reducing much.
I would suggest also having the target as the argument rather than the output variable. It will make it easier to see the 1:1 relationship and also make it possible to use the target name as the basename.