Changeset View
Changeset View
Standalone View
Standalone View
deleted.cpp
Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Line(s) | 73 | { | |||
---|---|---|---|---|---|
75 | delete this; | 75 | delete this; | ||
76 | } | 76 | } | ||
77 | 77 | | |||
78 | void Deleted::copyToDeleted(Toplevel* c) | 78 | void Deleted::copyToDeleted(Toplevel* c) | ||
79 | { | 79 | { | ||
80 | assert(dynamic_cast< Deleted* >(c) == NULL); | 80 | assert(dynamic_cast< Deleted* >(c) == NULL); | ||
81 | Toplevel::copyToDeleted(c); | 81 | Toplevel::copyToDeleted(c); | ||
82 | desk = c->desktop(); | 82 | desk = c->desktop(); | ||
83 | m_desktops = c->desktops(); | ||||
83 | activityList = c->activities(); | 84 | activityList = c->activities(); | ||
84 | contentsRect = QRect(c->clientPos(), c->clientSize()); | 85 | contentsRect = QRect(c->clientPos(), c->clientSize()); | ||
85 | m_contentPos = c->clientContentPos(); | 86 | m_contentPos = c->clientContentPos(); | ||
86 | transparent_rect = c->transparentRect(); | 87 | transparent_rect = c->transparentRect(); | ||
87 | m_layer = c->layer(); | 88 | m_layer = c->layer(); | ||
88 | m_frame = c->frameId(); | 89 | m_frame = c->frameId(); | ||
89 | m_opacity = c->opacity(); | 90 | m_opacity = c->opacity(); | ||
90 | m_type = c->windowType(true); | 91 | m_type = c->windowType(true); | ||
▲ Show 20 Lines • Show All 45 Lines • ▼ Show 20 Line(s) | 136 | { | |||
136 | return desk; | 137 | return desk; | ||
137 | } | 138 | } | ||
138 | 139 | | |||
139 | QStringList Deleted::activities() const | 140 | QStringList Deleted::activities() const | ||
140 | { | 141 | { | ||
141 | return activityList; | 142 | return activityList; | ||
142 | } | 143 | } | ||
143 | 144 | | |||
145 | QList<VirtualDesktop *> Deleted::desktops() const | ||||
146 | { | ||||
147 | return m_desktops; | ||||
zzagUnsubmitted Not Done zzag: ```lang=cpp
return {};
``` | |||||
Why aren't we copying and returning the full list? If a window is on desktop 1 and 2 and we close the window we still want it to animate away on whichever desktop the user is on. See void Deleted::copyToDeleted(Toplevel* c) davidedmundson: Why aren't we copying and returning the full list?
If a window is on desktop 1 and 2 and we… | |||||
148 | } | ||||
149 | | ||||
144 | QPoint Deleted::clientPos() const | 150 | QPoint Deleted::clientPos() const | ||
145 | { | 151 | { | ||
146 | return contentsRect.topLeft(); | 152 | return contentsRect.topLeft(); | ||
147 | } | 153 | } | ||
148 | 154 | | |||
149 | QSize Deleted::clientSize() const | 155 | QSize Deleted::clientSize() const | ||
150 | { | 156 | { | ||
151 | return contentsRect.size(); | 157 | return contentsRect.size(); | ||
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines |