Differential D16039 Diff 43309 src/backends/python/pythonbackend.h

Changeset View

Standalone View

View Options

src/backends/python/pythonbackend.h

Show All 16 Lines1/*
17 --- 17​ ---
18 Copyright (C) 2012 Filipe Saraiva <filipe@kde.org> 18​ Copyright (C) 2012 Filipe Saraiva <filipe@kde.org>
19 */ 19​ */
20 20​
21#ifndef _PYTHONBACKEND_H 21​#ifndef _PYTHONBACKEND_H
22#define _PYTHONBACKEND_H 22​#define _PYTHONBACKEND_H
23 23​
24#include "backend.h" 24​#include "backend.h"
25​#include <cantor_pythonbackend_export.h>
pinoUnsubmitted
Done

this ought to be <...>, because it's a generated header in a directory different than the same source directory of this file

pino: this ought to be <...>, because it's a generated header in a directory different than the same…
25 26​
26class CANTOR_EXPORT PythonBackend : public Cantor::Backend 27​class CANTOR_PYTHONBACKEND_EXPORT PythonBackend : public Cantor::Backend
sirgienkoUnsubmitted
Not Done

Is this export necesary?
Other backends don't hasen't used cantor_export.h, so maybe this backend shouldn't do it too?

sirgienko: Is this export necesary? Other backends don't hasen't used `cantor_export.h`, so maybe this…
pinoUnsubmitted
Not Done

Other backends do not have a shared library, like cantor_pythonbackend. Since both cantor_python2backend and cantor_python3backend are implemented using cantor_pythonbackend, then its symbols are needed.

pino: Other backends do not have a shared library, like cantor_pythonbackend. Since both…
27{ 28​{
28 Q_OBJECT 29​ Q_OBJECT
29 public: 30​ public:
30 explicit PythonBackend(QObject* parent = nullptr, const QList<QVariant> args = QList<QVariant>()); 31​ explicit PythonBackend(QObject* parent = nullptr, const QList<QVariant> args = QList<QVariant>());
31 ~PythonBackend() override; 32​ ~PythonBackend() override;
32 33​
33 Cantor::Backend::Capabilities capabilities() const override; 34​ Cantor::Backend::Capabilities capabilities() const override;
34 35​
35 QWidget* settingsWidget(QWidget* parent) const override; 36​ QWidget* settingsWidget(QWidget* parent) const override;
36 KConfigSkeleton* config() const override = 0; 37​ KConfigSkeleton* config() const override = 0;
37}; 38​};
38 39​
39 40​
40#endif /* _PYTHONBACKEND_H */ 41​#endif /* _PYTHONBACKEND_H */