Differential D15804 Diff 43117 kate/katequickopenmodel.h

Changeset View

Standalone View

kate/katequickopenmodel.h

This file was added.

1		#ifndef KATEQUICKOPENMODEL_H
2		#define KATEQUICKOPENMODEL_H
	shubhamUnsubmitted Done Please add a copyright header. shubham: Please add a copyright header.
3
4		#include <QAbstractTableModel>
5		#include <QVector>
6		#include <QPair>
7		#include <QVariant>
8
9		#include "katemainwindow.h"
10
11		class KateQuickOpenModel : public QAbstractTableModel {
12		Q_OBJECT
13		public:
14		enum Columns : int { FileName, FilePath, Count };
15		explicit KateQuickOpenModel(KateMainWindow mainWindow, QObject parent=nullptr);
	gregormiUnsubmitted Done I wonder if there is a good way to make it more clear that these enum symbols are used as implicitly casted column index numbers later. gregormi: I wonder if there is a good way to make it more clear that these enum symbols are used as…
	dhaumannUnsubmitted Done Could be done with enum class. Then you'd have to write Column::FileName etc (along with static_cast<int>(...)). dhaumann: Could be done with enum class. Then you'd have to write Column::FileName etc (along with…
	gregormiUnsubmitted Done Hmm, that would be 11 instances of std::get<...> which then will look not so nice. The current version seems like a good compromise. gregormi: Hmm, that would be 11 instances of std::get<...> which then will look not so nice. The current…
16		int rowCount(const QModelIndex& parent) const override;
17		int columnCount(const QModelIndex& parent) const override;
18		QVariant data(const QModelIndex& idx, int role) const override;
19		void refresh();
20
21		private:
22		QVector<QPair<QString, QString>> m_modelEntries;
23
24		/* TODO: don't rely in a pointer to the main window.
25		* this is bad enginering, but current code is too tigth
26		* on this and it's hard to untangle without breaking existing
27		* code.
28		*/
29		KateMainWindow *m_mainWindow;
30		};
31
32		#endif
	gregormiUnsubmitted Not Done Cool. Now this could be an "enum class". And Bold is not needed anymore. gregormi: Cool. Now this could be an "enum class". And Bold is not needed anymore.