Differential D16026 Diff 43077 src/timeline/customtrackview.cpp

Changeset View

Standalone View

View Options

src/timeline/customtrackview.cpp

Context not available.
7032 d->label->setText(i18n("Insert track")); 7032​ d->label->setText(i18n("Insert track"));
7033 QStringList existingTrackNames = m_timeline->getTrackNames(); 7033​ QStringList existingTrackNames = m_timeline->getTrackNames();
7034 int i = 1; 7034​ int i = 1;
7035 QString proposedName = i18n("Video %1", i); 7035​ QString trackType;
7036​ if (m_timeline->getTrackInfo(ix).type == VideoTrack) {
7037​ trackType = "Video";
7038​ d->video_track->setChecked(true);
7039​ } else {
7040​ trackType = "Audio";
7041​ d->audio_track->setChecked(true);
7042​ }
7043​ QString proposedName = i18n("%1 %2", trackType, i);
7036 while (existingTrackNames.contains(proposedName)) { 7044​ while (existingTrackNames.contains(proposedName)) {
7037 proposedName = i18n("Video %1", ++i); 7045​ proposedName = i18n("%1 %2", trackType, ++i);
mardelleUnsubmitted
Not Done

I don't think this will work for translations. It would be better to define a boolean, like: isVideoTrack, set to true if m_timeline->getTrackInfo(ix).type == VideoTrack.

Then in the while loop:
while (existingTrackNames.contains(proposedName)) {
proposedName = isVideoTrack ? i18n("Video %1", ++i) : i18n("Audio %1", ++i);
}

mardelle: I don't think this will work for translations. It would be better to define a boolean, like…
7038 } 7046​ }
7039 d->track_name->setText(proposedName); 7047​ d->track_name->setText(proposedName);
7040 d->setWindowTitle(i18n("Insert New Track")); 7048​ d->setWindowTitle(i18n("Insert New Track"));
Context not available.