Differential D15520 Diff 42281 tests/simpleipv4test.cpp

Changeset View

Standalone View

View Options

tests/simpleipv4test.cpp

  • This file was added.
1​/*
2​Copyright 2018 Bruce Anderson <banderson19com@san.rr.com>
3​
4​This program is free software; you can redistribute it and/or
5​modify it under the terms of the GNU General Public License as
6​published by the Free Software Foundation; either version 2 of
7​the License or (at your option) version 3 or any later version
8​accepted by the membership of KDE e.V. (or its successor approved
9​by the membership of KDE e.V.), which shall act as a proxy
10​defined in Section 14 of version 3 of the license.
11​
12​This program is distributed in the hope that it will be useful,
13​but WITHOUT ANY WARRANTY; without even the implied warranty of
14​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​GNU General Public License for more details.
16​
17​You should have received a copy of the GNU General Public License
18​along with this program. If not, see <http://www.gnu.org/licenses/>.
19​*/
20​
21​#include "simpleipv4addressvalidator.h"
22​#include <QTest>
23​
24​class SimpleIpv4Test : public QObject
pinoUnsubmitted
Done

unused

pino: unused
pinoUnsubmitted
Done

unused

pino: unused
25​{
26​ Q_OBJECT
27​
28​public:
29​ SimpleIpv4Test();
30​
31​private slots:
32​ void baseTest();
33​ void baseTest_data();
34​ void cidrTest();
35​ void cidrTest_data();
36​ void portTest();
37​ void portTest_data();
38​
39​private:
40​ SimpleIpV4AddressValidator m_vb;
41​ SimpleIpV4AddressValidator m_vc;
42​ SimpleIpV4AddressValidator m_vp;
43​};
44​
45​
46​SimpleIpv4Test::SimpleIpv4Test()
pinoUnsubmitted
Done

even if this is a test, these are leaked, "polluting" the results of tools like valgrind; just make them non-pointers class variables

pino: even if this is a test, these are leaked, "polluting" the results of tools like valgrind; just…
47​ : m_vb(nullptr, SimpleIpV4AddressValidator::AddressStyle::Base)
48​ , m_vc(nullptr, SimpleIpV4AddressValidator::AddressStyle::WithCidr)
49​ , m_vp(nullptr, SimpleIpV4AddressValidator::AddressStyle::WithPort)
pinoUnsubmitted
Done

please use a data-driven approach for this file

pino: please use a data-driven approach for this file
50​{
51​}
52​
53​Q_DECLARE_METATYPE(QValidator::State)
54​
pinoUnsubmitted
Done

QVERIFY(foo == bar) -> QCOMPARE(foo, bar), it applies to all the checks in this file

pino: `QVERIFY(foo == bar)` -> `QCOMPARE(foo, bar)`, it applies to all the checks in this file
55​void SimpleIpv4Test::baseTest_data()
56​{
57​ QTest::addColumn<QString>("address");
58​ QTest::addColumn<QValidator::State>("result");
59​
60​ QTest::newRow("empty string") << "" << QValidator::Intermediate;
61​ QTest::newRow("123.12.2") << "123.12.2" << QValidator::Intermediate;
62​ QTest::newRow("123.45.22.9") << "123.45.22.9" << QValidator::Acceptable;
63​ QTest::newRow("1") << "1" << QValidator::Intermediate;
64​ QTest::newRow("12") << "12" << QValidator::Intermediate;
65​ QTest::newRow("123") << "123" << QValidator::Intermediate;
66​ QTest::newRow("123.") << "123." << QValidator::Intermediate;
67​ QTest::newRow("123.4") << "123.4" << QValidator::Intermediate;
68​ QTest::newRow("123.54") << "123.54" << QValidator::Intermediate;
69​ QTest::newRow("123.54.") << "123.54." << QValidator::Intermediate;
70​ QTest::newRow("123.255") << "123.255" << QValidator::Intermediate;
71​ QTest::newRow("123.255.") << "123.255." << QValidator::Intermediate;
72​ QTest::newRow("123.123.9") << "123.123.9" << QValidator::Intermediate;
73​ QTest::newRow("123.34.99") << "123.34.99" << QValidator::Intermediate;
74​ QTest::newRow("123.22.233") << "123.22.233" << QValidator::Intermediate;
75​ QTest::newRow("255.255.255.") << "255.255.255." << QValidator::Intermediate;
76​ QTest::newRow("1.1.1.7") << "1.1.1.7" << QValidator::Acceptable;
77​ QTest::newRow("12a") << "12a" << QValidator::Invalid;
78​ QTest::newRow("255") << "255" << QValidator::Intermediate;
79​ QTest::newRow("256") << "256" << QValidator::Invalid;
80​ QTest::newRow("255.255.255.255") << "255.255.255.255" << QValidator::Acceptable;
81​ QTest::newRow("256.255.255.255") << "256.255.255.255" << QValidator::Invalid;
82​ QTest::newRow("255.256.255.255") << "255.256.255.255" << QValidator::Invalid;
83​ QTest::newRow("255.255.256.255") << "255.255.256.255" << QValidator::Invalid;
84​ QTest::newRow("255.255.255.256") << "255.255.255.256" << QValidator::Invalid;
85​ QTest::newRow("1.1.1.1.") << "1.1.1.1." << QValidator::Invalid;
86​}
87​
88​void SimpleIpv4Test::baseTest()
89​{
90​ int pos;
91​
92​ QFETCH(QString, address);
93​ QFETCH(QValidator::State, result);
94​
95​ QCOMPARE(m_vb.validate(address, pos), result);
96​}
97​
98​void SimpleIpv4Test::cidrTest_data()
99​{
100​ QTest::addColumn<QString>("address");
101​ QTest::addColumn<QValidator::State>("result");
102​
103​ QTest::newRow("10.77.18.4/32") << "10.77.18.4/32" << QValidator::Acceptable;
104​ QTest::newRow("10.77.18.4/33") << "10.77.18.4/33" << QValidator::Invalid;
105​ QTest::newRow("10.77.14.8") << "10.77.14.8" << QValidator::Intermediate;
106​ QTest::newRow("10.77.13/") << "10.77.13/" << QValidator::Invalid;
107​ QTest::newRow("33.22.55.44/") << "33.22.55.44/" << QValidator::Intermediate;
108​ QTest::newRow("11.23.45./") << "11.23.45./" << QValidator::Invalid;
109​ QTest::newRow("0.0.0.0/0") << "0.0.0.0/0" << QValidator::Acceptable;
110​ QTest::newRow("1.2.3.4/28/") << "1.2.3.4/28/" << QValidator::Invalid;
111​ QTest::newRow("1.2.3.4//") << "1.2.3.4//" << QValidator::Invalid;
112​}
113​
114​void SimpleIpv4Test::cidrTest()
115​{
116​ int pos;
117​
118​ QFETCH(QString, address);
119​ QFETCH(QValidator::State, result);
120​
121​ QCOMPARE(m_vc.validate(address, pos), result);
122​}
123​
124​void SimpleIpv4Test::portTest_data()
125​{
126​ QTest::addColumn<QString>("address");
127​ QTest::addColumn<QValidator::State>("result");
128​
129​ QTest::newRow("10.77.18.4:32") << "10.77.18.4:32" << QValidator::Acceptable;
130​ QTest::newRow("10.77.18.4:65536") << "10.77.18.4:65536" << QValidator::Invalid;
131​ QTest::newRow("10.77.18.4") << "10.77.18.4" << QValidator::Intermediate;
132​ QTest::newRow("10.77.13:") << "10.77.13:" << QValidator::Invalid;
133​ QTest::newRow("33.22.55.44:") << "33.22.55.44:" << QValidator::Intermediate;
134​ QTest::newRow("11.23.45.:") << "11.23.45.:" << QValidator::Invalid;
135​ QTest::newRow("0.0.0.0:65535") << "0.0.0.0:65535" << QValidator::Acceptable;
136​ QTest::newRow("1.2.3.4:0:") << "1.2.3.4:0:" << QValidator::Invalid;
137​ QTest::newRow("1.2.3.4::") << "1.2.3.4::" << QValidator::Invalid;
138​}
139​
140​void SimpleIpv4Test::portTest()
141​{
142​ int pos;
143​
144​ QFETCH(QString, address);
145​ QFETCH(QValidator::State, result);
146​
147​ QCOMPARE(m_vp.validate(address, pos), result);
148​}
149​
150​QTEST_APPLESS_MAIN(SimpleIpv4Test)
151​
152​#include "simpleipv4test.moc"