Differential D15093 Diff 42118 vpn/wireguard/wireguardadvancedwidget.h

Changeset View

Standalone View

vpn/wireguard/wireguardadvancedwidget.h

This file was added.

1		/*
2		Copyright 2018 Bruce Anderson <banderson19com@san.rr.com>
3
4		This library is free software; you can redistribute it and/or
5		modify it under the terms of the GNU Lesser General Public
6		License as published by the Free Software Foundation; either
7		version 2.1 of the License, or (at your option) version 3, or any
8		later version accepted by the membership of KDE e.V. (or its
9		successor approved by the membership of KDE e.V.), which shall
10		act as a proxy defined in Section 6 of version 3 of the license.
11
12		This library is distributed in the hope that it will be useful,
13		but WITHOUT ANY WARRANTY; without even the implied warranty of
14		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15		Lesser General Public License for more details.
16
17		You should have received a copy of the GNU Lesser General Public
18		License along with this library. If not, see <http://www.gnu.org/licenses/>.
19		*/
20
21		#ifndef PLASMA_NM_OPENVPN_ADVANCED_WIDGET_H
22		#define PLASMA_NM_OPENVPN_ADVANCED_WIDGET_H
23
24		#include "passwordfield.h"
25
26		#include <QDialog>
27
28		#include <NetworkManagerQt/VpnSetting>
	pinoUnsubmitted Done unused pino: unused
29
30		namespace Ui
31		{
32		class WireGuardAdvancedWidget;
33		}
34
35		class QLineEdit;
36		class WireGuardAdvancedWidget : public QDialog
37		{
38		Q_OBJECT
39
40		public:
41		explicit WireGuardAdvancedWidget(const NetworkManager::VpnSetting::Ptr &setting, QWidget *parent = 0);
42		~WireGuardAdvancedWidget() override;
43		NetworkManager::VpnSetting::Ptr setting() const;
	jgrulichUnsubmitted Done Coding style jgrulich: Coding style
44
45		private:
46		void loadConfig();
47		void setProperty(NMStringMap &data, const QLatin1String &key, const QString &value) const;
48		void setProperty(NMStringMap &data, const QLatin1String &key, const int value) const;
	pinoUnsubmitted Done is this enum ever used anywhere? if not, please drop pino: is this enum ever used anywhere? if not, please drop
49		class Private;
50		Private *const d;
51		};
52
53		#endif // PLASMA_NM_OPENVPN_ADVANCED_WIDGET_H
	pinoUnsubmitted Done const & for both the key and value parameters pino: const & for both the key and value parameters
	jgrulichUnsubmitted Done Can be removed if you don't have any private slot. jgrulich: Can be removed if you don't have any private slot.
	pinoUnsubmitted Done considering there is a private class already, I'd simply move this private variable to it, with no need to be a pointer variable pino: considering there is a private class already, I'd simply move this private variable to it, with…
	pinoUnsubmitted Done const & for both the key and value parameters pino: const & for both the key and value parameters