Differential D15530 Diff 42045 plugins/clang/duchain/cursorkindtraits.h

Changeset View

Standalone View

View Options

plugins/clang/duchain/cursorkindtraits.h

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Line(s)47{
50 || CK == CXCursor_ClassDecl 50​ || CK == CXCursor_ClassDecl
51 || CK == CXCursor_UnionDecl 51​ || CK == CXCursor_UnionDecl
52 || CK == CXCursor_ObjCInterfaceDecl 52​ || CK == CXCursor_ObjCInterfaceDecl
53 || CK == CXCursor_ObjCCategoryDecl 53​ || CK == CXCursor_ObjCCategoryDecl
54 || CK == CXCursor_ObjCImplementationDecl 54​ || CK == CXCursor_ObjCImplementationDecl
55 || CK == CXCursor_ObjCCategoryImplDecl; 55​ || CK == CXCursor_ObjCCategoryImplDecl;
56} 56​}
57 57​
58​// TODO: somehow this is (probably) the function to call in isKDevForwardDeclaration() but
mwolffUnsubmitted
Not Done

I'm still waiting for a textual form of the compiler errors you are seeing

mwolff: I'm still waiting for a textual form of the compiler errors you are seeing
59​// I cannot seem to understand how to achieve that without raising a ton of
60​// uncomprehensible errors in builder.cpp (I can't even remove the ObjC cursor
61​// kinds from the isClass function above?!)
62​// TODO: remove this comment.
mwolffUnsubmitted
Not Done

so can this be removed? if not, what compile errors do you get?

mwolff: so can this be removed? if not, what compile errors do you get?
rjvbbAuthorUnsubmitted
Not Done

Sadly, no, it can't go and I still don't understand a thing of the why and how. 35y of programming tell me I should be able to remove the || CK==CXCursor_ObjC* lines from the function above the commentb but when I do event that I get this:

I get the same errors if instead I call isClassNoObjc() instead of isClass() in isKDevForwardDeclaration(), also when actually building the files.

This goes way beyond my template-fu, hence the comment.

rjvbb: Sadly, no, it can't go and I still don't understand a thing of the why and how. 35y of…
63​constexpr bool isClassNoObjC(CXCursorKind CK)
64​{
65​ return isClassTemplate(CK)
66​ || CK == CXCursor_StructDecl
67​ || CK == CXCursor_ClassDecl
68​ || CK == CXCursor_UnionDecl;
69​}
70​
58constexpr bool isFunction(CXCursorKind CK) 71​constexpr bool isFunction(CXCursorKind CK)
59{ 72​{
60 return CK == CXCursor_FunctionDecl 73​ return CK == CXCursor_FunctionDecl
61 || CK == CXCursor_CXXMethod 74​ || CK == CXCursor_CXXMethod
62 || CK == CXCursor_Constructor 75​ || CK == CXCursor_Constructor
63 || CK == CXCursor_Destructor 76​ || CK == CXCursor_Destructor
64 || CK == CXCursor_ConversionFunction 77​ || CK == CXCursor_ConversionFunction
65 || CK == CXCursor_FunctionTemplate 78​ || CK == CXCursor_FunctionTemplate
▲ Show 20 Lines • Show All 207 Lines • Show Last 20 Lines