Differential D15520 Diff 41878 libs/editor/simpleiplistvalidator.cpp

Changeset View

Standalone View

libs/editor/simpleiplistvalidator.cpp

This file was added.

1		/*
2		Copyright 2018 Bruce Anderson <banderson19com@san.rr.com>
3
4		This program is free software; you can redistribute it and/or
5		modify it under the terms of the GNU General Public License as
6		published by the Free Software Foundation; either version 2 of
7		the License or (at your option) version 3 or any later version
8		accepted by the membership of KDE e.V. (or its successor approved
9		by the membership of KDE e.V.), which shall act as a proxy
10		defined in Section 14 of version 3 of the license.
11
12		This program is distributed in the hope that it will be useful,
13		but WITHOUT ANY WARRANTY; without even the implied warranty of
14		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		GNU General Public License for more details.
16
17		You should have received a copy of the GNU General Public License
18		along with this program. If not, see <http://www.gnu.org/licenses/>.
19		*/
20
21		#include "simpleiplistvalidator.h"
22
23		#include <QStringList>
24		#include <QVector>
25
26		SimpleIpListValidator::SimpleIpListValidator(QObject *parent,
27		AddressStyle style,
28		AddressType type)
29		: QValidator(parent)
	pinoUnsubmitted Done indentation pino: indentation
30		, m_ipv6Validator(nullptr)
31		, m_ipv4Validator(nullptr)
32		{
33		if (type == Ipv4 \|\| type == Both) {
34		SimpleIpV4AddressValidator::AddressStyle ipv4Style;
35		if (style == Base)
36		ipv4Style = SimpleIpV4AddressValidator::AddressStyle::Base;
37		else if (style == WithCidr)
38		ipv4Style = SimpleIpV4AddressValidator::AddressStyle::WithCidr;
39		else
40		ipv4Style = SimpleIpV4AddressValidator::AddressStyle::WithPort;
41		m_ipv4Validator = new SimpleIpV4AddressValidator(this, ipv4Style);
42		}
43		if (type == Ipv6 \|\| type == Both) {
44		SimpleIpV6AddressValidator::AddressStyle ipv6Style;
45		if (style == Base)
46		ipv6Style = SimpleIpV6AddressValidator::AddressStyle::Base;
47		else if (style == WithCidr)
48		ipv6Style = SimpleIpV6AddressValidator::AddressStyle::WithCidr;
49		else
50		ipv6Style = SimpleIpV6AddressValidator::AddressStyle::WithPort;
51		m_ipv6Validator = new SimpleIpV6AddressValidator(this, ipv6Style);
52		}
53		}
54
55		SimpleIpListValidator::~SimpleIpListValidator()
56		{
57		}
58
59		QValidator::State SimpleIpListValidator::validate(QString &address, int &pos) const
60		{
61		Q_UNUSED(pos)
62
63		// Split the incoming address on commas possibly with spaces on either side
64		QStringList addressList = address.split(QRegularExpression("\\s,\\s"));
65
	pinoUnsubmitted Done once again, simple char split with trim, please; you can use both splitRef + trimmed with QStringRef, so there is almost no waste of memory using a regexp for a simple task like this is that it's way slower than using a simple character as separator pino: once again, simple char split with trim, please; you can use both splitRef + trimmed with…
66		// Use a local variable for position in the validators so it doesn't screw
67		// up the position of the cursor when we return
68		int localPos = 0;
69		int i = 0;
70		QValidator::State result = QValidator::Acceptable;
	pinoUnsubmitted Done the variable `i` is only incremented, and never used pino: the variable `i` is only incremented, and never used
71
72		for (QString &addr : addressList) {
73		QValidator::State ipv4Result = QValidator::Acceptable;
74		QValidator::State ipv6Result = QValidator::Acceptable;
75
76		// If we are starting a new address and all the previous addressess
77		// ar not Acceptable then the previous addresses need to be completed
78		// before a new one is started
79		if (result != QValidator::Acceptable)
80		return QValidator::Invalid;
81
82		// See if it is an IPv4 address. If we are not testing for IPv4
83		// then by definition IPv4 is Invalid
84		if (m_ipv4Validator != nullptr)
85		ipv4Result = m_ipv4Validator->validate(addr, localPos);
86		else
87		ipv4Result = QValidator::Invalid;
88
89		// See if it is an IPv6 address. If we are not testing for IPv6
90		// then by definition IPv6 is Invalid
91		if (m_ipv6Validator != nullptr)
92		ipv6Result = m_ipv6Validator->validate(addr, localPos);
93		else
94		ipv6Result = QValidator::Invalid;
95
96		// If this address is not at least an Intermediate then get out because the list is Invalid
97		if (ipv6Result == QValidator::Invalid && ipv4Result == QValidator::Invalid)
98		return QValidator::Invalid;
99
100		// If either validator judged this address to be Intermediate then that's the best the
101		// final result can be for the whole list. No need to test for Acceptable because
102		// that's the default set on entry and we only downgrade it from there.
103		if (ipv4Result == QValidator::Intermediate \|\| ipv6Result == QValidator::Intermediate)
104		result = QValidator::Intermediate;
105		i++;
106		}
107		return result;
108		}