Differential D15412 Diff 41377 filters/libmsooxml/MsooXmlDrawingReaderTableMethods.h

Changeset View

Standalone View

Context not available.
37	uint m_currentTableRowNumber; //!< row counter, from 0, initialized in read_tbl()	37		uint m_currentTableRowNumber; //!< row counter, from 0, initialized in read_tbl()
38	uint m_currentTableColumnNumber; //!< column counter, from 0, initialized in read_tr()	38		uint m_currentTableColumnNumber; //!< column counter, from 0, initialized in read_tr()
39		39
40	KoTable* m_table;	40		ScopeKoTable m_table = ScopeKoTable(new KoTable);
			staniekUnsubmitted Not Done This is declaration-only header, so better no, otherwise allocation of a new KoTable is added to all places we include the header, e.g. also PptxXmlSlideReader and in the future. staniek: This is declaration-only header, so better no, otherwise allocation of a new KoTable is added…
			anthonyfieroniAuthorUnsubmitted Not Done That isn't a problem, it's initialized at constructor time. anthonyfieroni: That isn't a problem, it's initialized at constructor time.
			staniekUnsubmitted Not Done I know but original code was not called new KoTable for PptxXmlSlideReader, right? staniek: I know but original code was not called new KoTable for PptxXmlSlideReader, right?
41	QString m_currentTableName;	41		QString m_currentTableName;
42		42
43	MSOOXML::DrawingTableStyle* m_tableStyle;	43		MSOOXML::DrawingTableStyle* m_tableStyle;
Context not available.