Differential D15093 Diff 41241 vpn/wireguard/wireguardwidget.h

Changeset View

Standalone View

View Options

vpn/wireguard/wireguardwidget.h

  • This file was added.
1​/*
2​ Copyright 2018 Bruce Anderson <banderson19com@san.rr.com>
3​
4​ This program is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU General Public License as
6​ published by the Free Software Foundation; either version 2 of
7​ the License or (at your option) version 3 or any later version
8​ accepted by the membership of KDE e.V. (or its successor approved
9​ by the membership of KDE e.V.), which shall act as a proxy
10​ defined in Section 14 of version 3 of the license.
11​
12​ This program is distributed in the hope that it will be useful,
13​ but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ GNU General Public License for more details.
16​
17​ You should have received a copy of the GNU General Public License
18​ along with this program. If not, see <http://www.gnu.org/licenses/>.
19​*/
20​
21​#ifndef WIREGUARDWIDGET_H
22​#define WIREGUARDWIDGET_H
23​
24​#include "settingwidget.h"
25​#include "ui_wireguard.h"
26​
27​#include <NetworkManagerQt/VpnSetting>
pinoUnsubmitted
Done

unneeded

pino: unneeded
28​
29​class QUrl;
30​class QLineEdit;
31​
32​class WireGuardSettingWidget : public SettingWidget
33​{
34​ Q_OBJECT
jgrulichUnsubmitted
Done

QUrl and QLineEdit not needed.

jgrulich: QUrl and QLineEdit not needed.
35​public:
36​ explicit WireGuardSettingWidget(const NetworkManager::VpnSetting::Ptr &setting,
37​ QWidget *parent = 0);
38​ ~WireGuardSettingWidget() override;
39​
40​ void loadConfig(const NetworkManager::Setting::Ptr &setting) override;
41​ void loadSecrets(const NetworkManager::Setting::Ptr &setting) override;
42​
jgrulichUnsubmitted
Done

This paramater can be removed if you switch to using our IPv4 and IPv6 validators, also you can completely remove wireguardstrings structure you defined. Even if anything like this would be needed, you basically need it in one class, why not defining it there? If our validators are not enought, then they should be improved so every class using them can benefit from that.

jgrulich: This paramater can be removed if you switch to using our IPv4 and IPv6 validators, also you can…
43​ QVariantMap setting() const override;
44​
45​ virtual bool isValid() const override;
46​
47​private Q_SLOTS:
48​ void showAdvanced();
49​
50​private:
51​ class Private;
52​ Private *d;
53​ void setOrClear(NMStringMap &data, const QLatin1String &key, const QString &value) const;
54​};
55​
56​#endif // WIREGUARDWIDGET_H
pinoUnsubmitted
Done

const & for both the key and value parameters

pino: const & for both the key and value parameters