Differential D8708 Diff 40990 src/view/kateannotationitemdelegate.h

Changeset View

Standalone View

View Options

src/view/kateannotationitemdelegate.h

  • This file was added.
1​/* This file is part of the KDE libraries
2​ Copyright (C) 2002 John Firebaugh <jfirebaugh@kde.org>
3​ Copyright (C) 2001 Anders Lund <anders@alweb.dk>
4​ Copyright (C) 2001 Christoph Cullmann <cullmann@kde.org>
5​ Copyright (C) 2017 Friedrich W. H. Kossebau <kossebau@kde.org>
dhaumannUnsubmitted
Done

Is this copyright really correct?

dhaumann: Is this copyright really correct?
kossebauAuthorUnsubmitted
Not Done

Indeed for the headerthere is no code copied over, well, besides the API being inspired by QAbstractItemDelegate. Reduced to mine.

kossebau: Indeed for the headerthere is no code copied over, well, besides the API being inspired by…
6​
7​ This library is free software; you can redistribute it and/or
8​ modify it under the terms of the GNU Library General Public
9​ License version 2 as published by the Free Software Foundation.
10​
dhaumannUnsubmitted
Done

This is v2 only, I think this should be avoided at all costs... We try to get to v2+... I think you can change this, since this is your work. Even if it's based on others, the work of others is in the other files.

dhaumann: This is v2 only, I think this should be avoided at all costs... We try to get to v2+... I think…
kossebauAuthorUnsubmitted
Not Done

Changed this for the header and also for the source. While the initial code was copied over from kateviewhelpers.cpp (thus the complete license header), comparing it now to the original, I would think it has been that much rewritten to match the delegate API, that it safely can be called a copyrightable product of its own, with no substantial parts of the original left (where not required by the general Qt API).

kossebau: Changed this for the header and also for the source. While the initial code was copied over…
11​ This library is distributed in the hope that it will be useful,
12​ but WITHOUT ANY WARRANTY; without even the implied warranty of
13​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14​ Library General Public License for more details.
15​
16​ You should have received a copy of the GNU Library General Public License
17​ along with this library; see the file COPYING.LIB. If not, write to
18​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19​ Boston, MA 02110-1301, USA.
20​*/
21​
dhaumannUnsubmitted
Done

All keywords starting with __ are reserved, I suggest to remove __ at the beginning and at the end.

dhaumann: All keywords starting with __ are reserved, I suggest to remove __ at the beginning and at the…
kossebauAuthorUnsubmitted
Not Done

Had those to be in line with other headers in that dir. Will do a separate patch to change that for the existing headers then.

kossebau: Had those to be in line with other headers in that dir. Will do a separate patch to change that…
22​#ifndef __KATE_ANNOTATIONITEMDELEGATE_H__
23​#define __KATE_ANNOTATIONITEMDELEGATE_H__
24​
25​#include <ktexteditor/abstractannotationitemdelegate.h>
26​
27​namespace KTextEditor {
28​class ViewPrivate;
29​}
30​class KateViewInternal;
31​
32​class KateAnnotationItemDelegate : public KTextEditor::AbstractAnnotationItemDelegate
33​{
34​ Q_OBJECT
35​
36​public:
37​ explicit KateAnnotationItemDelegate(KateViewInternal *internalView, QObject *parent);
38​ ~KateAnnotationItemDelegate() override;
39​
40​public:
41​ void paint(QPainter *painter, const KTextEditor::StyleOptionAnnotationItem &option,
42​ KTextEditor::AnnotationModel *model, int line) const override;
43​ bool helpEvent(QHelpEvent *event, KTextEditor::View *view,
44​ const KTextEditor::StyleOptionAnnotationItem &option,
45​ KTextEditor::AnnotationModel *model, int line) override;
46​ void hideTooltip(KTextEditor::View *view) override;
47​ QSize sizeHint(const KTextEditor::StyleOptionAnnotationItem &option,
48​ KTextEditor::AnnotationModel *model, int line) const override;
49​ void contextMenuRequested(KTextEditor::View *view, const QPoint &pos,
50​ const KTextEditor::StyleOptionAnnotationItem &option,
51​ KTextEditor::AnnotationModel *model, int line) override;
52​
53​private:
54​ KateViewInternal *m_internalView;
55​ KTextEditor::ViewPrivate *m_view;
56​};
57​
58​#endif