Differential D6513 Diff 40981 tests/khotnewstuff_test.cpp

Changeset View

Standalone View

View Options

tests/khotnewstuff_test.cpp

  • This file was added.
1​/*
2​ This file is part of KNewStuff2.
3​ Copyright (c) 2007 Josef Spillner <spillner@kde.org>
4​ Copyright (c) 2018 Dan Leinir Turthra Jensen <admin@leinir.dk>
5​
6​ This library is free software; you can redistribute it and/or
7​ modify it under the terms of the GNU Lesser General Public
8​ License as published by the Free Software Foundation; either
9​ version 2.1 of the License, or (at your option) any later version.
10​
11​ This library is distributed in the hope that it will be useful,
12​ but WITHOUT ANY WARRANTY; without even the implied warranty of
13​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14​ Lesser General Public License for more details.
15​
16​ You should have received a copy of the GNU Lesser General Public
17​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
18​*/
19​
20​#include "khotnewstuff_test.h"
21​
22​#include <KNSCore/Provider>
23​#include <KNSCore/EntryInternal>
24​#include <KNSCore/Engine>
25​#include "../src/staticxml/staticxmlprovider_p.h"
26​
27​#include <KLocalizedString>
28​
29​#include <QCommandLineParser>
30​#include <QCommandLineOption>
31​#include <QApplication>
32​#include <QDebug>
33​#include <QStandardPaths>
34​#include <QTimer>
35​#include <QQmlApplicationEngine>
36​#include <QQmlContext>
37​
38​#include <QFile>
39​#include <QXmlStreamReader>
40​
41​#include <unistd.h> // for exit()
42​#include <stdio.h> // for stdout
cfeckUnsubmitted
Done

<cstdio>

cfeck: <cstdio>
43​
44​KNewStuff2Test::KNewStuff2Test(const QString &configFile)
45​ : QObject()
46​{
47​ m_messages = new QStandardItemModel(this);
48​ m_configFile = configFile;
49​ m_engine = NULL;
cfeckUnsubmitted
Done

nullptr

cfeck: nullptr
50​ m_testall = false;
51​}
52​
53​void KNewStuff2Test::setTestAll(bool testall)
54​{
55​ m_testall = testall;
56​ emit testAllChanged();
57​}
58​
59​bool KNewStuff2Test::testAll() const
60​{
61​ return m_testall;
62​}
63​
64​void KNewStuff2Test::entryTest()
65​{
66​ addMessage(QString::fromLocal8Bit("-- test kns2 entry class"), QStringLiteral("msg_info"));
cfeckUnsubmitted
Done

Any rationale for using fromLocal8Bit() for fixed strings? If, for whatever reason, you do not want to use QStringLiteral or QLatin1String, please use fromUtf8(). This is what we ship for source files.

cfeck: Any rationale for using `fromLocal8Bit()` for fixed strings? If, for whatever reason, you do…
leinirAuthorUnsubmitted
Not Done

None apart from this being a modified version of an old test which used that function rather than the proper one. Fixed :)

leinir: None apart from this being a modified version of an old test which used that function rather…
67​
68​ QFile f(QString::fromLatin1("%1/testdata/entry.xml").arg(QStringLiteral(KNSSRCDIR)));
69​ if (!f.open(QIODevice::ReadOnly)) {
70​ addMessage(QString::fromLocal8Bit("Error loading entry file: %1").arg(f.fileName()), QStringLiteral("msg_error"));
71​ return;
72​ }
73​
74​ QXmlStreamReader reader(&f);
75​ KNSCore::EntryInternal e;
76​ reader.readNextStartElement(); // Skip the first (the external OCS container)
77​ bool xmlResult = reader.readNextStartElement() && e.setEntryXML(reader);
78​ e.setProviderId(QStringLiteral("test-provider"));
79​
80​ f.close();
81​ if (!xmlResult) {
82​ addMessage(QString::fromLocal8Bit("Error parsing entry file."), QStringLiteral("msg_error"));
83​ return;
84​ }
85​
86​ addMessage(QString::fromLocal8Bit("-- entry->xml test result: %1").arg(e.isValid()), e.isValid() ? QStringLiteral("msg_info") : QStringLiteral("msg_error"));
87​ if (!e.isValid()) {
88​ return;
89​ } else {
90​ QTextStream out(stdout);
91​ out << e.entryXML();
92​ }
93​}
94​
95​void KNewStuff2Test::providerTest()
96​{
97​ addMessage(QString::fromLocal8Bit("-- test kns2 provider class"), QStringLiteral("msg_info"));
98​
99​ QDomDocument doc;
100​ QFile f(QString::fromLatin1("%1/testdata/provider.xml").arg(QStringLiteral(KNSSRCDIR)));
101​ if (!f.open(QIODevice::ReadOnly)) {
102​ addMessage(QString::fromLocal8Bit("Error loading provider file: %1").arg(f.fileName()), QStringLiteral("msg_error"));
103​ return;
104​ }
105​ if (!doc.setContent(&f)) {
106​ addMessage(QString::fromLocal8Bit("Error parsing provider file: %1").arg(f.fileName()), QStringLiteral("msg_error"));
107​ f.close();
108​ return;
109​ }
110​ f.close();
111​
112​ KNSCore::StaticXmlProvider p;
113​ p.setProviderXML(doc.documentElement());
114​
115​ addMessage(QString::fromLocal8Bit("-- xml->provider test result: %1").arg(p.isInitialized()), p.isInitialized()? QStringLiteral("msg_info") : QStringLiteral("msg_error"));
116​
117​// QDomElement pxml = p.providerXML();
118​
119​ // qDebug() << "-- provider->xml test result: " << ph.isValid();
120​
121​// if (!p.isValid()) {
122​// quitTest();
123​// } else {
124​// QTextStream out(stdout);
125​// out << pxml;
126​// }
127​}
128​
129​void KNewStuff2Test::engineTest()
130​{
131​ addMessage(QString::fromLocal8Bit("-- test kns2 engine"), QStringLiteral("msg_info"));
132​
133​ m_engine = new KNSCore::Engine(this);
134​
135​ connect(m_engine,
136​ &KNSCore::Engine::signalError,
137​ this, &KNewStuff2Test::slotEngineError);
138​ connect(m_engine,
139​ &KNSCore::Engine::signalProvidersLoaded,
140​ this, &KNewStuff2Test::slotProvidersLoaded);
141​ connect(m_engine,
142​ &KNSCore::Engine::signalEntriesLoaded,
143​ this, &KNewStuff2Test::slotEntriesLoaded);
144​ connect(m_engine,
145​ &KNSCore::Engine::signalEntryChanged,
146​ this, &KNewStuff2Test::slotInstallationFinished);
147​
148​ bool ret = m_engine->init(m_configFile);
149​
150​ addMessage(QString::fromLocal8Bit("-- engine test result: %1").arg(ret), ret ? QStringLiteral("msg_info") : QStringLiteral("msg_error"));
151​
152​ if (!ret) {
153​ addMessage(QString::fromLocal8Bit("ACHTUNG: you probably need to 'make install' the knsrc file first. Although this is not required anymore, so something went really wrong."), QStringLiteral("msg_warning"));
154​ }
155​ addMessage(QString::fromLocal8Bit("-- initial engine test completed"), QStringLiteral("msg_info"));
156​}
157​
158​void KNewStuff2Test::slotProvidersLoaded()
159​{
160​ addMessage(QString::fromLocal8Bit("SLOT: slotProvidersLoaded"), QStringLiteral("msg_info"));
161​// qDebug() << "-- provider: " << provider->name().representation();
162​
163​ m_engine->reloadEntries();
164​}
165​
166​void KNewStuff2Test::slotEntriesLoaded(const KNSCore::EntryInternal::List &entries)
167​{
168​ addMessage(QString::fromLocal8Bit("SLOT: slotEntriesLoaded. Number of entries %1").arg(entries.count()), QStringLiteral("msg_info"));
169​
170​ if (m_testall) {
171​ addMessage(QString::fromLocal8Bit("-- now, download the entries' previews and payload files"), QStringLiteral("msg_info"));
172​
173​ Q_FOREACH(const KNSCore::EntryInternal& entry, entries) {
174​ addMessage(QString::fromLocal8Bit("-- entry: %1").arg(entry.name()), QStringLiteral("msg_info"));
175​ if (!entry.previewUrl(KNSCore::EntryInternal::PreviewSmall1).isEmpty()) {
176​ m_engine->loadPreview(entry, KNSCore::EntryInternal::PreviewSmall1);
177​ }
178​ if (!entry.payload().isEmpty()) {
179​ m_engine->install(entry);
180​ }
181​ }
182​ }
183​}
184​
185​void KNewStuff2Test::slotInstallationFinished()
186​{
187​ addMessage(QString::fromLocal8Bit("SLOT: slotInstallationFinished"));
188​}
189​
190​void KNewStuff2Test::slotEngineError(const QString& error)
cfeckUnsubmitted
Done

& -> &

cfeck: `& ` -> ` &`
191​{
192​ addMessage(QString::fromLocal8Bit("SLOT: slotEngineError %1").arg(error), QStringLiteral("msg_error"));
193​}
194​
195​QObject *KNewStuff2Test::messages()
196​{
197​ return m_messages;
198​}
199​
200​void KNewStuff2Test::addMessage(const QString &message, const QString &iconName)
201​{
202​ QStandardItem* item = new QStandardItem(message);
cfeckUnsubmitted
Done

* -> *

cfeck: `* ` -> ` *`
203​ item->setData(iconName, Qt::WhatsThisRole);
204​ m_messages->appendRow(item);
205​}
206​
207​KNewStuff2Test *test = nullptr;
208​static const QtMessageHandler QT_DEFAULT_MESSAGE_HANDLER = qInstallMessageHandler(0);
209​void debugOutputHandler(QtMsgType type, const QMessageLogContext &context, const QString &msg)
210​{
211​ if(test) {
cfeckUnsubmitted
Done

Missing space

cfeck: Missing space
212​ test->addMessage(msg, QStringLiteral("msg_info"));
213​ }
214​ // Call the default handler.
215​ (*QT_DEFAULT_MESSAGE_HANDLER)(type, context, msg);
216​}
217​
218​int main(int argc, char **argv)
219​{
220​ QApplication app(argc, argv);
221​
222​ QCommandLineParser* parser = new QCommandLineParser;
cfeckUnsubmitted
Done

* -> *

cfeck: `* ` -> ` *`
223​ parser->addHelpOption();
224​ parser->addOption(QCommandLineOption(QStringLiteral("testall"), i18n("Downloads all previews and payloads")));
225​ parser->addPositionalArgument(QStringLiteral("knsrcfile"), i18n("The KNSRC file you want to use for testing. If none is passed, we will use khotnewstuff_test.knsrc, which must be installed."));
226​ parser->process(app);
227​
228​ if (parser->positionalArguments().count() > 0) {
229​ test = new KNewStuff2Test(parser->positionalArguments().first());
230​ }
231​ else {
cfeckUnsubmitted
Done

again

cfeck: again
232​ test = new KNewStuff2Test(QString::fromLatin1("%1/khotnewstuff_test.knsrc").arg(QStringLiteral(KNSBUILDDIR)));
233​ }
234​ test->setTestAll(parser->isSet(QStringLiteral("testall")));
235​
236​ QQmlApplicationEngine *appengine = new QQmlApplicationEngine();
237​ appengine->rootContext()->setContextProperty(QStringLiteral("testObject"), test);
238​ appengine->load(QUrl::fromLocalFile(QString::fromLatin1("%1/khotnewstuff_test-ui/main.qml").arg(QStringLiteral(KNSSRCDIR))));
239​
240​ // Don't really want to add messages until the tester
241​ // begins to actually request stuff in the UI,
242​ // so let's just install it here
243​ qInstallMessageHandler(debugOutputHandler);
244​
245​ return app.exec();
246​}