Differential D988 Diff 2399 duchain/expressionvisitor.cpp

Changeset View

Standalone View

View Options

duchain/expressionvisitor.cpp

Context not available.
415 } else { 415​ } else {
416 usingDeclaration(node->classConstant, DeclarationPointer()); 416​ usingDeclaration(node->classConstant, DeclarationPointer());
417 } 417​ }
418​ if (!stringForNode(node->classConstant).compare(QLatin1String("class"), Qt::CaseInsensitive)) {
419​ m_result.setType(AbstractType::Ptr(new IntegralType(IntegralType::TypeString)));
mwolffUnsubmitted
Not Done

make it:

if (!stringForNode(node->classConstant).compare(QLatin1String("class"), Qt::CaseInsensitive))

this is much faster as it removes two runtime memory allocations.

mwolff: make it: if (!stringForNode(node->classConstant).compare(QLatin1String("class"), Qt…
420​ }
418 } else { 421​ } else {
419 m_result.setType(AbstractType::Ptr()); 422​ m_result.setType(AbstractType::Ptr());
420 } 423​ }
Context not available.