Differential D13872 Diff 40411 src/qml/ElisaToolButton.qml

Changeset View

Standalone View

View Options

src/qml/ElisaToolButton.qml

  • This file was added.
1​/*
2​ * Copyright 2018 Alexander Stippich <a.stippich@gmx.net>
3​ *
4​ * This library is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU Library General Public
6​ * License as published by the Free Software Foundation; either
7​ * version 3 of the License, or (at your option) any later version.
8​ *
9​ * This library is distributed in the hope that it will be useful,
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ * Library General Public License for more details.
13​ *
14​ * You should have received a copy of the GNU Library General Public License
15​ * along with this library; see the file COPYING.LIB. If not, write to
16​ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ * Boston, MA 02110-1301, USA.
18​ */
19​
20​import QtQuick 2.7
21​import QtQuick.Layouts 1.2
22​import QtGraphicalEffects 1.0
23​import QtQuick.Controls 2.3
24​import org.kde.elisa 1.0
25​
26​ToolButton {
27​ id: elisaToolButton
28​
29​ Keys.onPressed: {
30​ if (event.key === Qt.Key_Space) {
31​ event.accepted = true
32​ }
33​ }
34​
35​ Keys.onReleased: {
36​ if (event.key === Qt.Key_Space) {
37​ event.accepted = true
38​ }
39​ }
40​
41​ onPressed: scale = 0.9
42​ onReleased: scale = 1
43​
44​ contentItem: Image {
45​ anchors.fill: parent
46​
47​ source: elisaToolButton.action.icon.name != "" ? ('image://icon/' + elisaToolButton.action.icon.name) : Qt.resolvedUrl(elisaToolButton.action.icon.source)
48​
49​ sourceSize.width: elisaToolButton.width
50​ sourceSize.height: elisaToolButton.height
51​
52​ fillMode: Image.PreserveAspectFit
53​ opacity: elisaToolButton.action.enabled ? 1 : 0.6
54​ }
55​
56​ background: Rectangle {
57​ color: "transparent"
58​ border.width: hoverArea.containsMouse ? 1 : 0
59​ border.color: myPalette.highlight
60​ }
61​
mgallienUnsubmitted
Not Done

I am definitely not a fan of custom styling. I did it for two progress bar in the media control bar. I still regret it and still believe that was an error.
We are not a big team working on Elisa. All this code increase the maintenance cost. Is it really worth ?

mgallien: I am definitely not a fan of custom styling. I did it for two progress bar in the media control…
astippichAuthorUnsubmitted
Not Done

I would also like to not go this route, but I really haven't found another way (open for suggestions!). I would very much like to convert Elisa to a pure qqc2 application, since qqc1 is officially deprecated, and qqc2 simplifies or actually enables proper HiDPI support, and is said to be lighter on resources. And last but not least the behavior on spacebar push for the standard qqc2 toolbutton component.
Imho this outweighs the disadvantages, but if you disagree, just give me a definite no and I will abandon this diff.

astippich: I would also like to not go this route, but I really haven't found another way (open for…
mgallienUnsubmitted
Not Done

I have spent quite some time thinking about your answer.

I would like to propose to you that we first work on a full port to QQC2 and later look again at the spacebar question. I am not happy to differ in behavior from normal controls (especially in a desktop application). Is this working for you ?
I know that there is also the question about the icons+test buttons. I will have to look at this also but would prefer to have one patch for each solution.

mgallien: I have spent quite some time thinking about your answer. I would like to propose to you that…
astippichAuthorUnsubmitted
Not Done

Fine by me, the spacebar issue is only of secondary importance for me here.
So, would you accept this revision without the spacebar override or would you like to investigate the icon+text issue before?

astippich: Fine by me, the spacebar issue is only of secondary importance for me here. So, would you…
mgallienUnsubmitted
Not Done

I will need more time to understand why we need to override the default behavior. I will be mostly offline until Monday evening. I am really busy with real life. I will try to come with an answer on Monday. I would say that I would prefer not to override the appearance such that any style is still able to make our buttons look native.

mgallien: I will need more time to understand why we need to override the default behavior. I will be…
astippichAuthorUnsubmitted
Not Done

I think I've found the issue. Since you talked about the style, I changed the default style for Elisa, and then the text does not appear. So maybe the qqc2 style is broken. I will do some more investigations

astippich: I think I've found the issue. Since you talked about the style, I changed the default style for…
62​ MouseArea {
63​ id: hoverArea
64​ anchors.fill: parent
65​ hoverEnabled: true
66​ acceptedButtons: Qt.NoButton
67​
68​ Loader {
69​ anchors.fill: parent
70​ active: hoverArea && hoverArea.containsMouse
71​
72​ sourceComponent: ToolTip {
73​ delay: Qt.styleHints.mousePressAndHoldInterval
74​ visible: hoverArea && hoverArea.containsMouse && elisaToolButton.action.text != ""
75​ text: elisaToolButton.action.text
76​
77​ enter: Transition {
78​ NumberAnimation {
79​ properties: "opacity"
80​ easing.type: Easing.InOutQuad
81​ from: 0.0
82​ to: 1.0
83​ duration: 300
84​ }
85​ }
86​ exit: Transition {
87​ NumberAnimation {
88​ properties: "opacity"
89​ easing.type: Easing.InOutQuad
90​ from: 1.0
91​ to: 0.0
92​ duration: 300
93​ }
94​ }
95​
96​ background: Rectangle {
97​ color: myPalette.shadow
98​ radius: elisaTheme.tooltipRadius
99​
100​ layer.enabled: true
101​ layer.effect: DropShadow {
102​ horizontalOffset: elisaTheme.shadowOffset
103​ verticalOffset: elisaTheme.shadowOffset
104​ radius: 8
105​ samples: 17
106​ color: myPalette.shadow
107​ }
108​ }
109​ }
110​ }
111​ }
112​}