Differential D15000 Diff 40217 src/widgets/kpropertiesdialog.cpp

Changeset View

Standalone View

View Options

src/widgets/kpropertiesdialog.cpp

Context not available.
75#include <QPushButton> 75​#include <QPushButton>
76#include <QRegularExpression> 76​#include <QRegularExpression>
77#include <QStandardPaths> 77​#include <QStandardPaths>
78​#include <QStorageInfo>
78#include <QStyle> 79​#include <QStyle>
79#include <QtConcurrentRun> 80​#include <QtConcurrentRun>
80#include <QTextStream> 81​#include <QTextStream>
Context not available.
1157 grid->addWidget(sep, curRow, 0, 1, 3); 1158​ grid->addWidget(sep, curRow, 0, 1, 3);
1158 ++curRow; 1159​ ++curRow;
1159 1160​
1161​ l = new QLabel(i18n("File system:"), d->m_frame);
broulikUnsubmitted
Not Done

Captailize: File System

broulik: Captailize: File System
1162​ grid->addWidget(l, curRow, 0, Qt::AlignRight);
1163​ l->setTextInteractionFlags(Qt::TextSelectableByMouse | Qt::TextSelectableByKeyboard);
1164​
broulikUnsubmitted
Not Done

This leaks, you can probably create it on the stack:

QStorageInfo storageInfo(...);

Also, shouldn't you pass url.toLocalFile() instead of hardcoded /?
Also, move it in the isLocal check as QStorageInfo can only work on paths, not URLs.
Also, what about KMountPoint::mountType()?

broulik: This leaks, you can probably create it on the stack: ``` QStorageInfo storageInfo(...); ```…
1165​ QStorageInfo *fileSystem = new QStorageInfo(QLatin1String("/"));
1166​
1167​ l = new QLabel(d->m_frame);
1168​ grid->addWidget(l, curRow++, 2);
1169​ l->setTextInteractionFlags(Qt::TextSelectableByMouse | Qt::TextSelectableByKeyboard);
broulikUnsubmitted
Not Done

QString::fromLatin1?

broulik: `QString::fromLatin1`?
1170​ l->setText(QString(fileSystem->fileSystemType()));
1171​
1160 if (isLocal) { 1172​ if (isLocal) {
1161 KMountPoint::Ptr mp = KMountPoint::currentMountPoints().findByPath(url.toLocalFile()); 1173​ KMountPoint::Ptr mp = KMountPoint::currentMountPoints().findByPath(url.toLocalFile());
1162 if (mp && mp->mountPoint() != QLatin1String("/")) { 1174​ if (mp && mp->mountPoint() != QLatin1String("/")) {
Context not available.