Differential D14962 Diff 40166 src/backends/julia/juliaserver/juliaserver.cpp

Changeset View

Standalone View

View Options

src/backends/julia/juliaserver/juliaserver.cpp

Show All 37 Lines
38 38​
39JuliaServer::~JuliaServer() 39​JuliaServer::~JuliaServer()
40{ 40​{
41 jl_atexit_hook(0); 41​ jl_atexit_hook(0);
42} 42​}
43 43​
44void JuliaServer::login(const QString &path) const 44​void JuliaServer::login(const QString &path) const
45{ 45​{
46#if JULIA_VERSION_MINOR > 5 46​#if QT_VERSION_CHECK(JULIA_VERSION_MAJOR, JULIA_VERSION_MINOR, 0) >= QT_VERSION_CHECK(0, 6, 0)
pinoUnsubmitted
Done

This can be simplified, and made it future-proof using QT_VERSION_CHECK:

#if QT_VERSION_CHECK(JULIA_VERSION_MAJOR, JULIA_VERSION_MINOR, 0) >= QT_VERSION_CHECK(0, 5, 0)
pino: This can be simplified, and made it future-proof using QT_VERSION_CHECK: lang=c++ #if…
47 Q_UNUSED(path) 47​ Q_UNUSED(path)
48 jl_init(); 48​ jl_init();
49#else 49​#else
50 QString dir_path = QFileInfo(path).dir().absolutePath(); 50​ QString dir_path = QFileInfo(path).dir().absolutePath();
51 jl_init(dir_path.toLatin1().constData()); 51​ jl_init(dir_path.toLatin1().constData());
52#endif 52​#endif
53} 53​}
54 54​
▲ Show 20 Lines • Show All 174 Lines • Show Last 20 Lines