Differential D14604 Diff 39803 runners/remotecommands/remotecommandsrunner.cpp

Changeset View

Standalone View

View Options

runners/remotecommands/remotecommandsrunner.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright © 2018 Nicolas Fella <nicolas.fella@gmx.de> *
3​ * *
4​ * This program is free software; you can redistribute it and/or *
5​ * modify it under the terms of the GNU General Public License as *
6​ * published by the Free Software Foundation; either version 2 of *
7​ * the License or (at your option) version 3 or any later version *
8​ * accepted by the membership of KDE e.V. (or its successor approved *
9​ * by the membership of KDE e.V.), which shall act as a proxy *
10​ * defined in Section 14 of version 3 of the license. *
11​ * *
12​ * This program is distributed in the hope that it will be useful, *
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
15​ * GNU General Public License for more details. *
16​ * *
17​ * You should have received a copy of the GNU General Public License *
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>. *
19​ ***************************************************************************/
20​
21​#include "remotecommandsrunner.h"
22​
23​#include <QIcon>
24​#include <QDebug>
25​
26​#include "interfaces/dbusinterfaces.h"
27​
28​K_EXPORT_PLASMA_RUNNER(installer, RemoteCommandsRunner)
29​
30​RemoteCommandsRunner::RemoteCommandsRunner(QObject *parent, const QVariantList &args)
31​ : Plasma::AbstractRunner(parent, args)
32​ , m_daemonInterface(new DaemonDbusInterface)
33​{
34​ Q_UNUSED(args)
35​
36​ setObjectName(QStringLiteral("Run Commands"));
37​ setPriority(AbstractRunner::HighestPriority);
38​}
39​
40​RemoteCommandsRunner::~RemoteCommandsRunner()
41​{
42​}
43​
44​void RemoteCommandsRunner::match(Plasma::RunnerContext &context)
45​{
46​ QDBusReply<QStringList> devicesReply = m_daemonInterface.devices(true, true);
47​
48​ if (devicesReply.isValid()) {
49​
50​ for (const QString& deviceId : devicesReply.value()) {
51​
apolUnsubmitted
Not Done

const &,
also this is a blocking dbus call. It would make sense to use the async API.

apol: const &, also this is a blocking dbus call. It would make sense to use the async API.
davidedmundsonUnsubmitted
Not Done

you're in your own thread here. Being async doesn't really gain you too much.

davidedmundson: you're in your own thread here. Being async doesn't really gain you too much.
apolUnsubmitted
Not Done

Are all KRunner plugins in a separate thread?

apol: Are all KRunner plugins in a separate thread?
nicolasfellaAuthorUnsubmitted
Not Done

If you really want it async I'll do it, it's your call

nicolasfella: If you really want it async I'll do it, it's your call
52​ DeviceDbusInterface deviceInterface(deviceId, this);
53​
54​ if(!deviceInterface.hasPlugin("kdeconnect_remotecommands")) {
55​ continue;
56​ }
57​
58​ RemoteCommandsDbusInterface remoteCommandsInterface(deviceId, this);
59​
60​ const auto cmds = QJsonDocument::fromJson(remoteCommandsInterface.commands()).object();
61​
62​ for (auto it = cmds.constBegin(), itEnd = cmds.constEnd(); it!=itEnd; ++it) {
63​ const QJsonObject cont = it->toObject();
64​
65​ const QString deviceName = deviceInterface.name();
66​ const QString commandName = cont.value(QStringLiteral("name")).toString();
apolUnsubmitted
Done

const, and below.

apol: const, and below.
67​
68​ if (deviceName.contains(context.query(), Qt::CaseInsensitive) || commandName.contains(context.query(), Qt::CaseInsensitive)) {
69​
70​ Plasma::QueryMatch match(this);
71​ match.setType(Plasma::QueryMatch::PossibleMatch);
72​ match.setId(it.key());
73​ match.setIcon(QIcon::fromTheme("kdeconnect"));
74​ match.setText(deviceName + ": " + commandName);
75​ match.setSubtext(cont.value(QStringLiteral("command")).toString());
76​ match.setData(deviceId + "$" + it.key());
77​ context.addMatch(match);
78​ }
79​ }
80​ }
81​ }
82​}
83​
84​void RemoteCommandsRunner::run(const Plasma::RunnerContext &/*context*/, const Plasma::QueryMatch &match)
85​{
86​ RemoteCommandsDbusInterface remoteCommandsInterface(match.data().toString().split("$")[0], this);
87​
88​ remoteCommandsInterface.triggerCommand(match.data().toString().split("$")[1]);
89​}
90​
91​#include "remotecommandsrunner.moc"