Differential D14288 Diff 39668 plugins/clazy/problemmodel.cpp

Changeset View

Standalone View

View Options

plugins/clazy/problemmodel.cpp

  • This file was added.
1​/* This file is part of KDevelop
2​
3​ Copyright 2018 Anton Anikin <anton@anikin.xyz>
4​
5​ This program is free software; you can redistribute it and/or
6​ modify it under the terms of the GNU General Public
7​ License as published by the Free Software Foundation; either
8​ version 2 of the License, or (at your option) any later version.
9​
10​ This program is distributed in the hope that it will be useful,
11​ but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13​ General Public License for more details.
14​
15​ You should have received a copy of the GNU General Public License
16​ along with this program; see the file COPYING. If not, write to
17​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18​ Boston, MA 02110-1301, USA.
19​*/
20​
21​#include "problemmodel.h"
22​
23​#include "plugin.h"
24​#include "utils.h"
25​
26​#include <interfaces/icore.h>
27​#include <interfaces/ilanguagecontroller.h>
28​#include <shell/problemmodelset.h>
29​
30​#include <KLocalizedString>
31​
32​namespace Clazy
33​{
34​
35​inline KDevelop::ProblemModelSet* problemModelSet()
36​{
37​ return KDevelop::ICore::self()->languageController()->problemModelSet();
38​}
39​
40​inline QString problemModelId()
41​{
42​ return QStringLiteral("clazy");
43​}
44​
45​ProblemModel::ProblemModel(Plugin* plugin)
46​ : KDevelop::ProblemModel(plugin)
47​ , m_plugin(plugin)
48​ , m_project(nullptr)
49​{
50​ setFeatures(CanDoFullUpdate |
51​ ScopeFilter |
52​ SeverityFilter |
53​ Grouping |
54​ CanByPassScopeFilter|
55​ ShowSource);
56​
57​ reset();
58​
59​ problemModelSet()->addModel(problemModelId(), i18n("Clazy"), this);
60​}
61​
62​ProblemModel::~ProblemModel()
63​{
64​ problemModelSet()->removeModel(problemModelId());
65​}
66​
67​KDevelop::IProject* ProblemModel::project() const
68​{
69​ return m_project;
70​}
71​
72​void ProblemModel::addProblems(const QVector<KDevelop::IProblem::Ptr>& problems)
73​{
74​ static int maxLength = 0;
75​
76​ if (m_problems.isEmpty()) {
77​ maxLength = 0;
78​ }
79​
80​ m_problems.append(problems);
81​ for (auto p : problems) {
82​ addProblem(p);
kossebauUnsubmitted
Done

auto& o, no need to create another non-trivial pointer object copy.

kossebau: `auto& o`, no need to create another non-trivial pointer object copy.
83​
kossebauUnsubmitted
Done

What I mean what I prefer is this:

for (auto& problem : qAsConst(m_problems)) {

Reason is that KDevelop::IProblem::Ptr is not just a plain raw pointer, but a slightly more complex datatype with a non-trivial copy constructor, which would be used in case of just auto problem).
By using a reference to the Ptr object we spare the invocations of that copy constructor call per loop step (cmp. QExplicitlySharedDataPointer(const QExplicitlySharedDataPointer<X> &o) code), which saves again some cpy cycles. Not a big gain here indeed, but keeping this as pattern ensures that code in other places which are more a hotpath default to the less expensive variant.
(BTW, clazy warns about that in the range-loop check :P )

kossebau: What I mean what I prefer is this: ``` for (auto& problem : qAsConst(m_problems)) { ``` Reason…
84​ // This performs adjusting of columns width in the ProblemsView
85​ if (maxLength < p->description().length()) {
86​ maxLength = p->description().length();
87​ setProblems(m_problems);
88​ break;
89​ }
90​ }
91​}
92​
93​void ProblemModel::setProblems()
94​{
95​ setProblems(m_problems);
96​}
97​
98​void ProblemModel::reset()
99​{
100​ reset(nullptr, QString());
101​}
102​
103​void ProblemModel::reset(KDevelop::IProject* project, const QString& path)
104​{
105​ m_project = project;
106​ m_path = path;
kossebauUnsubmitted
Done

same auto& problem

kossebau: same auto& problem
107​
108​ clearProblems();
109​ m_problems.clear();
110​
111​ QString tooltip;
112​ if (m_project) {
113​ tooltip = i18nc("@info:tooltip %1 is the path of the file", "Re-run last Clazy analysis (%1)", prettyPathName(m_path));
114​ } else {
115​ tooltip = i18nc("@info:tooltip", "Re-run last Clazy analysis");
pinoUnsubmitted
Done

String puzzle -- just use two strings:

QString tooltip;
if (m_project) {
  tooltip = i18nc("@info:tooltip %1 is the path of the file", "Re-run last Clazy analysis (%1)", prettyPathName(m_path));
} else {
  tooltip = i18nc("@info:tooltip", "Re-run last Clazy analysis");
}

Also tooltips do not get title capitalization.

pino: String puzzle -- just use two strings: lang=c++ QString tooltip; if (m_project) {…
116​ }
117​
118​ setFullUpdateTooltip(tooltip);
119​}
120​
121​void ProblemModel::show()
122​{
123​ problemModelSet()->showModel(problemModelId());
124​}
125​
126​void ProblemModel::forceFullUpdate()
127​{
128​ if (m_project && !m_plugin->isRunning()) {
129​ m_plugin->runClazy(m_project, m_path);
130​ }
131​}
132​
133​}