Differential D14756 Diff 39619 kmymoney/plugins/xml/xmlstorage.cpp

Changeset View

Standalone View

View Options

kmymoney/plugins/xml/xmlstorage.cpp

Context not available.
27#include <QFile> 27​#include <QFile>
28#include <QTemporaryFile> 28​#include <QTemporaryFile>
29#include <QFileDialog> 29​#include <QFileDialog>
30​#include <QRegularExpression>
31​#include <QBuffer>
30 32​
31// ---------------------------------------------------------------------------- 33​// ----------------------------------------------------------------------------
32// KDE Includes 34​// KDE Includes
Context not available.
55#include "kmymoneyutils.h" 57​#include "kmymoneyutils.h"
56#include "kgpgfile.h" 58​#include "kgpgfile.h"
57#include "kgpgkeyselectiondlg.h" 59​#include "kgpgkeyselectiondlg.h"
60​#include "xmlstorageupdater.h"
58#include "kmymoneyenums.h" 61​#include "kmymoneyenums.h"
59 62​
60using namespace Icons; 63​using namespace Icons;
Context not available.
185 // we know. For now, we support our own XML format and 188​ // we know. For now, we support our own XML format and
186 // GNUCash XML format. If the file is smaller, then it 189​ // GNUCash XML format. If the file is smaller, then it
187 // contains no valid data and we reject it anyway. 190​ // contains no valid data and we reject it anyway.
188 qbaFileHeader.resize(70); 191​ qbaFileHeader.resize(220);
189 if (qfile->read(qbaFileHeader.data(), 70) != 70) 192​ if (qfile->read(qbaFileHeader.data(), 220) != 220)
190 throw MYMONEYEXCEPTION(sFileToShort); 193​ throw MYMONEYEXCEPTION(sFileToShort);
191 194​
192 if (haveAt) 195​ if (haveAt)
193 qfile->seek(0); 196​ qfile->seek(0);
194 else 197​ else
195 ungetString(qfile, qbaFileHeader.data(), 70); 198​ ungetString(qfile, qbaFileHeader.data(), 220);
196 199​
197 QRegExp kmyexp("<!DOCTYPE KMYMONEY-FILE>"); 200​ auto re = QRegularExpression(QStringLiteral("<!DOCTYPE KMYMONEY-FILE>"));
198 QByteArray txt(qbaFileHeader, 70); 201​ auto match = re.match(qbaFileHeader);
199 if (kmyexp.indexIn(txt) == -1) 202​ if (!match.hasMatch())
200 return nullptr; 203​ return nullptr;
201 204​
205​ auto fileVersion = 0;
206​ auto fileFixVersion = 0;
207​ re = QRegularExpression(QStringLiteral("VERSION id=\"(?<version>\\d+)\""));
208​ match = re.match(qbaFileHeader);
209​ if (match.hasMatch())
210​ fileVersion = match.captured(1).toInt();
211​
212​ re = QRegularExpression(QStringLiteral("FIXVERSION id=\"(?<version>\\d+)\""));
213​ match = re.match(qbaFileHeader);
214​ if (match.hasMatch())
215​ fileFixVersion = match.captured(1).toInt();
216​
217​ QByteArray XMLByteArray;
218​ if (fileVersion <= 1 && fileFixVersion < 5) {
tbaumgartUnsubmitted
Not Done

These integers should be kept as #define's somewhere and must not be hardcoded

tbaumgart: These integers should be kept as #define's somewhere and must not be hardcoded
wojnilowiczAuthorUnsubmitted
Not Done

I thought about it too but I wan't to do that later.

wojnilowicz: I thought about it too but I wan't to do that later.
219​ KMessageBox::information(nullptr, i18n("Your storage version is %1 and fix version is %2.\n"
220​ "It will be upgraded to version %3 and fix version %4.\n"
221​ "That means you won't be able to use it in previous versions of KMyMoney.\n"
222​ "This operation won't modify your storage until you save it.", fileVersion, fileFixVersion, 1, 5),
223​ i18n("Storage version upgrade"));
224​ XMLByteArray = qfile->readAll();
225​ qfile->close();
226​ delete qfile;
227​ qfile = new QBuffer(&XMLByteArray);
228​ qfile->open(QIODevice::ReadWrite);
229​
230​ if (!XMLStorageUpdater::updateFile(qfile)) {
231​ qfile->close();
232​ delete qfile;
233​ return nullptr;
234​ }
235​ qfile->seek(0);
236​ } else if (fileVersion >= 1 && fileFixVersion > 5) {
237​ KMessageBox::information(nullptr, i18n("Your storage version is %1 and fix version is %2.\n"
238​ "The highest supported version is %3 and fix version %4.\n"
239​ "That means your storage has been saved in newer KMyMoney version.\n"
240​ "It's incompativle with with this version of KMyMoney.", fileVersion, fileFixVersion, 1, 5),
241​ i18n("Incopatible storage version"));
242​ qfile->close();
243​ delete qfile;
244​ return nullptr;
245​ }
246​
202 // attach the storage before reading the file, since the online 247​ // attach the storage before reading the file, since the online
203 // onlineJobAdministration object queries the engine during 248​ // onlineJobAdministration object queries the engine during
204 // loading. 249​ // loading.
Context not available.