Differential D14755 Diff 39486 lib/redeyereduction/redeyereductionwidget.ui

Changeset View

Standalone View

View Options

lib/redeyereduction/redeyereductionwidget.ui

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Line(s)19 <widget class="QWidget" name="mainPage">
56 <zorder>label</zorder> 56​ <zorder>label</zorder>
57 <zorder>diameterSlider</zorder> 57​ <zorder>diameterSlider</zorder>
58 </widget> 58​ </widget>
59 <widget class="QWidget" name="notSetPage"> 59​ <widget class="QWidget" name="notSetPage">
60 <layout class="QHBoxLayout" name="horizontalLayout_3"> 60​ <layout class="QHBoxLayout" name="horizontalLayout_3">
61 <item> 61​ <item>
62 <widget class="QLabel" name="label_2"> 62​ <widget class="QLabel" name="label_2">
63 <property name="text"> 63​ <property name="text">
64 <string>Click on the red eye you want to fix</string> 64​ <string>Click on the red eye to fix, double-click to apply immediately</string>
ngrahamUnsubmitted
Done

This is a comma splice.

Aside from that, how about phrasing this in a slightly different way that makes it clearer which clicks do what? I'm thinking about something like this:

"Click on the red eye to correct it and then adjust the size of the correction; double-click to correct it immediately."

...But maybe that's too long?

ngraham: This is a [[https://en.wikipedia.org/wiki/Comma_splice | comma splice ]]. Aside from that, how…
rkflxAuthorUnsubmitted
Done

This is a comma splice.

Ah, thanks for the hint.

...But maybe that's too long?

Obviously too long ;) How about:

"Click on [a] red eye to correct it. Double-click to correct it immediately."

rkflx: > This is a comma splice. Ah, thanks for the hint. > ...But maybe that's too long? Obviously…
ngrahamUnsubmitted
Done

I think with that, the distinction between "correct it" and "correct it immediately" is not obvious. How about:

"Single-click to correct a red eye interactively; double-click to correct it immediately."

ngraham: I think with that, the distinction between "correct it" and "correct it immediately" is not…
rkflxAuthorUnsubmitted
Done

Okay, let's step back a bit because I think it's getting more convoluted with each iteration. Problems with the last proposal:

  • You can also double click after you corrected interactively, and double-clicking is already kind of interactive, there is no real distinction between both modes.
  • With that wording users don't know where to click anymore.
  • "Single-click to correct" implies the fix will be applied at once, but you actually have to confirm the correction later on.

Basically I wanna convey two points:

  • You have to click on an eye at least once (because it's not yet automatic).
  • Besides clicking on "OK" (which I plan to rename to "Reduce Red Eye" in a later patch), there is also the option to double-click.

Let's keep it short and sweet:

Click on a red eye and choose a size, or double-click to confirm instantly.

The operator precedence between "and" and "or" is a bit vague and ambiguous on purpose, so it nicely fits both cases. Would this be acceptable?

rkflx: Okay, let's step back a bit because I think it's getting more convoluted with each iteration.
ngrahamUnsubmitted
Not Done

Sorry for the delayed response. Very busy at Akademy this week. I think your wording is almost perfect, but could we change "confirm" to "correct"? "Confirm" implies a thing to be confirmed, but that thing has not already been established.

ngraham: Sorry for the delayed response. Very busy at Akademy this week. I think your wording is almost…
65 </property> 65​ </property>
66 </widget> 66​ </widget>
67 </item> 67​ </item>
68 </layout> 68​ </layout>
69 </widget> 69​ </widget>
70 </widget> 70​ </widget>
71 </item> 71​ </item>
72 <item> 72​ <item>
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines