Differential D14649 Diff 39188 libdiscover/backends/FwupdBackend/FwupdBackend.h

Changeset View

Standalone View

View Options

libdiscover/backends/FwupdBackend/FwupdBackend.h

Context not available.
81 bool refreshRemotes(uint cacheAge); 81​ bool refreshRemotes(uint cacheAge);
82 bool refreshRemote(FwupdRemote *remote, uint cacheAge); 82​ bool refreshRemote(FwupdRemote *remote, uint cacheAge);
83 const QUrl cacheFile(const QString &kind, const QFileInfo &resource); 83​ const QUrl cacheFile(const QString &kind, const QFileInfo &resource);
84 FwupdResource * createDevice(FwupdDevice *device); 84​ FwupdResource * createDevice(FwupdDevice *dev);
apolUnsubmitted
Not Done

Why did you change all device to dev?

apol: Why did you change all `device` to `dev`?
abhijeet2096AuthorUnsubmitted
Not Done

I was using "rel" for releases, so for uniformity, I changed the devices to "dev".

abhijeet2096: I was using "rel" for releases, so for uniformity, I changed the devices to "dev".
apolUnsubmitted
Not Done

Not a big fan, please revert. If anything change rel to release.

apol: Not a big fan, please revert. If anything change `rel` to `release`.
abhijeet2096AuthorUnsubmitted
Not Done

okay sure!

abhijeet2096: okay sure!
ngrahamUnsubmitted
Not Done

How about instead using "releases" for "releases?" :) Short variable names are a false economy.

ngraham: How about instead using "releases" for "releases?" :) Short variable names are a false economy.
85 FwupdResource * createRelease(FwupdDevice *device); 85​ FwupdResource * createRelease(FwupdDevice *dev);
86 FwupdResource * createApp(FwupdDevice *device); 86​ FwupdResource * createApp(FwupdDevice *dev);
87 QByteArray getChecksum(const QUrl filename, QCryptographicHash::Algorithm hashAlgorithm); 87​ QByteArray getChecksum(const QUrl filename, QCryptographicHash::Algorithm hashAlgorithm);
88 QString buildDeviceID(FwupdDevice* device); 88​ QString buildDeviceID(FwupdDevice* dev);
89 void addUpdates(); 89​ void addUpdates();
90 void addResourceToList(FwupdResource *res); 90​ void addResourceToList(FwupdResource *res);
91 void addHistoricalUpdates(); 91​ void addHistoricalUpdates();
92 void setReleaseDetails(FwupdResource *res, FwupdRelease *rel); 92​ void setReleaseDetails(FwupdResource *res, FwupdRelease *rel);
93 void setDeviceDetails(FwupdResource *res, FwupdDevice *device); 93​ void setDeviceDetails(FwupdResource *res, FwupdDevice *dev);
94 void handleError(GError **perror); 94​ void handleError(GError **perror);
95 QSet<AbstractResource*> getAllUpdates(); 95​ QSet<AbstractResource*> getAllUpdates();
96 QString getAppName(QString ID); 96​ QString getAppName(QString ID);
Context not available.