Differential D14631 Diff 39137 src/widgets/rename/batchrenamedialog.cpp

Changeset View

Standalone View

View Options

src/widgets/rename/batchrenamedialog.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright (C) 2018 by Emirald Mateli <aldo.mateli@gmail.com> *
3​ * *
4​ * This program is free software; you can redistribute it and/or modify *
5​ * it under the terms of the GNU General Public License as published by *
6​ * the Free Software Foundation; either version 2 of the License, or *
7​ * (at your option) any later version. *
8​ * *
9​ * This program is distributed in the hope that it will be useful, *
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12​ * GNU General Public License for more details. *
13​ * *
14​ * You should have received a copy of the GNU General Public License *
15​ * along with this program; if not, write to the *
16​ * Free Software Foundation, Inc., *
17​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
18​ ***************************************************************************/
19​
20​#include "batchrenamedialog.h"
21​#include "filenameutils.h"
22​#include "batchrenamevar.h"
23​
24​#include <QDialogButtonBox>
25​#include <QDir>
26​#include <QLabel>
27​#include <QLineEdit>
28​#include <QPushButton>
29​#include <QHeaderView>
30​#include <QPushButton>
31​#include <QHBoxLayout>
32​#include <QVBoxLayout>
33​
34​#include <KGuiItem>
35​#include <KI18n/KLocalizedString>
36​#include <KIOCore/KIO/Job>
37​#include <KIOCore/KIO/CopyJob>
38​#include <KIOWidgets/KIO/FileUndoManager>
39​#include <KJobWidgets/KJobWidgets>
dfaureUnsubmitted
Done

Remove all the framework prefixes. E.g. this should be <KIO/Job>.

This way, it fails to find the include if the include path (which comes from linking to an imported target, in cmake) for the dependency is missing.

dfaure: Remove all the framework prefixes. E.g. this should be <KIO/Job>. This way, it fails to find…
40​#include <QtWidgets/QMenu>
41​#include <QtGui/QActionEvent>
mlaurentUnsubmitted
Done

remove QtWidget

mlaurent: remove QtWidget
42​
mlaurentUnsubmitted
Done

remove QtGui prefix

mlaurent: remove QtGui prefix
43​using namespace KIO;
44​
dfaureUnsubmitted
Not Done

remove KI18n prefix, this isn't a namespaced header

dfaure: remove KI18n prefix, this isn't a namespaced header
45​namespace KIO
46​{
47​
mlaurentUnsubmitted
Done

new line before ": QDialog"

mlaurent: new line before ": QDialog"
48​BatchRenameDialog::BatchRenameDialog(QWidget *parent, const KFileItemList &items) : QDialog(parent)
49​{
mlaurentUnsubmitted
Done

new QVBoxLayout(this);
and remove setLayout(mainLayout);

mlaurent: new QVBoxLayout(this); and remove setLayout(mainLayout);
50​ auto *mainLayout = new QVBoxLayout();
51​ setWindowTitle(i18nc("@title:window", "Rename Items"));
52​ setMinimumWidth(500);
53​ setLayout(mainLayout);
54​
dfaureUnsubmitted
Not Done

This is very unusual. Any reason why the public class isn't the one that inherits from QDialog?

This would allow the caller to call show(), instead of show() happening automatically. Just for consistency with all other dialogs.

dfaure: This is very unusual. Any reason why the public class isn't the one that inherits from QDialog?
55​ model = new BatchRenameDialogModel(this, items);
56​
57​ m_timer = new QTimer(this);
58​ m_timer->setSingleShot(true);
59​ m_timer->setInterval(500);
60​ connect(m_timer, &QTimer::timeout, this, &BatchRenameDialog::updatePreview);
61​
mlaurentUnsubmitted
Done

add parent ?

mlaurent: add parent ?
62​ m_previewTable = new QTableView();
63​ m_previewTable->setModel(model);
64​ m_previewTable->horizontalHeader()->setStretchLastSection(true);
65​ m_previewTable->horizontalHeader()->setSectionResizeMode(QHeaderView::ResizeToContents);
66​ m_previewTable->verticalHeader()->hide();
67​ m_previewTable->setColumnHidden(BatchRenameDialogModel::Valid, true);
68​ m_previewTable->setSelectionBehavior(QAbstractItemView::SelectRows);
69​ mainLayout->addWidget(m_previewTable);
70​
71​ const auto valueChangedIntCallback = [this](int) { onEditValueChanged(QString()); };
72​
73​ // Create tab widget
74​ m_tabs = new QTabWidget(this);
75​
76​ QWidget *tabRenameSequential = new QWidget(m_tabs);
77​ auto layoutRenameSequential = new QVBoxLayout;
dfaureUnsubmitted
Not Done

QVector

dfaure: QVector
78​ layoutRenameSequential->setAlignment(Qt::AlignTop);
79​ tabRenameSequential->setLayout(layoutRenameSequential);
80​ m_tabs->addTab(tabRenameSequential, i18nc("@label", "Rename"));
81​
82​ QWidget *tabRenameFindReplace = new QWidget(m_tabs);
83​ m_tabs->addTab(tabRenameFindReplace, i18nc("@label", "Find && Replace"));
84​ auto layoutRenameFindReplace = new QVBoxLayout;
85​ layoutRenameFindReplace->setAlignment(Qt::AlignTop);
86​ tabRenameFindReplace->setLayout(layoutRenameFindReplace);
87​
88​ QWidget *tabNewNameFromMatches = new QWidget(m_tabs);
89​ m_tabs->addTab(tabNewNameFromMatches, i18nc("@label", "Capture groups"));
90​ auto layoutNewNameFromMatches = new QVBoxLayout;
91​ layoutNewNameFromMatches->setAlignment(Qt::AlignTop);
92​ tabNewNameFromMatches->setLayout(layoutNewNameFromMatches);
93​
94​ mainLayout->addWidget(m_tabs);
95​
96​ // Rename Sequential
97​ m_macroReplaceEdit = createLineEdit();
98​ m_macroReplaceEdit->setText(i18nc("@label:button", "New Name {index}"));
99​
100​ createInsertTokenMenu();
101​ auto btnInsertToken = new QPushButton(this);
102​ btnInsertToken->setText(i18nc("@label", "Insert token"));
103​ btnInsertToken->setIcon(QIcon::fromTheme(QStringLiteral("list-add")));
104​ connect(btnInsertToken, &QPushButton::clicked, [this]() { m_insertTokenMenu->exec(QCursor::pos()); });
105​
106​ auto layoutEditInsertToken = new QHBoxLayout(this);
107​ layoutEditInsertToken->addWidget(m_macroReplaceEdit);
108​ layoutEditInsertToken->addWidget(btnInsertToken);
109​
110​ layoutRenameSequential->addWidget(new QLabel(i18ncp("@label:textbox", "Rename the %1 selected item to:",
111​ "Rename the %1 selected items to:", items.count()), this));
112​ layoutRenameSequential->addLayout(layoutEditInsertToken);
113​
114​
115​ m_IdStartFrom = new QSpinBox(this);
116​ m_IdStartFrom->setKeyboardTracking(true);
117​ connect(m_IdStartFrom, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), valueChangedIntCallback);
118​ m_IdStartFrom->setRange(1, 1000000);
119​
120​ layoutRenameSequential->addWidget(
121​ new QLabel(i18nc("@info", "{index} will be replaced by ascending numbers starting with:"), this));
122​ layoutRenameSequential->addWidget(m_IdStartFrom);
123​
124​ m_IdPaddingLength = new QSpinBox(this);
125​ m_IdPaddingLength->setKeyboardTracking(true);
126​ connect(m_IdPaddingLength, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), valueChangedIntCallback);
127​ m_IdPaddingLength->setRange(1, 1000000);
128​
129​ layoutRenameSequential->addWidget(new QLabel(i18nc("@info", "Pad numbers using a length of:"), this));
130​ layoutRenameSequential->addWidget(m_IdPaddingLength);
131​
132​ // Find & Replace tab
133​ m_findEdit = createLineEdit();
134​ m_replaceEdit = createLineEdit();
135​ m_useRegex = new QCheckBox(i18nc("@label", "Use Regular Expressions"), this);
136​ connect(m_useRegex, &QCheckBox::stateChanged, valueChangedIntCallback);
137​ m_caseInsensitive = new QCheckBox(i18nc("@label", "Case insensitive"), this);
138​ connect(m_caseInsensitive, &QCheckBox::stateChanged, valueChangedIntCallback);
139​
140​ layoutRenameFindReplace->addWidget(new QLabel(i18nc("@label", "Find:"), this));
141​ layoutRenameFindReplace->addWidget(m_findEdit);
142​
143​ layoutRenameFindReplace->addWidget(new QLabel(i18nc("@label", "Replace:"), this));
144​ layoutRenameFindReplace->addWidget(m_replaceEdit);
145​
146​ layoutRenameFindReplace->addItem(new QSpacerItem(0, 10));
147​ layoutRenameFindReplace->addWidget(m_useRegex);
148​ layoutRenameFindReplace->addWidget(m_caseInsensitive);
149​
150​ // New name from matches
151​ m_patternFind = createLineEdit();
152​ m_newNameFromMatches = createLineEdit();
153​
154​ layoutNewNameFromMatches->addWidget(new QLabel(i18nc("@label", "Find patterns:"), this));
155​ layoutNewNameFromMatches->addWidget(m_patternFind);
156​
157​ layoutNewNameFromMatches->addWidget(new QLabel(i18nc("@label", "New name:"), this));
158​ layoutNewNameFromMatches->addWidget(m_newNameFromMatches);
159​
160​ m_capturedGroupsText = new QLabel(this);
161​ m_capturedGroupsText->setWordWrap(true);
162​ layoutNewNameFromMatches->addWidget(m_capturedGroupsText);
163​
164​ m_messageWidget = new KMessageWidget(this);
165​ m_messageWidget->setCloseButtonVisible(false); // hiding,showing of the message will be handled by this form.
166​ m_messageWidget->hide();
167​ mainLayout->addWidget(m_messageWidget);
168​
169​ // Button Bar
170​ auto *buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel | QDialogButtonBox::Help);
171​ m_btnOk = buttonBox->button(QDialogButtonBox::Ok);
172​
173​ KGuiItem::assign(m_btnOk, KGuiItem(i18nc("@action:button", "&Rename"), QStringLiteral("dialog-ok-apply")));
mlaurentUnsubmitted
Done

add parent here too

mlaurent: add parent here too
174​
175​ m_btnOk->setEnabled(false);
176​ connect(m_btnOk, &QPushButton::clicked, this, &BatchRenameDialog::btnOkClicked);
177​ connect(buttonBox, &QDialogButtonBox::rejected, this, &BatchRenameDialog::reject);
178​
179​ mainLayout->addWidget(buttonBox);
180​
181​ m_macroReplaceEdit->setFocus();
182​ updatePreview();
183​ connect(m_tabs, &QTabWidget::currentChanged, valueChangedIntCallback);
184​}
185​
186​void BatchRenameDialog::performPreviewRename(RenamerFunction *callback)
187​{
188​ QStringList generatedNames;
189​ QHash<QString, QVariant> params;
190​ bool allItemsOk = true;
191​ m_itemsToBeRenamed.clear();
192​
193​ params[QStringLiteral("timestamp")] = QDateTime::currentDateTime();
dfaureUnsubmitted
Done

params.insert(key, value) is faster than params[key] = value, see the book Effective C++ (or was it Effective STL?)

dfaure: params.insert(key, value) is faster than params[key] = value, see the book Effective C++ (or…
194​
195​ params[QStringLiteral("macroReplace.text")] = m_macroReplaceEdit->text();
196​ params[QStringLiteral("macroReplace.padding")] = m_IdPaddingLength->value();
197​
198​ params[QStringLiteral("findReplace.find")] = m_findEdit->text();
199​ params[QStringLiteral("findReplace.replace")] = m_replaceEdit->text();
200​ params[QStringLiteral("findReplace.useRegex")] = m_useRegex->isChecked();
201​ params[QStringLiteral("findReplace.caseInsensitive")] = m_caseInsensitive->isChecked();
202​
203​ params[QStringLiteral("newName.find")] = m_patternFind->text();
204​ params[QStringLiteral("newName.replace")] = m_newNameFromMatches->text();
205​
206​
207​ for (int i = 0; i < model->rowCount(); i++) {
208​ const QString itemName = model->data(model->index(i, BatchRenameDialogModel::Name), Qt::DisplayRole).toString();
209​ const KFileItem itemModel = model->fileItem(i);
210​ const QDir itemDir(itemModel.url().adjusted(QUrl::RemoveFilename).adjusted(QUrl::RemoveScheme).toString());
211​
212​ params[QStringLiteral("name")] = itemName;
213​ params[QStringLiteral("baseName")] = FileNameUtils::getName(itemName);
214​ params[QStringLiteral("extension")] = FileNameUtils::getSuffix(itemName);
215​ params[QStringLiteral("macroReplace.sequence")] = i + m_IdStartFrom->value();
216​
217​ const QString newName = KIO::encodeFileName(callback(params));
218​
219​ bool exists = (itemDir.exists(newName) || generatedNames.contains(newName));
220​ bool valid = (newName == itemName) || !(newName.isEmpty() || exists);
221​ allItemsOk &= valid;
dfaureUnsubmitted
Done

bitfield operation on booleans can lead to unexpected behaviour.
Use allItemsOk = allItemsOk && valid instead, or if (!valid) allItemsOk = false;

dfaure: bitfield operation on booleans can lead to unexpected behaviour. Use `allItemsOk = allItemsOk…
222​ generatedNames.append(newName);
223​
224​ if (newName != itemName && !exists) {
225​ m_itemsToBeRenamed.append(QPair<KFileItem, QString>(itemModel, newName));
226​ }
227​
228​ model->setData(model->index(i, BatchRenameDialogModel::Valid), valid, Qt::DisplayRole);
229​ model->setData(model->index(i, BatchRenameDialogModel::NewName), newName, Qt::DisplayRole);
230​ }
231​
232​ const int itemsToBeRenamed = m_itemsToBeRenamed.length();
233​ m_btnOk->setEnabled(allItemsOk && itemsToBeRenamed > 0);
234​ m_previewTable->repaint();
235​
236​ if (!allItemsOk) {
237​ updateStatus(i18nc("@info:status", "Renaming cannot continue while there are file name clashes"),
238​ KMessageWidget::Error);
239​ }
240​
241​ if (itemsToBeRenamed == 0) {
242​ updateStatus(i18nc("@info:status", "No items to be renamed"), KMessageWidget::Information);
243​ }
244​
245​ if (allItemsOk && itemsToBeRenamed > 0) {
246​ updateStatus(QString());
247​ }
248​}
249​
250​void BatchRenameDialog::renameItem(const KFileItem &item, const QString &newName)
251​{
252​ const QUrl newUrl = QUrl::fromLocalFile(item.url().adjusted(QUrl::RemoveFilename).path() + newName);
253​
254​ auto *job = KIO::moveAs(item.url(), newUrl, KIO::HideProgressInfo);
255​ KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::Rename, {item.url()}, newUrl, job);
256​
257​ if (!job->error()) {
dfaureUnsubmitted
Done

This makes no sense, you can't test for a job error before the job is done.
Connect to the result signal and do that in the slot (e.g. lambda) if it should really only be done on success -- after the move happened.

dfaure: This makes no sense, you can't test for a job error before the job is done. Connect to the…
258​ m_renamedItems << newUrl;
259​ }
260​}
dfaureUnsubmitted
Not Done

My comment still stands: it makes no sense to test for error() before the job's result signal is emitted.

The comment was marked as done, but there's still no connect to result

dfaure: My comment still stands: it makes no sense to test for error() before the job's `result` signal…
261​
262​void BatchRenameDialog::performItemsRename()
263​{
264​ for (const auto &pair: m_itemsToBeRenamed) {
dfaureUnsubmitted
Done

qAsConst(m_itemsToBeRenamed)

dfaure: qAsConst(m_itemsToBeRenamed)
265​ renameItem(pair.first, pair.second);
266​ }
267​}
268​
269​void BatchRenameDialog::updatePreview()
270​{
271​ switch (m_tabs->currentIndex()) {
272​ case 1:
273​ performPreviewRename(BatchRenameTypes::findReplaceRenamer);
274​ break;
275​ case 2:
276​ performPreviewRename(BatchRenameTypes::captureRegexGroups);
277​ updateCapturedGroupsLabel();
278​ break;
279​
280​ default:
281​ performPreviewRename(BatchRenameTypes::macroRenamer);
282​ }
283​}
284​
285​void BatchRenameDialog::btnOkClicked(bool checked)
286​{
287​ Q_UNUSED(checked);
dfaureUnsubmitted
Done

Just remove the argument from the slot then.

dfaure: Just remove the argument from the slot then.
288​
289​ performItemsRename();
290​ emit renamingFinished(m_renamedItems);
291​ accept();
292​}
293​
294​void BatchRenameDialog::onEditValueChanged(const QString &value)
295​{
296​ Q_UNUSED(value);
297​
298​ m_timer->start();
299​}
300​
301​QLineEdit *BatchRenameDialog::createLineEdit()
302​{
303​ auto edit = new QLineEdit(this);
304​ connect(edit, &QLineEdit::textChanged, this, &BatchRenameDialog::onEditValueChanged);
305​
306​ return edit;
307​}
308​
309​void BatchRenameDialog::updateStatus(const QString &message, KMessageWidget::MessageType messageType)
310​{
311​ // no actual status update.
312​ if (m_messageWidget->isVisible() && m_messageWidget->text() == message) {
313​ return;
314​ }
315​
316​ // if the message is empty, hide the widget
317​ if (message.isEmpty()) {
318​ m_messageWidget->animatedHide();
319​
320​ return;
321​ }
322​
323​ m_messageWidget->setMessageType(messageType);
324​ m_messageWidget->setText(message);
325​ m_messageWidget->animatedShow();
326​}
327​
328​QAction *BatchRenameDialog::createInsertTokenAction(const QString &text, const QString &token)
329​{
330​ auto result = new QAction(text, this);
331​ connect(result, &QAction::triggered, [this, token]() {
332​ m_macroReplaceEdit->setText(m_macroReplaceEdit->text() + token);
333​ });
334​
335​ return result;
336​}
337​
338​void BatchRenameDialog::createInsertTokenMenu()
339​{
340​ m_insertTokenMenu = new QMenu(this);
dfaureUnsubmitted
Not Done

Better connect to the result() signal of the job and do the rest of btnOkClicked in the slot (or lambda) connected to that signal.
exec() opens many potential issues (re-entrancy).

dfaure: Better connect to the result() signal of the job and do the rest of btnOkClicked in the slot…
341​
342​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Index"), BatchRenameVar::index));
343​ m_insertTokenMenu->addSeparator();
344​
345​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "File name"), BatchRenameVar::fullName));
346​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Base name"), BatchRenameVar::baseName));
347​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Extension"), BatchRenameVar::suffix));
348​ m_insertTokenMenu->addSeparator();
349​
350​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Year (4 digits)"), BatchRenameVar::dateYear4Digit));
351​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Year (2 digits)"), BatchRenameVar::dateYear2Digit));
352​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Month"), BatchRenameVar::dateMonth));
353​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Day"), BatchRenameVar::dateDay));
354​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Hour"), BatchRenameVar::dateHour));
355​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Minute"), BatchRenameVar::dateMinute));
356​ m_insertTokenMenu->addAction(createInsertTokenAction(i18nc("@label", "Second"), BatchRenameVar::dateSecond));
357​}
358​
359​void BatchRenameDialog::updateCapturedGroupsLabel()
360​{
361​ QString groups;
362​ const auto capturedGroups = BatchRenameTypes::firstCapturedGroups();
363​
364​ for (int i = 0; i < capturedGroups.length(); i++) {
365​ if (capturedGroups[i].length() == 0) {
dfaureUnsubmitted
Done

use .isEmpty()

dfaure: use .isEmpty()
366​ continue;
367​ }
368​
369​ groups.append(QStringLiteral("<tt>\\%1: </tt> %2<br>").arg(i).arg(capturedGroups[i]));
370​ }
371​
372​ m_capturedGroupsText->setText(QStringLiteral("<html>%1:<br><br>%2</html>")
373​ .arg(i18nc("@label", "Captured groups from the first row")).arg(groups));
374​ BatchRenameTypes::clearCapturedGroups();
375​}
376​}
377​No newline at end of file
dfaureUnsubmitted
Done

Please configure your text editor to add newlines at the end of files. Surprising that it doesn't do that, most do.

dfaure: Please configure your text editor to add newlines at the end of files. Surprising that it…