Differential D12507 Diff 38737 res/layout/widget_remotecommandplugin.xml

Changeset View

Standalone View

View Options

res/layout/widget_remotecommandplugin.xml

1​<?xml version="1.0" encoding="utf-8"?>
2​<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
3​ android:orientation="vertical" android:layout_width="match_parent"
4​ android:background="#FFFFFF"
5​ android:layout_height="match_parent">
nicolasfellaUnsubmitted
Done

The transparent background is weird IMHO, it makes the command text hardly readable

nicolasfella: The transparent background is weird IMHO, it makes the command text hardly readable
6​ <LinearLayout
7​ android:id="@+id/runcommandWidgetTitleHeader"
8​ android:background="@color/primary"
9​ android:gravity="center_vertical|left"
10​ android:layout_width="match_parent"
11​ android:layout_height="wrap_content">
12​
13​ <ImageView
14​ android:paddingTop="6dip"
nicolasfellaUnsubmitted
Done

I would like a little bit of padding below and above

nicolasfella: I would like a little bit of padding below and above
15​ android:paddingBottom="6dip"
16​ android:layout_width="wrap_content"
17​ android:layout_height="wrap_content"
18​ android:src="@drawable/icon"/>
19​
20​ <TextView
21​ android:id="@+id/runcommandWidgetTitle"
22​ android:layout_width="wrap_content"
23​ android:layout_height="wrap_content"
24​ android:ellipsize="marquee"
25​ android:fadingEdge="horizontal"
26​ android:singleLine="true"
27​ android:textAppearance="?android:attr/textAppearanceLarge" />
28​
29​ </LinearLayout>
30​ <ListView
31​ android:id="@+id/runcommandslist"
32​ android:layout_width="match_parent"
33​ android:layout_height="match_parent"
34​ android:layout_margin="4dp"
35​ android:addStatesFromChildren="true"
36​ android:visibility="gone"
nicolasfellaUnsubmitted
Done

Some padding to the left to make it symmetrical

nicolasfella: Some padding to the left to make it symmetrical
37​ android:orientation="vertical" />
38​
39​ <TextView
40​ android:id="@+id/not_reachable_message"
41​ android:layout_width="match_parent"
42​ android:layout_height="match_parent"
43​ android:drawableLeft="@drawable/ic_error_outline_black_48dp"
44​ android:drawablePadding="8dip"
45​ android:paddingLeft="8dip"
46​ android:drawableStart="@drawable/ic_error_outline_black_48dp"
47​ android:gravity="center_vertical"
48​ android:text="@string/unreachable_description"
49​ android:textAppearance="?android:attr/textAppearanceMedium" />
50​</LinearLayout>
51​No newline at end of file