Differential D14050 Diff 37580 libdiscover/backends/FwupdBackend/FwupdBackend.cpp

Changeset View

Standalone View

View Options

libdiscover/backends/FwupdBackend/FwupdBackend.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright © 2013 Aleix Pol Gonzalez <aleixpol@blue-systems.com> *
3​ * Copyright © 2018 Abhijeet Sharma <sharma.abhijeet2096@gmail.com> *
4​ * *
5​ * This program is free software; you can redistribute it and/or *
6​ * modify it under the terms of the GNU General Public License as *
7​ * published by the Free Software Foundation; either version 2 of *
8​ * the License or (at your option) version 3 or any later version *
9​ * accepted by the membership of KDE e.V. (or its successor approved *
10​ * by the membership of KDE e.V.), which shall act as a proxy *
11​ * defined in Section 14 of version 3 of the license. *
12​ * *
13​ * This program is distributed in the hope that it will be useful, *
14​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
15​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
16​ * GNU General Public License for more details. *
17​ * *
18​ * You should have received a copy of the GNU General Public License *
19​ * along with this program. If not, see <http://www.gnu.org/licenses/>. *
20​ ***************************************************************************/
21​
22​#include "FwupdBackend.h"
23​#include "FwupdResource.h"
24​#include "FwupdReviewsBackend.h"
25​#include "FwupdTransaction.h"
26​#include "FwupdSourcesBackend.h"
27​#include <FwupdUpdater.h>
28​#include <resources/SourcesModel.h>
29​#include <Transaction/Transaction.h>
30​
31​#include <KAboutData>
32​#include <KLocalizedString>
33​#include <KPluginFactory>
34​#include <KConfigGroup>
35​#include <KSharedConfig>
36​#include <QDebug>
37​#include <QThread>
38​#include <QTimer>
39​#include <QAction>
40​#include <QMimeDatabase>
41​
42​
43​DISCOVER_BACKEND_PLUGIN(FwupdBackend)
44​
45​#define STRING(s) #s // For Project Name and Version
46​
47​FwupdBackend::FwupdBackend(QObject* parent)
48​ : AbstractResourcesBackend(parent)
49​ , m_updater(new FwupdUpdater(this))
50​ , m_reviews(new FwupdReviewsBackend(this))
51​ , m_fetching(true)
52​{
53​
54​ QTimer::singleShot(500, this, &FwupdBackend::toggleFetching);
55​ connect(m_reviews, &FwupdReviewsBackend::ratingsReady, this, &AbstractResourcesBackend::emitRatingsReady);
56​ connect(m_updater, &FwupdUpdater::updatesCountChanged, this, &FwupdBackend::updatesCountChanged);
57​
58​ client = fwupd_client_new ();
59​ toDownload = g_ptr_array_new_with_free_func (g_free);
60​ toIgnore = g_ptr_array_new_with_free_func (g_free);
61​
62​ /* use a custom user agent to provide the fwupd version */
63​ userAgent = fwupd_build_user_agent (STRING(PROJECT_NAME),STRING(PROJECT_VERSION));
64​ soupSession = soup_session_new_with_options (SOUP_SESSION_USER_AGENT, userAgent,SOUP_SESSION_TIMEOUT, 10,NULL);
65​ soup_session_remove_feature_by_type (soupSession,SOUP_TYPE_CONTENT_DECODER);
66​
67​ if (!m_fetching)
68​ m_reviews->initialize();
anthonyfieroniUnsubmitted
Done

Indentations should be 4 spaces, if statement goes with { on same line and } even on one line body.

anthonyfieroni: Indentations should be 4 spaces, if statement goes with { on same line and } even on one line…
69​ populate(QStringLiteral("Releases"));
70​
71​ SourcesModel::global()->addSourcesBackend(new FwupdSourcesBackend(this));
72​}
73​
74​FwupdBackend::~FwupdBackend()
75​{
76​ g_object_unref (client);
77​ g_ptr_array_unref (toDownload);
78​ g_ptr_array_unref (toIgnore);
79​}
80​
81​gchar* FwupdBackend::FwupdBuildDeviceID(FwupdDevice* device)
82​{
83​ g_autofree gchar *tmp = g_strdup (fwupd_device_get_id (device));
84​ g_strdelimit (tmp, "/", '_');
85​ return g_strdup_printf ("org.fwupd.%s.device", tmp);
anthonyfieroniUnsubmitted
Not Done

It's memory leak.

anthonyfieroni: It's memory leak.
abhijeet2096AuthorUnsubmitted
Not Done

Please see the new modified function. Will Memory be leaking?

abhijeet2096: Please see the new modified function. Will Memory be leaking?
86​}
apolUnsubmitted
Done

When getting a string from glib, use QString::fromUtf8, which is what I guess they use.

apol: When getting a string from glib, use QString::fromUtf8, which is what I guess they use.
87​
88​QString FwupdBackend::FwupdGetAppName(QString ID)
89​{
90​ //To Do Implement it!
91​ return ID;
92​}
93​
94​QSet<AbstractResource*> FwupdBackend::FwupdGetAllUpdates()
apolUnsubmitted
Done

Does it still make sense to add it if it doesn't have an id?
In which cases wouldn't it have an id?

apol: Does it still make sense to add it if it doesn't have an id? In which cases wouldn't it have an…
95​{
96​ QSet<AbstractResource*> ret;
97​ ret.reserve(m_toUpdate.size());
98​ foreach(FwupdResource* r, m_toUpdate)
99​ {
100​ AbstractResource* res = (AbstractResource*) r;
apolUnsubmitted
Done

No need to cast. Use the FwupdResource directly.

apol: No need to cast. Use the FwupdResource directly.
abhijeet2096AuthorUnsubmitted
Done

Still Need To Fix it

abhijeet2096: Still Need To Fix it
101​ if(r->m_id.isEmpty())
102​ qDebug() << "Resource ID is Empty" << r->m_name;
103​ ret.insert(res);
104​ }
105​ return ret;
106​
107​}
108​
109​FwupdResource * FwupdBackend::FwupdCreateDevice(FwupdDevice *device)
110​{
111​ const QString name = QLatin1String(fwupd_device_get_name(device));
112​ FwupdResource* res = new FwupdResource(name, true, this);
113​ res->setId(QLatin1String(FwupdBuildDeviceID(device)));
114​ res->addCategories(QStringLiteral("Releases"));
115​ res->setIconName(QLatin1String((const gchar *)g_ptr_array_index (fwupd_device_get_icons(device),0)));// Implement a Better way to decide icon
116​
117​ FwupdSetDeviceDetails(res,device);
118​ return res;
119​}
120​
121​FwupdResource * FwupdBackend::FwupdCreateRelease(FwupdDevice *device)
122​{
123​ FwupdRelease *rel = fwupd_device_get_release_default (device);
124​ const QString name = QLatin1String(fwupd_release_get_name(rel));
125​ FwupdResource* res = new FwupdResource(name, true, this);
126​
127​ res->setDeviceID(QLatin1String(fwupd_device_get_id (device)));
128​ FwupdSetReleaseDetails(res,rel);
129​ FwupdSetDeviceDetails(res,device);
130​
131​ if (fwupd_release_get_appstream_id (rel) != NULL)
132​ res->setId(QLatin1String(fwupd_release_get_appstream_id (rel)));
133​
134​ /* the same as we have already */
135​ if (g_strcmp0 (fwupd_device_get_version (device),fwupd_release_get_version (rel)) == 0)
136​ {
137​ qWarning() << "same firmware version as installed";
138​ }
139​
140​ return res;
141​
142​}
143​void FwupdBackend::FwupdSetReleaseDetails(FwupdResource *res,FwupdRelease *rel)
144​{
145​ res->addCategories(QLatin1String("Releases"));
146​ if(fwupd_release_get_summary(rel))
147​ res->setSummary(QLatin1String(fwupd_release_get_summary(rel)));
148​ if(fwupd_release_get_vendor(rel) != NULL)
149​ res->setVendor(QLatin1String(fwupd_release_get_vendor(rel)));
150​ if(fwupd_release_get_version(rel) != NULL)
151​ res->setVersion(QLatin1String(fwupd_release_get_version(rel)));
152​ if(fwupd_release_get_description(rel) != NULL)
153​ res->setDescription(QLatin1String((fwupd_release_get_description (rel))));
154​ if(fwupd_release_get_homepage(rel) != NULL)
155​ res->setHomePage(QUrl(QLatin1String(fwupd_release_get_homepage(rel))));
156​ if(fwupd_release_get_license(rel))
157​ res->setLicense(QLatin1String(fwupd_release_get_license(rel)));
158​ if (fwupd_release_get_uri (rel) != NULL)
159​ {
160​ res->m_updateURI = QLatin1String(fwupd_release_get_uri (rel));
161​ }
162​}
163​void FwupdBackend::FwupdSetDeviceDetails(FwupdResource *res,FwupdDevice *dev)
164​{
apolUnsubmitted
Done

This is not a literal. Use QString::fromLatin1 (or fromUtf8, it should be Utf8).

apol: This is not a literal. Use QString::fromLatin1 (or fromUtf8, it should be Utf8).
165​ GPtrArray *guids;
166​ if (fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_UPDATABLE))
167​ res->isLiveUpdatable = true;
apolUnsubmitted
Done

res->isLiveUpdatable = fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_UPDATABLE)
And same with the rest.

apol: ` res->isLiveUpdatable = fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_UPDATABLE)` And same…
168​ if (fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_ONLY_OFFLINE))
169​ res->isOnlyOffline = true;
170​ if (fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_NEEDS_REBOOT))
171​ res->needsReboot = true;
172​ if (!fwupd_device_has_flag (dev, FWUPD_DEVICE_FLAG_INTERNAL))
173​ res->isDeviceRemoval = true;
174​ guids = fwupd_device_get_guids (dev);
175​ if(guids->len > 0)
176​ {
177​ g_autofree gchar *guid_str = NULL;
178​ g_auto(GStrv) tmp = g_new0 (gchar *, guids->len + 1);
179​ for (int i = 0; i < (int)guids->len; i++)
180​ tmp[i] = g_strdup ((gchar *)g_ptr_array_index (guids, i));
181​ guid_str = g_strjoinv (",", tmp);
182​ res->guidString = guid_str;
183​ }
184​ if(fwupd_device_get_name (dev) != NULL)
185​ {
186​ g_autofree gchar *vendor_name = NULL;
187​ if (g_str_has_prefix (fwupd_device_get_name (dev),fwupd_device_get_vendor (dev)))
188​ {
189​ vendor_name = g_strdup (fwupd_device_get_name (dev));
190​ }
191​ else
192​ {
193​ vendor_name = g_strdup_printf ("%s %s",fwupd_device_get_vendor (dev), fwupd_device_get_name (dev));
apolUnsubmitted
Done

Use QString, not g_* to construct strings.

apol: Use QString, not g_* to construct strings.
194​ }
195​ res->setName(QLatin1String(vendor_name));
196​ }
197​ if(fwupd_device_get_summary (dev) != NULL)
198​ res->setSummary(QLatin1String(fwupd_device_get_summary(dev)));
199​ if(fwupd_device_get_vendor(dev) != NULL)
200​ res->setVendor(QLatin1String(fwupd_device_get_vendor(dev)));
201​ if(fwupd_device_get_version(dev) != NULL)
202​ res->setVersion(QLatin1String(fwupd_device_get_version(dev)));
203​ if(fwupd_device_get_description(dev) != NULL)
204​ res->setDescription(QLatin1String((fwupd_device_get_description(dev))));
205​}
206​
207​void FwupdBackend::populate(const QString& n)
208​{
209​ g_autoptr(GPtrArray) devices = NULL;
apolUnsubmitted
Done

Just initialize at once. No need to set NULL first.

apol: Just initialize at once. No need to set NULL first.
210​
211​ /* get devices */
212​ devices = fwupd_client_get_devices (client, NULL, NULL);
213​
214​ if (devices != NULL)
215​ {
216​ for (int i = 0; i < (int)devices->len; i++)
217​ {
218​ FwupdDevice *device = (FwupdDevice *)g_ptr_array_index (devices, i);
219​ FwupdResource * res = NULL;
apolUnsubmitted
Done

Same

apol: Same
220​ g_autoptr(GPtrArray) releases = NULL;
221​
222​ /* Devices Which are not updatable */
223​ // if (!fwupd_device_has_flag (device, FWUPD_DEVICE_FLAG_UPDATABLE))
224​ // continue;
apolUnsubmitted
Done

Usually name is a user-visible string. Would it make more sense to use packageName?
This way you could also skip the toLower part.

apol: Usually name is a user-visible string. Would it make more sense to use packageName? This way…
225​
226​ /* add releases */
227​ res = FwupdCreateDevice(device);
228​ res->addCategories(n);
229​
230​
231​ releases = fwupd_client_get_releases (client,res->m_deviceID.toUtf8().constData(),NULL,NULL);
232​
233​ if (releases != NULL)
apolUnsubmitted
Done

if (releases)

apol: `if (releases)`
234​ {
235​ for (int j = 0; j < (int)releases->len; j++)
apolUnsubmitted
Done

Use uint rather than casting

apol: Use uint rather than casting
236​ {
237​ FwupdRelease *rel = (FwupdRelease *)g_ptr_array_index (releases, j);
238​ const QString name = QLatin1String(fwupd_release_get_name(rel));
239​ FwupdResource* res_ = new FwupdResource(name, true, this);
240​ FwupdSetReleaseDetails (res_, rel);
241​ res->m_releases.append(res_);
242​ }
apolUnsubmitted
Done

Remove ifdef, fix indentation

apol: Remove ifdef, fix indentation
243​ }
244​ /* add all Valid Resources */
245​ m_resources.insert(res->name().toLower(), res);
246​ }
247​ }
248​}
249​
250​
251​void FwupdBackend::FwupdAddUpdates()
252​{
253​ g_autoptr(GPtrArray) remotes = NULL;
254​ g_autoptr(GCancellable) cancellable = g_cancellable_new();
255​ g_autoptr(GError) error = NULL;
256​ g_autoptr(GError) error2 = NULL;
257​ g_autoptr(GPtrArray) devices = NULL;
258​ g_autoptr(GPtrArray) rels = NULL;
259​
260​ /* get All devices, Will filter latter */
261​ devices = fwupd_client_get_devices (client, cancellable, &error);
apolUnsubmitted
Done

Don't initialize twice.

apol: Don't initialize twice.
262​ if(devices == NULL){
apolUnsubmitted
Done

if (devices)

apol: if (devices)
263​ if (g_error_matches (error,FWUPD_ERROR,FWUPD_ERROR_NOTHING_TO_DO)){
264​ #ifdef FWUPD_DEBUG
265​ qDebug() << "No Devices Found";
266​ #endif
267​ FwupdHandleError(&error);
268​ }
269​ }
apolUnsubmitted
Done

} else {

apol: } else {
270​ else{
271​ for (int i = 0; i < (int)devices->len; i++) {
272​ FwupdDevice *device = (FwupdDevice *)g_ptr_array_index (devices, i);
273​ FwupdResource* res;
274​
275​ res = FwupdCreateDevice(device); //just to test code should be deleted
276​ m_toUpdate.append(res); //just to test code should be deleted
277​
278​ if (!fwupd_device_has_flag (device, FWUPD_DEVICE_FLAG_SUPPORTED))
279​ continue;
280​
281​ /*Device is Locked Needs Unlocking*/
282​ if (fwupd_device_has_flag (device, FWUPD_DEVICE_FLAG_LOCKED))
283​ {
284​ res = FwupdCreateDevice(device);
285​ res->setIsDeviceLocked(true);
286​ m_toUpdate.append(res);
287​ connect(res, &FwupdResource::stateChanged, this, &FwupdBackend::updatesCountChanged);
288​ continue;
289​ }
zzagUnsubmitted
Done

Coding style nitpick: indentation is not consistent. At all.

zzag: Coding style nitpick: indentation is not consistent. At all.
290​
291​
292​ rels = fwupd_client_get_upgrades (client,fwupd_device_get_id(device),cancellable, &error2);
293​
294​ if (rels == NULL) {
295​ if (g_error_matches (error2,FWUPD_ERROR,FWUPD_ERROR_NOTHING_TO_DO)){
296​ qWarning() << "No Packages Found for "<< fwupd_device_get_id(device);
297​ FwupdHandleError(&error2);
298​ continue;
299​ }
300​ }
301​ else{
302​ fwupd_device_add_release(device,(FwupdRelease *)g_ptr_array_index(rels,0));
303​ if(FwupdAddToSchedule(device))
304​ {
305​ qWarning() << "Cannot Add To Schdule" << fwupd_device_get_id(device);
306​ continue;
307​ }
308​ }
zzagUnsubmitted
Done

Coding style nitpick: why does this small piece of code follows several totally different coding styles?

zzag: Coding style nitpick: why does this small piece of code follows several totally different…
309​ }
310​ }
311​}
312​
313​
314​gchar* FwupdBackend::FwupdGetChecksum(const gchar *filename,GChecksumType checksum_type)
315​{
316​ gsize len;
317​ g_autofree gchar *data = NULL;
318​ if (!g_file_get_contents (filename, &data, &len, NULL)) {
319​ qWarning() << "Cannot Access File!" << filename;
320​ return NULL;
321​ }
322​ return g_compute_checksum_for_data (checksum_type, (const guchar *)data, len);
323​}
324​
325​bool FwupdBackend::FwupdAddToSchedule(FwupdDevice *device)
326​{
327​ FwupdRelease *rel = fwupd_device_get_release_default (device);
328​ GPtrArray *checksums;
329​ const gchar *update_uri;
apolUnsubmitted
Done

Don't set to null only to initialize at the next line.

apol: Don't set to null only to initialize at the next line.
330​ g_autofree gchar *basename = NULL;
331​ g_autofree gchar *filename_cache = NULL;
332​ g_autoptr(GFile) file = NULL;
333​ FwupdResource* app = NULL;
334​
335​ /* update unsupported */
336​ app = FwupdCreateRelease(device);
337​ if (!app->isLiveUpdatable)
338​ {
339​ qWarning() << app->m_name << "[" << app->m_id << "]" << "cannot be updated ";
340​ return false;
341​ }
342​
343​ /* Important Attributes missing */
344​ if (app->m_id.isNull())
345​ {
346​ qWarning() << "fwupd: No id for firmware";
347​ return true;
348​ }
349​ if (app->m_version.isNull())
350​ {
351​ qWarning() << "fwupd: No version! for " << app->m_id;
352​ return true;
353​ }
354​ if (app->m_updateVersion.isNull())
355​ {
356​ qWarning() << "fwupd: No update-version! for " << app->m_id;
357​ return true;
358​ }
359​ checksums = fwupd_release_get_checksums (rel);
360​ if (checksums->len == 0)
361​ {
362​ qWarning() << app->m_name << "[" << app->m_id << "]" << "(" << app->m_updateVersion << ")" "has no checksums, ignoring as unsafe";
363​ return false;
364​ }
365​ update_uri = fwupd_release_get_uri (rel);
366​ if (update_uri == NULL)
367​ {
368​ qWarning() << "no location available for" << app->m_name << "[" << app->m_id << "]";
369​ return false;
370​ }
371​
372​ /* Checking for firmware in the cache? */
373​ basename = g_path_get_basename (update_uri);
374​ filename_cache = FwupdCacheFile("fwupd",basename);
375​ if (filename_cache == NULL)
376​ return false;
377​
378​ if (g_file_test (filename_cache, G_FILE_TEST_EXISTS))
379​ {
380​ const gchar *checksum_tmp = NULL;
381​ g_autofree gchar *checksum = NULL;
382​
383​ /* Currently LVFS supports SHA1 only*/
384​ checksum_tmp = fwupd_checksum_get_by_kind (checksums,G_CHECKSUM_SHA1);
385​ if (checksum_tmp == NULL)
386​ {
387​ qWarning() << "No valid checksum for" << filename_cache;
388​ }
389​ checksum = FwupdGetChecksum(filename_cache,G_CHECKSUM_SHA1);
390​ if (checksum == NULL)
391​ return false;
392​ if (g_strcmp0 (checksum_tmp, checksum) != 0)
393​ {
394​ qWarning() << filename_cache << " does not match checksum, expected" << checksum_tmp << "got" << checksum;
395​ g_unlink (filename_cache);
396​ return false;
apolUnsubmitted
Not Done

Are you sure you need an event-loop there? Let's make this non-blocking.

apol: Are you sure you need an event-loop there? Let's make this non-blocking.
abhijeet2096AuthorUnsubmitted
Not Done

Can you please guide me, on how can I make this non-blocking?

abhijeet2096: Can you please guide me, on how can I make this non-blocking?
397​ }
apolUnsubmitted
Done

&file is in this scope, it will crash as soon as you call m_file outside this scope.

Maybe just keep the path?

apol: &file is in this scope, it will crash as soon as you call m_file outside this scope. Maybe…
398​ }
399​
400​ /* link file to application and append to update list */
401​ file = g_file_new_for_path (filename_cache);
402​ app->m_file = file;
403​ m_toUpdate.append(app);
404​ /* schedule for download */
405​ if (!g_file_test (filename_cache, G_FILE_TEST_EXISTS))
406​ FwupdAddToScheduleForDownload(update_uri);
407​
408​ return true;
409​}
410​
411​
412​
apolUnsubmitted
Done

else { qWarning() ...

apol: else { qWarning() ...
413​bool FwupdBackend::FwupdDownloadFile(const gchar *uri,const gchar *filename)
414​{
415​ guint status_code;
416​ g_autoptr(SoupMessage) msg = NULL;
417​ g_return_val_if_fail (uri != NULL, FALSE);
418​ g_return_val_if_fail (filename != NULL, FALSE);
419​ g_autoptr(GCancellable) cancellable = g_cancellable_new();
420​ g_autoptr(GError) error_local = NULL;
421​
422​ if (g_str_has_prefix (uri, "file://"))
423​ {
424​ gsize length = 0;
425​ g_autofree gchar *contents = NULL;
426​ if (!g_file_get_contents (uri + 7, &contents, &length, &error_local))
427​ {
428​ qWarning() << "Cannot Access File" << uri;
429​ return false;
430​ }
431​ if (!g_file_set_contents (filename, contents, length, &error_local))
432​ {
433​ qWarning() << "Cannot Save the file content in " << filename;
434​ return false;
435​ }
436​ return true;
437​ }
438​
439​ /* remote */
440​ #ifdef FWUPD_DEBUG
441​ qDebug() << "downloading " << uri << " to " << filename;
442​ #endif
443​ msg = soup_message_new (SOUP_METHOD_GET, uri);
444​ if (msg == NULL)
445​ {
446​ // To DO Error Handling
447​ return false;
448​ }
449​
450​ status_code = soup_session_send_message (soupSession, msg);
451​ if (status_code != SOUP_STATUS_OK)
452​ {
453​ g_autoptr(GString) str = g_string_new (NULL);
454​ g_string_append (str, soup_status_get_phrase (status_code));
455​ if (msg->response_body->data != NULL)
456​ {
457​ g_string_append (str, ": ");
458​ g_string_append (str, msg->response_body->data);
459​ }
460​ // To DO Error Handling
461​ return false;
462​ }
463​
464​ if (!g_file_set_contents (filename,msg->response_body->data,msg->response_body->length,&error_local))
apolUnsubmitted
Done

Use QFile

apol: Use QFile
465​ {
466​ qWarning() << "Cannot Save the file content in " << filename;
467​ return false;
468​ }
469​ return true;
470​}
471​
472​GBytes* FwupdBackend::FwupdDownloadData(const gchar *uri)
473​{
474​ guint status_code;
475​ g_autoptr(SoupMessage) msg = NULL;
476​ g_autoptr(GCancellable) cancellable = g_cancellable_new();
477​ g_autoptr(GError) error = NULL;
478​
479​ g_return_val_if_fail (uri != NULL, NULL);
480​
481​ /* local */
482​ if (g_str_has_prefix (uri, "file://")) {
apolUnsubmitted
Done

QUrl

apol: QUrl
483​ gsize length = 0;
484​ g_autofree gchar *contents = NULL;
485​ g_autoptr(GError) error_local = NULL;
486​
487​ if (!g_file_get_contents (uri + 7, &contents, &length, &error_local)) {
488​ // To DO Error Handling
489​ return NULL;
490​ }
491​ return g_bytes_new (contents, length);
492​ }
493​
494​ /* remote */
495​ msg = soup_message_new (SOUP_METHOD_GET, uri);
496​ status_code = soup_session_send_message (soupSession, msg);
497​ if (status_code != SOUP_STATUS_OK) {
498​ g_autoptr(GString) str = g_string_new (NULL);
499​ g_string_append (str, soup_status_get_phrase (status_code));
500​ if (msg->response_body->data != NULL) {
501​ g_string_append (str, ": ");
502​ g_string_append (str, msg->response_body->data);
503​ }
504​ // TO Do Error Handling
505​ return NULL;
506​ }
507​ return g_bytes_new (msg->response_body->data,(gsize) msg->response_body->length);
508​}
509​
510​bool FwupdBackend::FwupdRefreshRemotes(guint cache_age)
511​{
512​ g_autoptr(GPtrArray) remotes = NULL;
513​ g_autoptr(GCancellable) cancellable = g_cancellable_new();
514​ g_autoptr(GError) error = NULL;
515​
516​ /*Gets all Remotes will filter later*/
517​ remotes = fwupd_client_get_remotes (client, cancellable, &error);
518​ if (remotes == NULL)
519​ return false;
520​ for (int i = 0; i < (int)remotes->len; i++) {
521​ FwupdRemote *remote = (FwupdRemote *)g_ptr_array_index (remotes, i);
522​ /*Remotes disabled by user so ignore*/
523​ if (!fwupd_remote_get_enabled (remote))
524​ continue;
525​ /*Local Remotes Ignore*/
526​ if (fwupd_remote_get_kind (remote) == FWUPD_REMOTE_KIND_LOCAL)
527​ continue;
528​ /*Refresh the left ones*/
529​ if (!FwupdRefreshRemote(remote, cache_age))
530​ return false;
531​ }
532​ return true;
533​}
534​
535​bool FwupdBackend::FwupdRefreshRemote(FwupdRemote *remote,guint cache_age)
536​{
537​ GChecksumType checksum_kind;
538​ const gchar *url_sig = NULL;
539​ const gchar *url = NULL;
540​ g_autoptr(GError) error_local = NULL;
541​ g_autofree gchar *basename = NULL;
542​ g_autofree gchar *basename_sig = NULL;
543​ g_autofree gchar *cache_id = NULL;
544​ g_autofree gchar *checksum = NULL;
545​ g_autofree gchar *filename = NULL;
546​ g_autofree gchar *filename_sig = NULL;
547​ g_autoptr(GBytes) data = NULL;
548​ g_autoptr(GCancellable) cancellable = g_cancellable_new();
549​ g_autoptr(GError) error = NULL;
550​
551​ if (fwupd_remote_get_filename_cache_sig (remote) == NULL) {
552​ qWarning() << "Remote " << fwupd_remote_get_id (remote) << "has no cache signature!";
553​ return false;
554​ }
555​
556​ /* check cache age */
557​ if (cache_age > 0)
558​ {
559​ guint64 age = fwupd_remote_get_age (remote);
560​ guint tmp = age < G_MAXUINT ? (guint) age : G_MAXUINT;
561​ if (tmp < cache_age)
562​ {
563​ #ifdef FWUPD_DEBUG
564​ qDebug() << filename_sig << "is only" << tmp << "seconds old, so ignoring refresh! ";
565​ #endif
566​ return true;
567​ }
568​ }
569​
570​ cache_id = g_strdup_printf ("fwupd/remotes.d/%s", fwupd_remote_get_id (remote));
571​ basename_sig = g_path_get_basename (fwupd_remote_get_filename_cache_sig (remote));
572​ filename_sig = FwupdCacheFile(cache_id,basename_sig);
573​
574​ /* download the signature first*/
575​ url_sig = fwupd_remote_get_metadata_uri_sig (remote);
576​ #ifdef FWUPD_DEBUG
577​ qDebug() << "Download Remotes Signature";
578​ #endif
579​ data = FwupdDownloadData(url_sig);
580​
581​ if (data == NULL) {
582​ //To Do Error Handling
583​ return false;
584​ }
585​
586​ checksum_kind = fwupd_checksum_guess_kind (fwupd_remote_get_checksum (remote));
587​ checksum = g_compute_checksum_for_data (checksum_kind,(const guchar *) g_bytes_get_data (data, NULL),g_bytes_get_size (data));
588​
589​ if (g_strcmp0 (checksum, fwupd_remote_get_checksum (remote)) == 0)
590​ {
591​ #ifdef FWUPD_DEBUG
592​ qDebug() << "signature of" << url_sig << "is unchanged";
593​ #endif
594​ return true;
595​ }
596​
597​ /* save to a file */
598​ #ifdef FWUPD_DEBUG
599​ qDebug() << "saving new remote signature to:" << filename_sig;
600​ #endif
601​ if (!g_file_set_contents (filename_sig,(const gchar*)g_bytes_get_data (data, NULL),(guint) g_bytes_get_size (data),&error_local))
602​ {
603​ qWarning() << "cannot save signature";
604​ return false;
605​ }
606​
607​ basename = g_path_get_basename (fwupd_remote_get_filename_cache (remote));
608​ filename = FwupdCacheFile(cache_id,basename);
609​
610​ if (filename == NULL)
611​ return FALSE;
612​ #ifdef FWUPD_DEBUG
613​ qDebug() << "saving new firmware metadata to:" << filename;
614​ qDebug() << "Downloading remotes metadata";
615​ #endif
616​ url = fwupd_remote_get_metadata_uri (remote);
617​ if (!FwupdDownloadFile (url, filename))
618​ {
619​ qWarning() << "Cannot Download File : " << filename ;
620​ return false;
621​ }
622​
623​ /* Sending Metadata to fwupd Daemon*/
624​ if (!fwupd_client_update_metadata (client,fwupd_remote_get_id (remote),filename,filename_sig,cancellable,&error))
625​ {
626​ FwupdHandleError(&error);
627​ return false;
628​ }
629​
630​ return true;
631​}
632​
633​void FwupdBackend::FwupdHandleError(GError **perror)
634​{
635​ GError *error = perror != NULL ? *perror : NULL;
636​
637​ if(error == NULL)
638​ return;
639​ //To DO Indivitual take action based on case,Show Notification on Discover;
640​ switch (error->code)
641​ {
642​ case FWUPD_ERROR_ALREADY_PENDING:
643​ qWarning() << "FWUPD_ERROR_ALREADY_PENDING";
644​ break;
645​ case FWUPD_ERROR_INVALID_FILE:
646​ qWarning() << "FWUPD_ERROR_INVALID_FILE";
647​ break;
648​ case FWUPD_ERROR_NOT_SUPPORTED:
649​ qWarning() << "FWUPD_ERROR_NOT_SUPPORTED";
650​ break;
651​ case FWUPD_ERROR_AUTH_FAILED:
652​ qWarning() << "FWUPD_ERROR_AUTH_FAILED";
653​ break;
654​ case FWUPD_ERROR_SIGNATURE_INVALID:
655​ qWarning() << "FWUPD_ERROR_SIGNATURE_INVALID";
656​ break;
657​ case FWUPD_ERROR_AC_POWER_REQUIRED:
658​ qWarning() << "FWUPD_ERROR_AC_POWER_REQUIRED";
apolUnsubmitted
Done

Use nullptr everywhere you use NULL.

apol: Use nullptr everywhere you use NULL.
659​ break;
660​ default:
661​ qWarning() << "Unknown Error ::" << error->code;
662​ break;
663​ }
664​}
665​
666​gchar* FwupdBackend::FwupdCacheFile(const gchar *kind,const gchar *resource)
667​{
668​ g_autofree gchar *basename = NULL;
669​ g_autofree gchar *cachedir = NULL;
670​ g_autoptr(GFile) cachedir_file = NULL;
671​ g_autoptr(GPtrArray) candidates = g_ptr_array_new_with_free_func (g_free);
672​ g_autoptr(GError) error = NULL;
673​ basename = g_path_get_basename (resource);
674​ cachedir = g_build_filename (g_get_user_cache_dir (),"discover",kind,NULL);
675​ cachedir_file = g_file_new_for_path (cachedir);
676​
677​ if (!g_file_query_exists (cachedir_file, NULL) && !g_file_make_directory_with_parents (cachedir_file, NULL, &error))
678​ return NULL;
679​ g_ptr_array_add (candidates, g_build_filename (cachedir, basename, NULL));
680​
681​ return g_strdup((gchar *)g_ptr_array_index (candidates, 0));
682​}
683​bool FwupdBackend::FwupdDownloadAllScheduled(guint cache_age)
684​{
685​ const gchar *tmp;
686​ if (!FwupdRefreshRemotes(cache_age))
687​ return false;
688​
689​ /* download the files to the cachedir */
690​ for (int i = 0; i < (int)toDownload->len; i++)
691​ {
692​ g_autoptr(GError) error_local = NULL;
693​ g_autofree gchar *basename = NULL;
694​ g_autofree gchar *filename_cache = NULL;
695​
696​ tmp = (gchar *)g_ptr_array_index (toDownload, i);
697​ basename = g_path_get_basename (tmp);
698​ filename_cache = FwupdCacheFile("fwupd", basename);
699​
700​ if (filename_cache == NULL)
701​ return false;
702​
703​ /* download file */
704​ if (!FwupdDownloadFile(tmp, filename_cache))
705​ {
706​ qWarning() <<"Failed to download " << tmp << ", ignoring:" ;
707​ g_ptr_array_remove_index (toDownload, i--);
708​ g_ptr_array_add (toIgnore, g_strdup (tmp));
709​ continue;
710​ }
711​ }
712​
713​ return true;
714​}
715​
716​bool FwupdBackend::FwupdAddToScheduleForDownload(const gchar * uri)
717​{
718​ const gchar *tmp;
719​ for (int i = 0; i < (int)toIgnore->len; i++)
720​ {
721​ tmp = (gchar *)g_ptr_array_index (toIgnore, i);
722​ if (g_strcmp0 (tmp, uri) == 0)
723​ return false;
724​ }
725​ for (int i = 0; i < (int)toDownload->len; i++)
726​ {
727​ tmp = (gchar *)g_ptr_array_index (toDownload, i);
728​ if (g_strcmp0 (tmp, uri) == 0)
729​ return false;
730​ }
731​ g_ptr_array_add (toDownload, g_strdup (uri));
732​ return true;
733​}
734​
735​
736​void FwupdBackend::toggleFetching()
737​{
738​ m_fetching = !m_fetching;
739​ #ifdef FWUPD_DEBUG
740​ qDebug() << "Fwupd fetching..." << m_fetching;
741​ #endif
742​ FwupdAddUpdates();
743​ FwupdDownloadAllScheduled(60*60*24*30); // Nicer Way to put time? currently 30 days in seconds
744​ emit fetchingChanged();
745​}
746​
747​int FwupdBackend::updatesCount() const
748​{
749​ return m_updater->updatesCount();
750​}
751​
752​ResultsStream* FwupdBackend::search(const AbstractResourcesBackend::Filters& filter)
753​{
754​ QVector<AbstractResource*> ret;
755​ if (!filter.resourceUrl.isEmpty() && filter.resourceUrl.scheme() == QLatin1String("fwupd"))
756​ return findResourceByPackageName(filter.resourceUrl);
apolUnsubmitted
Done

return !m_resources.isEmpty()

apol: return !m_resources.isEmpty()
757​ else foreach(AbstractResource* r, m_resources) {
758​ if(r->name().contains(filter.search, Qt::CaseInsensitive) || r->comment().contains(filter.search, Qt::CaseInsensitive))
759​ ret += r;
760​ }
761​ return new ResultsStream(QStringLiteral("Firmware Updates Stream"), ret);
762​}
763​
764​ResultsStream * FwupdBackend::findResourceByPackageName(const QUrl& search)
765​{
766​ auto res = search.scheme() == QLatin1String("fwupd") ? m_resources.value(search.host().replace(QLatin1Char('.'), QLatin1Char(' '))) : NULL;
767​ if (!res) {
768​ return new ResultsStream(QStringLiteral("Firmware Updates Stream"), {});
769​ } else
770​ return new ResultsStream(QStringLiteral("Firmware Updates Stream"), { res });
771​}
772​
773​AbstractBackendUpdater* FwupdBackend::backendUpdater() const
774​{
775​ return m_updater;
776​}
777​
778​AbstractReviewsBackend* FwupdBackend::reviewsBackend() const
779​{
780​ //return m_reviews; // To Remove the Review backend ( not needed)
781​ return NULL;
782​}
783​
784​Transaction* FwupdBackend::installApplication(AbstractResource* app, const AddonList& addons)
785​{
786​ return new FwupdTransaction(qobject_cast<FwupdResource*>(app), this, addons, Transaction::InstallRole);
787​}
788​
789​Transaction* FwupdBackend::installApplication(AbstractResource* app)
790​{
791​ return new FwupdTransaction(qobject_cast<FwupdResource*>(app), this, Transaction::InstallRole);
792​}
793​
794​Transaction* FwupdBackend::removeApplication(AbstractResource* app)
795​{
796​ return new FwupdTransaction(qobject_cast<FwupdResource*>(app), this, Transaction::RemoveRole);
797​}
798​
799​void FwupdBackend::checkForUpdates()
800​{
801​ if(m_fetching)
802​ return;
803​ toggleFetching();
804​ populate(QStringLiteral("Releases"));
805​ QTimer::singleShot(500, this, &FwupdBackend::toggleFetching);
806​ #ifdef FWUPD_DEBUG
807​ qDebug() << "FwupdBackend::checkForUpdates";
808​ #endif
809​}
810​
811​AbstractResource * FwupdBackend::resourceForFile(const QUrl& path)
812​{
813​ g_autofree gchar *content_type = NULL;
814​ g_autofree gchar *filename = NULL;
815​ g_autoptr(GPtrArray) devices = NULL;
816​ g_autoptr(GCancellable) cancellable = g_cancellable_new();
817​ g_autoptr(GError) error = NULL;
818​
819​ QMimeDatabase db;
820​ QMimeType type = db.mimeTypeForFile(path.fileName());
821​
822​ if(type.isValid() && type.inherits(QStringLiteral("application/vnd.ms-cab-compressed")))
823​ {
824​ filename = path.fileName().toUtf8().data();
825​ devices = fwupd_client_get_details (client,filename,cancellable,&error);
826​
827​ if (devices != NULL)
828​ {
829​ for (int i = 0; i < (int)devices->len; i++)
830​ {
831​ FwupdDevice *dev = (FwupdDevice *)g_ptr_array_index (devices, i);
832​ FwupdResource* app = NULL;
833​ app = FwupdCreateRelease(dev);
834​ app->setState(AbstractResource::None);
835​ m_resources.insert(app->packageName(), app);
836​ connect(app, &FwupdResource::stateChanged, this, &FwupdBackend::updatesCountChanged);
837​ return app;
838​ }
839​ }
840​ else
841​ {
842​ FwupdHandleError(&error);
843​ }
844​ }
845​ return NULL;
846​}
847​
848​QString FwupdBackend::displayName() const
849​{
850​ return QStringLiteral("Firmware Updates");
851​}
852​
853​bool FwupdBackend::hasApplications() const
854​{
855​ return m_resources.count() ? true : false;
856​}
857​
858​#include "FwupdBackend.moc"