Differential D13503 Diff 36372 interfaces/remotecommandsmodel.cpp

Changeset View

Standalone View

View Options

interfaces/remotecommandsmodel.cpp

  • This file was added.
1​/**
2​ * Copyright 2018 Nicolas Fella <nicolas.fella@gmx.de>
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#include "remotecommandsmodel.h"
22​#include "interfaces_debug.h"
23​
24​#include <QDebug>
25​#include <QDBusInterface>
26​
27​RemoteCommandsModel::RemoteCommandsModel(QObject* parent)
28​ : QAbstractListModel(parent)
29​ , m_dbusInterface(nullptr)
30​{
31​
32​ connect(this, &QAbstractItemModel::rowsInserted,
33​ this, &RemoteCommandsModel::rowsChanged);
34​ connect(this, &QAbstractItemModel::rowsRemoved,
35​ this, &RemoteCommandsModel::rowsChanged);
36​
37​ QDBusServiceWatcher* watcher = new QDBusServiceWatcher(DaemonDbusInterface::activatedService(),
38​ QDBusConnection::sessionBus(), QDBusServiceWatcher::WatchForOwnerChange, this);
39​ connect(watcher, &QDBusServiceWatcher::serviceRegistered, this, &RemoteCommandsModel::refreshCommandList);
40​ connect(watcher, &QDBusServiceWatcher::serviceUnregistered, this, &RemoteCommandsModel::clearCommands);
41​}
42​
43​QHash<int, QByteArray> RemoteCommandsModel::roleNames() const
44​{
45​ //Role names for QML
46​ QHash<int, QByteArray> names = QAbstractItemModel::roleNames();
47​ names.insert(KeyRole, "key");
48​ names.insert(NameRole, "name");
49​ names.insert(CommandRole, "command");
50​ return names;
51​}
52​
53​RemoteCommandsModel::~RemoteCommandsModel()
54​{
55​}
56​
57​QString RemoteCommandsModel::deviceId() const
58​{
59​ return m_deviceId;
60​}
61​
62​void RemoteCommandsModel::setDeviceId(const QString& deviceId)
63​{
64​ m_deviceId = deviceId;
65​
66​ if (m_dbusInterface) {
67​ delete m_dbusInterface;
68​ }
69​
70​ m_dbusInterface = new RemoteCommandsDbusInterface(deviceId, this);
71​
72​ connect(m_dbusInterface, &OrgKdeKdeconnectDeviceRemotecommandsInterface::commandsChanged,
73​ this, &RemoteCommandsModel::refreshCommandList);
74​
75​ refreshCommandList();
76​
77​ Q_EMIT deviceIdChanged(deviceId);
78​}
79​
80​void RemoteCommandsModel::refreshCommandList()
81​{
82​ if (!m_dbusInterface) {
83​ return;
84​ }
85​
86​ clearCommands();
87​
88​ if (!m_dbusInterface->isValid()) {
89​ qCWarning(KDECONNECT_INTERFACES) << "dbus interface not valid";
90​ return;
91​ }
92​
93​ const auto cmds = QJsonDocument::fromJson(m_dbusInterface->commands()).object();
94​
95​ beginResetModel();
96​
97​ for (auto it = cmds.constBegin(), itEnd = cmds.constEnd(); it!=itEnd; ++it) {
98​ const QJsonObject cont = it->toObject();
99​ Command command;
100​ command.key = it.key();
101​ command.name = cont.value(QStringLiteral("name")).toString();
102​ command.command = cont.value(QStringLiteral("command")).toString();
103​ m_commandList.append(command);
104​ }
105​
106​ endResetModel();
107​}
108​
109​QVariant RemoteCommandsModel::data(const QModelIndex& index, int role) const
110​{
111​ if (!index.isValid()
112​ || index.row() < 0
113​ || index.row() >= m_commandList.count())
114​ {
115​ return QVariant();
116​ }
117​
118​ if (!m_dbusInterface || !m_dbusInterface->isValid()) {
119​ return QVariant();
120​ }
121​
122​ Command command = m_commandList[index.row()];
123​
apolUnsubmitted
Done

Should it maybe be beginResetModel? Looks like we're setting it up from scratch. Then we'd need to m_commandList.clear()

apol: Should it maybe be beginResetModel? Looks like we're setting it up from scratch. Then we'd need…
124​ switch (role) {
125​ case KeyRole:
126​ return command.key;
127​ case NameRole:
128​ return command.name;
129​ case CommandRole:
130​ return command.command;
131​ default:
132​ return QVariant();
133​ }
134​}
135​
136​int RemoteCommandsModel::rowCount(const QModelIndex& parent) const
137​{
138​ if (parent.isValid()) {
139​ //Return size 0 if we are a child because this is not a tree
140​ return 0;
141​ }
142​
143​ return m_commandList.count();
144​}
145​
146​void RemoteCommandsModel::clearCommands()
147​{
148​ if (!m_commandList.isEmpty()) {
149​ beginRemoveRows(QModelIndex(), 0, m_commandList.size() - 1);
150​ m_commandList.clear();
151​ endRemoveRows();
152​ }
153​}
apolUnsubmitted
Done

No need to check bounds if we call m_commendList.value(row);

apol: No need to check bounds if we call m_commendList.value(row);
apolUnsubmitted
Done

const

apol: const