Differential D12507 Diff 36369 src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandWidgetDeviceSelector.java

Changeset View

Standalone View

View Options

src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandWidgetDeviceSelector.java

1​package org.kde.kdeconnect.Plugins.RunCommandPlugin;
2​
3​import android.content.Intent;
4​import android.os.Build;
5​import android.os.Bundle;
6​import android.support.annotation.RequiresApi;
7​import android.support.v7.app.AppCompatActivity;
8​import android.view.Window;
9​import android.widget.ListView;
10​
11​import org.kde.kdeconnect.BackgroundService;
12​import org.kde.kdeconnect.Device;
13​import org.kde.kdeconnect.UserInterface.List.ListAdapter;
14​import org.kde.kdeconnect_tp.R;
15​
16​import java.util.ArrayList;
17​import java.util.Collections;
18​
19​@RequiresApi( api = Build.VERSION_CODES.ICE_CREAM_SANDWICH )
20​public class RunCommandWidgetDeviceSelector extends AppCompatActivity {
21​ @Override
22​ protected void onCreate(Bundle bundle) {
23​ super.onCreate(bundle);
24​
25​ requestWindowFeature(Window.FEATURE_NO_TITLE);
26​ setContentView(R.layout.widget_remotecommandplugin_dialog);
27​
28​ BackgroundService.RunCommand(this, service -> runOnUiThread(() -> {
29​ ListView view = (ListView) findViewById(R.id.runcommandsdevicelist);
30​
31​ final ArrayList<ListAdapter.Item> commandItems = new ArrayList<>();
nicolasfellaUnsubmitted
Done

Lambda

nicolasfella: Lambda
nicolasfellaUnsubmitted
Done

deviceItems

nicolasfella: deviceItems
32​
33​ for (Device device : service.getDevices().values()) {
nicolasfellaUnsubmitted
Done

I think we should filter out devices that are not paired

nicolasfella: I think we should filter out devices that are not paired
34​ commandItems.add(
35​ new CommandEntry(
36​ device.getName(),
37​ null,
38​ device.getDeviceId()
39​ )
40​ );
41​ }
42​
43​ Collections.sort(commandItems, (lhs, rhs) -> ((CommandEntry) lhs).getName().compareTo(((CommandEntry) rhs).getName()));
44​
45​ ListAdapter adapter = new ListAdapter(RunCommandWidgetDeviceSelector.this, commandItems);
46​
47​ view.setAdapter(adapter);
48​ view.setOnItemClickListener((adapterView, viewContent, i, l) -> {
49​ CommandEntry entry = (CommandEntry) commandItems.get(i);
50​ RunCommandWidget.setCurrentDevice(entry.getKey());
51​
52​ Intent updateWidget = new Intent(RunCommandWidgetDeviceSelector.this, RunCommandWidget.class);
nicolasfellaUnsubmitted
Done

Lambda?

nicolasfella: Lambda?
53​ RunCommandWidgetDeviceSelector.this.sendBroadcast(updateWidget);
54​
55​ finish();
56​ });
57​ }));
58​ }
59​}
60​No newline at end of file
nicolasfellaUnsubmitted
Done

You can use lambda here

nicolasfella: You can use lambda here