Differential D13503 Diff 36077 plugins/remotecommands/remotecommand.h

Changeset View

Standalone View

plugins/remotecommands/remotecommand.h

This file was copied from plugins/remotecommands/remotecommandsplugin.h.

1	/**	1		/**
2	* Copyright 2016 Aleix Pol Gonzalez <aleixpol@kde.org>	2		* Copyright 2018 Nicolas Fella <nicolas.fella@gmx.de>
3	*	3		*
4	* This program is free software; you can redistribute it and/or	4		* This program is free software; you can redistribute it and/or
5	* modify it under the terms of the GNU General Public License as	5		* modify it under the terms of the GNU General Public License as
6	* published by the Free Software Foundation; either version 2 of	6		* published by the Free Software Foundation; either version 2 of
7	* the License or (at your option) version 3 or any later version	7		* the License or (at your option) version 3 or any later version
8	* accepted by the membership of KDE e.V. (or its successor approved	8		* accepted by the membership of KDE e.V. (or its successor approved
9	* by the membership of KDE e.V.), which shall act as a proxy	9		* by the membership of KDE e.V.), which shall act as a proxy
10	* defined in Section 14 of version 3 of the license.	10		* defined in Section 14 of version 3 of the license.
11	*	11		*
12	* This program is distributed in the hope that it will be useful,	12		* This program is distributed in the hope that it will be useful,
13	* but WITHOUT ANY WARRANTY; without even the implied warranty of	13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15	* GNU General Public License for more details.	15		* GNU General Public License for more details.
16	*	16		*
17	* You should have received a copy of the GNU General Public License	17		* You should have received a copy of the GNU General Public License
18	* along with this program. If not, see <http://www.gnu.org/licenses/>.	18		* along with this program. If not, see <http://www.gnu.org/licenses/>.
19	*/	19		*/
20		20
21	#ifndef REMOTECOMMANDSPLUGIN_H	21		#pragma once
			apolUnsubmitted Not Done Don't do that just here once apol: Don't do that just here once
22	#define REMOTECOMMANDSPLUGIN_H
23		22
24	#include <QObject>	23		#include <QObject>
25		24
26	#include <core/kdeconnectplugin.h>	25		class Remotecommand
27	#include <QFile>	26		: public QObject
28	#include <QFileSystemWatcher>
29	#include <QMap>
30	#include <QPair>
31	#include <QString>
32
33	class Q_DECL_EXPORT RemoteCommandsPlugin
34	: public KdeConnectPlugin
35	{	27		{
36	Q_OBJECT	28		Q_OBJECT
37	Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.remotecommands")	29		Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.remotecommands.remotecommand")
38	Q_PROPERTY(QByteArray commands READ commands NOTIFY commandsChanged)	30		Q_PROPERTY(QString key READ key CONSTANT)
			apolUnsubmitted Not Done Wouldn't it make sense to just return a QVariantMap or QJsonObject? Creating a dbus interface just to make it constant doesn't make a lot of sense. apol: Wouldn't it make sense to just return a QVariantMap or QJsonObject? Creating a dbus interface…
			nicolasfellaAuthorUnsubmitted Not Done I thought about that too when it was already too late. This way we already expose the parsed data, otherwise we would need to do that in the model (which would be fine). But the current approach would be beneficial if something else would use the DBus interface (some hypothetical extra UI) so we don't need to implement the parsing twice. nicolasfella: I thought about that too when it was already too late. This way we already expose the parsed…
			apolUnsubmitted Not Done Any UI will end up using the RemoteCommandsModel. apol: Any UI will end up using the RemoteCommandsModel.
		31		Q_PROPERTY(QString name READ name CONSTANT)
		32		Q_PROPERTY(QString command READ command CONSTANT)
39		33
40	public:	34		public:
41	explicit RemoteCommandsPlugin(QObject* parent, const QVariantList& args);	35		Remotecommand(QString key, QString name, QString command, QObject* parent);
42	~RemoteCommandsPlugin() override;
43
44	Q_SCRIPTABLE void triggerCommand(const QString& key);
45	QByteArray commands() const { return m_commands; }
46		36
47	bool receivePacket(const NetworkPacket& np) override;	37		QString key();
48	void connected() override;	38		QString name();
49	QString dbusPath() const override;	39		QString command();
50
51	Q_SIGNALS:
52	void commandsChanged(const QByteArray& commands);
53		40
54	private:	41		private:
55	void setCommands(const QByteArray& commands);	42		QString m_key;
		43		QString m_name;
		44		QString m_command;
56		45
57	QByteArray m_commands;
58	};	46		};
59
60	#endif