Differential D13372 Diff 36061 kcms/mouse/kcm/libinput/main.qml

Changeset View

Standalone View

View Options

kcms/mouse/kcm/libinput/main.qml

1/* 1​/*
2 * Copyright 2018 Roman Gilg <subdiff@gmail.com> 2​ * Copyright 2018 Roman Gilg <subdiff@gmail.com>
3​ * Copyright 2018 Furkan Tokac <furkantokac34@gmail.com>
3 * 4​ *
4 * This program is free software; you can redistribute it and/or modify 5​ * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by 6​ * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; either version 2 of the License, or 7​ * the Free Software Foundation; either version 2 of the License, or
7 * (at your option) any later version. 8​ * (at your option) any later version.
8 * 9​ *
9 * This program is distributed in the hope that it will be useful, 10​ * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 13​ * GNU General Public License for more details.
13 * 14​ *
14 * You should have received a copy of the GNU General Public License 15​ * You should have received a copy of the GNU General Public License
15 * along with this program; if not, write to the Free Software 16​ * along with this program; if not, write to the Free Software
16 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. 17​ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 */ 18​ */
18 19​
19import QtQuick 2.7 20​import QtQuick 2.7
20import QtQuick.Controls 1.4 as Controls 21​import QtQuick.Controls 2.0 as Controls
21import QtQuick.Layouts 1.3 as Layouts 22​import QtQuick.Layouts 1.3 as Layouts
22import QtQuick.Controls.Styles 1.4 as Styles 23​import QtQuick.Controls.Styles 1.4 as Styles
23 24​
24import org.kde.plasma.core 2.0 as PlasmaCore 25​import org.kde.kcm 1.1 as KCM
26​import org.kde.kirigami 2.4 as Kirigami
martUnsubmitted
Not Done

never import anything from plasma in a kcm (an exception which we have to solve is SortFilterProxyModel)
Kirigami has its own units

mart: never import anything from plasma in a kcm (an exception which we have to solve is…
25 27​
26import "components" 28​import "components"
27 29​
28Item { 30​// TODO: Change ScrollablePage as KCM.SimpleKCM
31​// after rewrite the KCM in KConfigModule.
32​Kirigami.ScrollablePage {
martUnsubmitted
Done

KCM.SimpleKCM

mart: KCM.SimpleKCM
furkantokacAuthorUnsubmitted
Done

This is not based on KConfigModule yet so it is not okay to convert it to SimpleKCM since it'll look for "kcm" reference from the backend but will not be able to find. It is added as TODO task to the code. After this rewrite, I am planning to work on the backend so that time it may be converted to

furkantokac: This is not based on KConfigModule yet so it is not okay to convert it to SimpleKCM since it'll…
29 id: root 33​ id: root
30 34​
31 property size sizeHint: Qt.size(maincol.width, maincol.height) 35​ spacing: Kirigami.Units.smallSpacing
32 property size minimumSizeHint: Qt.size(maincol.width/2, deviceSelector.height) 36​
ngrahamUnsubmitted
Done

Please re-add the minimumSizeHint line so that the window sizes itself properly when run with kcmshell5 mouse.

ngraham: Please re-add the `minimumSizeHint` line so that the window sizes itself properly when run with…
37​ property size sizeHint: Qt.size(formLayout.width, formLayout.height)
38​ property size minimumSizeHint: Qt.size(formLayout.width/2, deviceSelector.height)
39​
33 property alias deviceIndex: deviceSelector.currentIndex 40​ property alias deviceIndex: deviceSelector.currentIndex
34 signal changeSignal() 41​ signal changeSignal()
35 42​
36 property QtObject device 43​ property QtObject device
37 property int deviceCount: backend.deviceCount 44​ property int deviceCount: backend.deviceCount
38 45​
39 property bool loading: false 46​ property bool loading: false
40 47​
41 function resetModel(index) { 48​ function resetModel(index) {
42 deviceCount = backend.deviceCount 49​ deviceCount = backend.deviceCount
43 maincol.enabled = deviceCount 50​ formLayout.enabled = deviceCount
44 deviceSelector.enabled = deviceCount > 1 51​ deviceSelector.enabled = deviceCount > 1
45 52​
46 loading = true 53​ loading = true
47 if (deviceCount) { 54​ if (deviceCount) {
48 device = deviceModel[index] 55​ device = deviceModel[index]
49 deviceSelector.model = deviceModel 56​ deviceSelector.model = deviceModel
50 deviceSelector.currentIndex = index 57​ deviceSelector.currentIndex = index
51 console.log("Configuration of device '" + 58​ console.log("Configuration of device '" +
52 (index + 1) + " : " + device.name + "' opened") 59​ (index + 1) + " : " + device.name + "' opened")
53 } else { 60​ } else {
54 deviceSelector.model = [""] 61​ deviceSelector.model = [""]
55 console.log("No device found") 62​ console.log("No device found")
56 } 63​ }
57 loading = false 64​ loading = false
58 } 65​ }
59 66​
60 function syncValuesFromBackend() { 67​ function syncValuesFromBackend() {
61 loading = true 68​ loading = true
62 69​
63 deviceEnabled.load() 70​ deviceEnabled.load()
64 leftHanded.load() 71​ leftHanded.load()
65 accelSpeed.load() 72​ accelSpeed.load()
66 accelProfile.load() 73​ accelProfile.load()
67 ​
68 naturalScroll.load() 74​ naturalScroll.load()
69 75​
70 loading = false 76​ loading = false
71 } 77​ }
72 78​
73 Controls.ScrollView { 79​ Kirigami.FormLayout {
74 anchors.fill: parent 80​ id: formLayout
75 ​
76 Layouts.ColumnLayout { ​
77 id: maincol ​
78 enabled: deviceCount 81​ enabled: deviceCount
romanggUnsubmitted
Done

This needs to stay. Try it without mouse being connected.

romangg: This needs to stay. Try it without mouse being connected.
79 spacing: units.largeSpacing ​
80 ​
81 Layouts.RowLayout { ​
82 spacing: units.largeSpacing ​
83 ​
84 Controls.Label { ​
85 text: i18n("Device:") ​
86 } ​
87 82​
83​ // Device
88 Controls.ComboBox { 84​ Controls.ComboBox {
85​ Kirigami.FormData.label: i18n("Device:")
89 id: deviceSelector 86​ id: deviceSelector
90 enabled: deviceCount > 1 87​ enabled: deviceCount > 1
91 Layouts.Layout.fillWidth: true 88​ Layouts.Layout.fillWidth: true
92 model: deviceModel 89​ model: deviceModel
93 textRole: "name" 90​ textRole: "name"
94 91​
95 onCurrentIndexChanged: { 92​ onCurrentIndexChanged: {
96 if (deviceCount) { 93​ if (deviceCount) {
97 device = deviceModel[currentIndex] 94​ device = deviceModel[currentIndex]
98 if (!loading) { 95​ if (!loading) {
99 changeSignal() 96​ changeSignal()
100 } 97​ }
101 console.log("Configuration of device '" + 98​ console.log("Configuration of device '" +
102 (currentIndex+1) + " : " + device.name + "' opened") 99​ (currentIndex+1) + " : " + device.name + "' opened")
103 } 100​ }
104 root.syncValuesFromBackend() 101​ root.syncValuesFromBackend()
105 } 102​ }
106 } 103​ }
107 } ​
108 104​
109 Column { 105​ Kirigami.Separator {
110 spacing: units.smallSpacing * 2 ​
111 ​
112 Column { ​
113 leftPadding: units.smallSpacing ​
114 Column { ​
115 spacing: units.smallSpacing ​
116 Controls.Label { ​
117 text: i18n("General settings:") ​
118 } 106​ }
martUnsubmitted
Not Done

this is broken, it needs Kirigami.FormData.isSection: true
if you don't want it to be visible, it shouldn't be a Separator, but for sure it shouldn't be a broken separator

mart: this is broken, it needs Kirigami.FormData.isSection: true if you don't want it to be visible…
119 107​
120 Column { 108​ // General
121 leftPadding: units.smallSpacing ​
122 Column { ​
123 spacing: units.smallSpacing ​
124 Controls.CheckBox { 109​ Controls.CheckBox {
110​ Kirigami.FormData.label: i18n("General:")
125 id: deviceEnabled 111​ id: deviceEnabled
126 text: i18n("Device enabled") 112​ text: i18n("Device enabled")
127 113​
128 function load() { 114​ function load() {
129 if (!maincol.enabled) { 115​ if (!formLayout.enabled) {
130 checked = false 116​ checked = false
131 return 117​ return
132 } 118​ }
133 enabled = device.supportsDisableEvents 119​ enabled = device.supportsDisableEvents
134 checked = enabled && device.enabled 120​ checked = enabled && device.enabled
135 } 121​ }
136 122​
137 onCheckedChanged: { 123​ onCheckedChanged: {
138 if (enabled && !root.loading) { 124​ if (enabled && !root.loading) {
139 device.enabled = checked 125​ device.enabled = checked
140 root.changeSignal() 126​ root.changeSignal()
141 } 127​ }
142 } 128​ }
143 129​
144 ToolTip { 130​ ToolTip {
145 text: i18n("Accept input through this device.") 131​ text: i18n("Accept input through this device.")
146 } 132​ }
147 } 133​ }
148 134​
149 Controls.CheckBox { 135​ Controls.CheckBox {
150 id: leftHanded 136​ id: leftHanded
151 text: i18n("Left handed mode") 137​ text: i18n("Left handed mode")
152 138​
153 function load() { 139​ function load() {
154 if (!maincol.enabled) { 140​ if (!formLayout.enabled) {
155 checked = false 141​ checked = false
156 return 142​ return
157 } 143​ }
158 enabled = device.supportsLeftHanded 144​ enabled = device.supportsLeftHanded
159 checked = enabled && device.leftHanded 145​ checked = enabled && device.leftHanded
160 } 146​ }
161 147​
162 onCheckedChanged: { 148​ onCheckedChanged: {
163 if (enabled && !root.loading) { 149​ if (enabled && !root.loading) {
164 device.leftHanded = checked 150​ device.leftHanded = checked
165 root.changeSignal() 151​ root.changeSignal()
166 } 152​ }
167 } 153​ }
168 154​
169 ToolTip { 155​ ToolTip {
170 text: i18n("Swap left and right buttons.") 156​ text: i18n("Swap left and right buttons.")
171 } 157​ }
172 } 158​ }
173 159​
174 Controls.CheckBox { 160​ Controls.CheckBox {
175 id: middleEmulation 161​ id: middleEmulation
176 text: i18n("Emulate middle button") 162​ text: i18n("Press left and right buttons for middle-click")
177 163​
178 function load() { 164​ function load() {
179 if (!maincol.enabled) { 165​ if (!formLayout.enabled) {
180 checked = false 166​ checked = false
181 return 167​ return
182 } 168​ }
183 enabled = device.supportsMiddleEmulation 169​ enabled = device.supportsMiddleEmulation
184 checked = enabled && device.middleEmulation 170​ checked = enabled && device.middleEmulation
185 } 171​ }
186 172​
187 onCheckedChanged: { 173​ onCheckedChanged: {
188 if (enabled && !root.loading) { 174​ if (enabled && !root.loading) {
189 device.middleEmulation = checked 175​ device.middleEmulation = checked
190 root.changeSignal() 176​ root.changeSignal()
191 } 177​ }
192 } 178​ }
193 179​
194 ToolTip { 180​ ToolTip {
195 text: i18n("Clicking left and right button simultaneously sends middle button click.") 181​ text: i18n("Clicking left and right button simultaneously sends middle button click.")
196 } 182​ }
197 } 183​ }
198 } ​
199 } ​
200 } ​
201 } ​
202 184​
203 Column { 185​ Kirigami.Separator {
204 leftPadding: units.smallSpacing ​
205 Column { ​
206 spacing: units.smallSpacing ​
207 Controls.Label { ​
208 text: i18n("Acceleration:") ​
209 } 186​ }
210 187​
211 Column { 188​ // Acceleration
212 leftPadding: units.smallSpacing ​
213 Column { ​
214 spacing: units.smallSpacing * 2 ​
215 ​
216 Row { ​
217 Controls.Slider { 189​ Controls.Slider {
190​ Kirigami.FormData.label: i18n("Pointer speed:")
218 id: accelSpeed 191​ id: accelSpeed
219 anchors.verticalCenter: parent.verticalCenter ​
220 192​
221 tickmarksEnabled: true 193​ tickmarksEnabled: true
222 194​
223 minimumValue: 1 195​ from: 1
224 maximumValue: 10 196​ to: 10
225 stepSize: 1 197​ stepSize: 1
226 198​
227 implicitWidth: units.gridUnit * 9 ​
228 ​
229 function load() { 199​ function load() {
martUnsubmitted
Not Done

Kirigami.Units.gridUnit

(tough controls shouldn't have explicit widths set)

mart: Kirigami.Units.gridUnit (tough controls shouldn't have explicit widths set)
230 enabled = device.supportsPointerAcceleration 200​ enabled = device.supportsPointerAcceleration
231 if (!enabled) { 201​ if (!enabled) {
232 value = 0.1 202​ value = 0.1
233 return 203​ return
234 } 204​ }
235 // transform libinput's pointer acceleration range [-1, 1] to slider range [1, 10] 205​ // transform libinput's pointer acceleration range [-1, 1] to slider range [1, 10]
236 value = 4.5 * device.pointerAcceleration + 5.5 206​ value = 4.5 * device.pointerAcceleration + 5.5
237 } 207​ }
238 208​
239 onValueChanged: { 209​ onValueChanged: {
240 if (device != undefined && enabled && !root.loading) { 210​ if (device != undefined && enabled && !root.loading) {
241 // transform slider range [1, 10] to libinput's pointer acceleration range [-1, 1] 211​ // transform slider range [1, 10] to libinput's pointer acceleration range [-1, 1]
242 device.pointerAcceleration = Math.round( (value - 5.5) / 4.5 * 100 ) / 100 212​ device.pointerAcceleration = Math.round( (value - 5.5) / 4.5 * 100 ) / 100
243 root.changeSignal() 213​ root.changeSignal()
244 } 214​ }
245 } 215​ }
246 } 216​ }
247 } ​
248 217​
249 ExclGroupBox { 218​ Controls.ColumnLayout {
250 id: accelProfile 219​ id: accelProfile
251 label: i18n("Acceleration Profile:") 220​ spacing: Kirigami.Units.smallSpacing
martUnsubmitted
Not Done

radiobuttons are auto exclusive now

mart: radiobuttons are auto exclusive now
252 model: [i18n("Flat"), i18n("Adaptive")] 221​ Kirigami.FormData.label: i18n("Acceleration profile:")
222​ Kirigami.FormData.buddyFor: accelProfileFlat
253 223​
254 function load() { 224​ function load() {
255 enabled = device.supportsPointerAccelerationProfileAdaptive 225​ enabled = device.supportsPointerAccelerationProfileAdaptive
256 226​
257 if (!enabled) { 227​ if (!enabled) {
258 itemAt(0).checked = false 228​ accelProfileAdaptive.checked = false
259 itemAt(1).checked = false 229​ accelProfileFlat.checked = false
260 return 230​ return
261 } 231​ }
262 232​
263 itemAt(0).tooltiptext = i18n("Cursor moves the same distance as finger.") 233​ if(device.pointerAccelerationProfileAdaptive) {
264 itemAt(1).tooltiptext = i18n("Cursor travel distance depends on movement speed of finger.") 234​ accelProfileAdaptive.checked = true
265 235​ accelProfileFlat.checked = false
266 var toCheck = device.pointerAccelerationProfileAdaptive ? 1 : 0 236​ } else {
267 itemAt(toCheck).checked = true 237​ accelProfileAdaptive.checked = false
238​ accelProfileFlat.checked = true
239​ }
268 } 240​ }
269 241​
270 onCurrentChanged: { 242​ function syncCurrent() {
271 if (enabled && !root.loading) { 243​ if (enabled && !root.loading) {
272 device.pointerAccelerationProfileFlat = itemAt(0).checked 244​ device.pointerAccelerationProfileFlat = accelProfileFlat.checked
273 device.pointerAccelerationProfileAdaptive = itemAt(1).checked 245​ device.pointerAccelerationProfileAdaptive = accelProfileAdaptive.checked
274 root.changeSignal() 246​ root.changeSignal()
275 } 247​ }
276 } 248​ }
249​
250​ Controls.RadioButton {
251​ id: accelProfileFlat
252​ text: i18n("Flat")
253​
254​ ToolTip {
255​ text: i18n("Cursor moves the same distance as the mouse movement.")
277 } 256​ }
257​ onCheckedChanged: accelProfile.syncCurrent()
278 } 258​ }
259​
260​ Controls.RadioButton {
261​ id: accelProfileAdaptive
262​ text: i18n("Adaptive")
263​
264​ ToolTip {
265​ text: i18n("Cursor travel distance depends on the mouse movement speed.")
279 } 266​ }
267​ onCheckedChanged: accelProfile.syncCurrent()
280 } 268​ }
281 } 269​ }
282 270​
283 Column { 271​ Kirigami.Separator {
284 leftPadding: units.smallSpacing ​
285 Column { ​
286 spacing: units.smallSpacing ​
287 Controls.Label { ​
288 text: i18n("Scrolling:") ​
289 } 272​ }
290 273​
291 Column { 274​ // Scrolling
292 leftPadding: units.smallSpacing ​
293 Column { ​
294 spacing: units.smallSpacing ​
295 ​
296 Controls.CheckBox { 275​ Controls.CheckBox {
276​ Kirigami.FormData.label: i18n("Scrolling:")
297 id: naturalScroll 277​ id: naturalScroll
298 text: i18n("Invert scroll direction") 278​ text: i18n("Invert scroll direction")
299 279​
300 function load() { 280​ function load() {
301 enabled = device.supportsNaturalScroll 281​ enabled = device.supportsNaturalScroll
302 checked = enabled && device.naturalScroll 282​ checked = enabled && device.naturalScroll
303 } 283​ }
304 284​
305 onCheckedChanged: { 285​ onCheckedChanged: {
306 if (enabled && !root.loading) { 286​ if (enabled && !root.loading) {
307 device.naturalScroll = checked 287​ device.naturalScroll = checked
308 root.changeSignal() 288​ root.changeSignal()
309 } 289​ }
310 } 290​ }
311 291​
312 ToolTip { 292​ ToolTip {
313 text: i18n("Touchscreen like scrolling.") 293​ text: i18n("Touchscreen like scrolling.")
314 } 294​ }
315 } 295​ }
316 } 296​ }
317 } 297​}
furkantokacAuthorUnsubmitted
Done

This label doesn't show up. If we put it to Column, it shows up vertically centered. Please recommend a solution for this.

furkantokac: This label doesn't show up. If we put it to Column, it shows up vertically centered. Please…
318 } ​
319 } ​
320 } ​
321 } ​
322 } ​
323} ​