Changeset View
Changeset View
Standalone View
Standalone View
CMakeLists.txt
Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Line(s) | 52 | set_package_properties(DNSSD PROPERTIES DESCRIPTION "Facilities for service discovery on a local network" | |||
---|---|---|---|---|---|
53 | URL "http://avahi.org" | 53 | URL "http://avahi.org" | ||
54 | TYPE OPTIONAL | 54 | TYPE OPTIONAL | ||
55 | PURPOSE "Either Avahi or DNSSD is required for KDE applications to make use of multicast DNS/DNS-SD service discovery" | 55 | PURPOSE "Either Avahi or DNSSD is required for KDE applications to make use of multicast DNS/DNS-SD service discovery" | ||
56 | ) | 56 | ) | ||
57 | endif( ) | 57 | endif( ) | ||
58 | 58 | | |||
59 | if(AVAHI_FOUND OR DNSSD_FOUND) | 59 | if(AVAHI_FOUND OR DNSSD_FOUND) | ||
60 | find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) | 60 | find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) | ||
61 | else() | ||||
62 | message(FATAL_ERROR "Either Avahi or DNSSD is required for KDE applications to make use of multicast DNS/DNS-SD service discovery") | ||||
61 | endif() | 63 | endif() | ||
62 | 64 | | |||
63 | if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") | 65 | if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") | ||
64 | ecm_install_po_files_as_qm(po) | 66 | ecm_install_po_files_as_qm(po) | ||
65 | endif() | 67 | endif() | ||
66 | 68 | | |||
krop: wrong place | |||||
Hi. If you're posting a review, please provide constructive input. If there are policies or guidelines about places, please link to them. If there aren't, but you would prefer a change, please describe the (outline of the) change. If you mean "there should be an additional space in the else() statement to match the text formatting from line 57", then write that. adridg: Hi. If you're posting a review, please provide constructive input. If there are policies or… | |||||
your else() follows if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po"), I thought the comment was clear. Your current patch means: if there's no "po" subdir, throw a fatal error with an unrelated message. krop: your else() follows if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po"), I thought the comment… | |||||
67 | remove_definitions(-DQT_NO_CAST_FROM_ASCII) | 69 | remove_definitions(-DQT_NO_CAST_FROM_ASCII) | ||
68 | 70 | | |||
69 | add_subdirectory(src) | 71 | add_subdirectory(src) | ||
70 | 72 | | |||
71 | set(CMAKECONFIG_INSTALL_DIR "${KDE_INSTALL_CMAKEPACKAGEDIR}/KF5DNSSD") | 73 | set(CMAKECONFIG_INSTALL_DIR "${KDE_INSTALL_CMAKEPACKAGEDIR}/KF5DNSSD") | ||
72 | 74 | | |||
73 | if (BUILD_QCH) | 75 | if (BUILD_QCH) | ||
74 | ecm_install_qch_export( | 76 | ecm_install_qch_export( | ||
Show All 23 Lines |
wrong place