Changeset View
Changeset View
Standalone View
Standalone View
app/mainwindow.cpp
Show First 20 Lines • Show All 316 Lines • ▼ Show 20 Line(s) | 315 | { | |||
---|---|---|---|---|---|
317 | connect(mViewMainPage, SIGNAL(captionUpdateRequested(QString)), | 317 | connect(mViewMainPage, SIGNAL(captionUpdateRequested(QString)), | ||
318 | q, SLOT(slotUpdateCaption(QString))); | 318 | q, SLOT(slotUpdateCaption(QString))); | ||
319 | connect(mViewMainPage, SIGNAL(completed()), | 319 | connect(mViewMainPage, SIGNAL(completed()), | ||
320 | q, SLOT(slotPartCompleted())); | 320 | q, SLOT(slotPartCompleted())); | ||
321 | connect(mViewMainPage, SIGNAL(previousImageRequested()), | 321 | connect(mViewMainPage, SIGNAL(previousImageRequested()), | ||
322 | q, SLOT(goToPrevious())); | 322 | q, SLOT(goToPrevious())); | ||
323 | connect(mViewMainPage, SIGNAL(nextImageRequested()), | 323 | connect(mViewMainPage, SIGNAL(nextImageRequested()), | ||
324 | q, SLOT(goToNext())); | 324 | q, SLOT(goToNext())); | ||
325 | connect(mViewMainPage, &ViewMainPage::openUrlRequested, | ||||
rkflx: I don't see why you'd need `QObject` here? | |||||
Ah, I didn't notice MainWindow::Private struct was actually a member of MainWindow (they are usually separate). Qt Creator puts up a warning for all the naked connects complaining of too many arguments, so I thought something weird was going on. huoni: Ah, I didn't notice `MainWindow::Private` struct was actually a member of `MainWindow` (they… | |||||
Switching to the Clang code model in Qt Creator should resolve the warning. It's pretty nice compared to the simpler built-in code model: https://doc.qt.io/qtcreator/creator-clang-codemodel.html rkflx: Switching to the Clang code model in Qt Creator should resolve the warning. It's pretty nice… | |||||
326 | q, &MainWindow::openUrl); | ||||
327 | connect(mViewMainPage, &ViewMainPage::openDirUrlRequested, | ||||
328 | q, &MainWindow::openDirUrl); | ||||
325 | 329 | | |||
326 | setupThumbnailBar(mViewMainPage->thumbnailBar()); | 330 | setupThumbnailBar(mViewMainPage->thumbnailBar()); | ||
327 | } | 331 | } | ||
328 | 332 | | |||
329 | void setupThumbnailBar(ThumbnailView* bar) | 333 | void setupThumbnailBar(ThumbnailView* bar) | ||
330 | { | 334 | { | ||
331 | Q_ASSERT(mThumbnailBarModel); | 335 | Q_ASSERT(mThumbnailBarModel); | ||
332 | Q_ASSERT(mThumbnailBarSelectionModel); | 336 | Q_ASSERT(mThumbnailBarSelectionModel); | ||
▲ Show 20 Lines • Show All 1377 Lines • Show Last 20 Lines |
I don't see why you'd need QObject here?